Always use strictEqual to ensure null and undefined values are asserted correctly - #59
Closed
marcbachmann wants to merge 1 commit into
Closed
Always use strictEqual to ensure null and undefined values are asserted correctly#59marcbachmann wants to merge 1 commit into
marcbachmann wants to merge 1 commit into
Conversation
marcbachmann
commented
Jul 13, 2022
CollaboratorAuthor
Included in #50 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Just saw that some assertions were wrong.
assert.equalis deprecated and behaves slightly different with null/undefined.const obj = {a: 'foo'} // This returned undefined, but accepted null in the comparison - assert.equal(jsonpointer.get(obj, '/b'), null)+ assert.strictEqual(jsonpointer.get(obj, '/b'), undefined)Migrating everything to
assert.strictEqualis more explicit.