Uh oh!
There was an error while loading. Please reload this page.
fix: qualify enum constant names in @Default expressions (#260) - #270
Merged
Conversation
@default on an enum-typed field generated an unqualified constant name (e.g. `GOOD`) causing a compilation error. The processor now detects enum field types via TypeName.enumType and qualifies simple constant names with the enum class name (e.g. `ItemCondition.GOOD`). Already-qualified names and complex expressions like `new ScoreValue(12)` are left untouched. Generated with [Devin](https://devin.ai) Co-Authored-By: Devin <158243242+devin-ai-integration[bot]@users.noreply.github.com>
Generated with [Devin](https://devin.ai) Co-Authored-By: Devin <158243242+devin-ai-integration[bot]@users.noreply.github.com>
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
Uh oh!
There was an error while loading. Please reload this page.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes#260.
@default on an enum-typed field generated an unqualified constant name (e.g.
GOOD), causing a compilation error. The processor now:TypeName.enumTypeflag, set inJavaLangMapper.extractType()when theTypeElementhasElementKind.ENUMformatDefaultExpression()(e.g.GOOD→ItemCondition.GOOD)Priority.HIGH) and complex expressions (new ScoreValue(12)) untouchedAdded 4 test cases covering enum defaults in records, setter-based classes, already-qualified values, and complex constructor expressions.