Skip to content

Ninja code - #109

Merged
joaquinelio merged 19 commits into
javascript-tutorial:masterfrom
Sjesc:ninja-code-2
Jun 7, 2020
Merged

Ninja code#109
joaquinelio merged 19 commits into
javascript-tutorial:masterfrom
Sjesc:ninja-code-2

Conversation

@Sjesc

@SjescSjesc commented Oct 4, 2019

Copy link
Copy Markdown
Contributor

No description provided.

@javascript-translate-bot
javascript-translate-bot requested a review from a teamOctober 4, 2019 23:14
@iliakaniliakan mentioned this pull request Oct 4, 2019
Open
EzequielCaste
EzequielCaste requested changes May 30, 2020
View reviewed changes

@EzequielCasteEzequielCaste left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

corregir

Comment thread1-js/03-code-quality/04-ninja-code/article.md Outdated
Comment thread1-js/03-code-quality/04-ninja-code/article.md Outdated
Comment thread1-js/03-code-quality/04-ninja-code/article.md Outdated
Comment thread1-js/03-code-quality/04-ninja-code/article.md Outdated
Comment thread1-js/03-code-quality/04-ninja-code/article.md Outdated
Comment thread1-js/03-code-quality/04-ninja-code/article.md Outdated
A fellow programmer who wants to work with `elem` in the second half of the function will be surprised... Only during the debugging, after examining the code they will find out that they're working with a clone!

Seen in code regularly. Deadly effective even against an experienced ninja.
Un compañero de programación que quiera trabajar con `elem` en la segunda mitad de la función será sorprendido... Solo durante la depuración, después de examinar el código encontrara que está trabajando con un clon.

@EzequielCasteEzequielCasteMay 30, 2020

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
Un compañero de programación que quiera trabajar con `elem` en la segunda mitad de la función será sorprendido... Solo durante la depuración, después de examinar el código encontrara que está trabajando con un clon.
Un colega programador que quiera trabajar con `elem` en la segunda mitad de la función será sorprendido... Solo durante la depuración, después de examinar el código encontrara que está trabajando con un clon.

Comment thread1-js/03-code-quality/04-ninja-code/article.md Outdated
Comment thread1-js/03-code-quality/04-ninja-code/article.md Outdated
Comment thread1-js/03-code-quality/04-ninja-code/article.md Outdated
Comment thread1-js/03-code-quality/04-ninja-code/article.md Outdated
@javascript-translate-bot

javascript-translate-bot commented May 30, 2020

Copy link
Copy Markdown

Please make the requested changes. After it, add a comment "/done".
Then I'll ask for a new review 👻

joaquinelio
joaquinelio requested changes May 30, 2020
View reviewed changes

@joaquineliojoaquinelio left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Se ve lindo.
@ezzep66 , ¿seguimos con doble revisión?
Lo hice encima de la tuya así apenas se corrige la podés subir.
Si pensás que no hacen falta, disculpas.

La gramática no es el tema más importante en JS. Ni siquiera para la virtual machine jeje

Comment thread1-js/03-code-quality/04-ninja-code/article.md Outdated
Comment thread1-js/03-code-quality/04-ninja-code/article.md
Comment thread1-js/03-code-quality/04-ninja-code/article.md Outdated
Comment thread1-js/03-code-quality/04-ninja-code/article.md Outdated
Comment thread1-js/03-code-quality/04-ninja-code/article.md Outdated
Comment thread1-js/03-code-quality/04-ninja-code/article.md Outdated
Comment thread1-js/03-code-quality/04-ninja-code/article.md Outdated
Comment thread1-js/03-code-quality/04-ninja-code/article.md Outdated
@javascript-translate-bot

javascript-translate-bot commented May 30, 2020

Copy link
Copy Markdown

Please make the requested changes. After it, add a comment "/done".
Then I'll ask for a new review 👻

@EzequielCaste

EzequielCaste commented Jun 1, 2020

Copy link
Copy Markdown
Contributor

qué se hace si @Sjesc no responde?

podemos nosotros maintainers corregir?

@vplentinax

vplentinax commented Jun 5, 2020

Copy link
Copy Markdown
Contributor

Si, tenemos que corregir @ezzep66@joaquinelio

vplentinaxand others added 12 commits June 6, 2020 00:44
@vplentinax@EzequielCaste
Update 1-js/03-code-quality/04-ninja-code/article.md
55b0703
Co-authored-by: Ezequiel Castellanos <51804994+ezzep66@users.noreply.github.com>
@vplentinax@EzequielCaste
Update 1-js/03-code-quality/04-ninja-code/article.md
8d66ef6
Co-authored-by: Ezequiel Castellanos <51804994+ezzep66@users.noreply.github.com>
@vplentinax@EzequielCaste
Update 1-js/03-code-quality/04-ninja-code/article.md
0bfb298
Co-authored-by: Ezequiel Castellanos <51804994+ezzep66@users.noreply.github.com>
@vplentinax@EzequielCaste
Update 1-js/03-code-quality/04-ninja-code/article.md
4b859ed
Co-authored-by: Ezequiel Castellanos <51804994+ezzep66@users.noreply.github.com>
@vplentinax@EzequielCaste
Update 1-js/03-code-quality/04-ninja-code/article.md
6403c9c
Co-authored-by: Ezequiel Castellanos <51804994+ezzep66@users.noreply.github.com>
@vplentinax@EzequielCaste
Update 1-js/03-code-quality/04-ninja-code/article.md
131d030
Co-authored-by: Ezequiel Castellanos <51804994+ezzep66@users.noreply.github.com>
@vplentinax@EzequielCaste
Update 1-js/03-code-quality/04-ninja-code/article.md
82e2a7b
Co-authored-by: Ezequiel Castellanos <51804994+ezzep66@users.noreply.github.com>
@vplentinax@EzequielCaste
Update 1-js/03-code-quality/04-ninja-code/article.md
4ab0735
Co-authored-by: Ezequiel Castellanos <51804994+ezzep66@users.noreply.github.com>
@vplentinax@EzequielCaste
Update 1-js/03-code-quality/04-ninja-code/article.md
7e4afd4
Co-authored-by: Ezequiel Castellanos <51804994+ezzep66@users.noreply.github.com>
@vplentinax@EzequielCaste
Update 1-js/03-code-quality/04-ninja-code/article.md
4a958df
Co-authored-by: Ezequiel Castellanos <51804994+ezzep66@users.noreply.github.com>
@vplentinax@EzequielCaste
Update 1-js/03-code-quality/04-ninja-code/article.md
8293857
Co-authored-by: Ezequiel Castellanos <51804994+ezzep66@users.noreply.github.com>
@joaquinelio@EzequielCaste
Update 1-js/03-code-quality/04-ninja-code/article.md
6eea635
Co-authored-by: Ezequiel Castellanos <51804994+ezzep66@users.noreply.github.com>
joaquinelioand others added 3 commits June 7, 2020 02:12
@joaquinelio@EzequielCaste
Apply suggestions from code review
071d440
11 sugerencias ok
Co-authored-by: Ezequiel Castellanos <51804994+ezzep66@users.noreply.github.com>
@joaquinelio
Update article.md
d80ddf0
@joaquinelio
Update article.md
bef085b
@joaquinelio
joaquinelio merged commit fd721d0 into javascript-tutorial:masterJun 7, 2020
@javascript-translate-bot

javascript-translate-bot commented Jun 7, 2020

Copy link
Copy Markdown

Thank you 💖 I updated the Progress Issue #17 🎉 🎉 🎉

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@EzequielCasteEzequielCasteEzequielCaste requested changes
@joaquineliojoaquineliojoaquinelio approved these changes

Assignees

No one assigned

Labels

needs +1

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@Sjesc@javascript-translate-bot@EzequielCaste@vplentinax@joaquinelio