Skip to content

The "new Function" syntax - #120

Merged
EzequielCaste merged 13 commits into
javascript-tutorial:masterfrom
11joselu:new-function
Jun 16, 2020
Merged

The "new Function" syntax#120
EzequielCaste merged 13 commits into
javascript-tutorial:masterfrom
11joselu:new-function

Conversation

@11joselu

@11joselu11joselu commented Nov 2, 2019

Copy link
Copy Markdown
Contributor

No description provided.

@javascript-translate-bot
javascript-translate-bot requested a review from a teamNovember 2, 2019 17:56
@iliakaniliakan mentioned this pull request Nov 2, 2019
Open
@CLAassistant

CLAassistant commented Nov 2, 2019•
edited
Loading

Copy link
Copy Markdown

CLA assistant check
All committers have signed the CLA.

jose-oscategui
jose-oscategui reviewed Nov 15, 2019
View reviewed changes

@jose-oscateguijose-oscategui left a comment •
edited
Loading

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hola ✋ @11joselu , gracias por la traducción, hay unos cambios que se necesitaría hacer antes poder unirlo a la traducción.

Comment thread1-js/06-advanced-functions/07-new-function/article.md Outdated
Comment thread1-js/06-advanced-functions/07-new-function/article.md Outdated
Comment thread1-js/06-advanced-functions/07-new-function/article.md Outdated
Comment thread1-js/06-advanced-functions/07-new-function/article.md Outdated
Comment thread1-js/06-advanced-functions/07-new-function/article.md Outdated
@11joselu

11joselu commented Nov 25, 2019

Copy link
Copy Markdown
ContributorAuthor

@JOsktgui Gracias por el feedback :)

Cambios hechos 👍

spideep
spideep suggested changes Dec 10, 2019
View reviewed changes
Comment thread1-js/06-advanced-functions/07-new-function/article.md Outdated
Comment thread1-js/06-advanced-functions/07-new-function/article.md Outdated
Comment thread1-js/06-advanced-functions/07-new-function/article.md
Comment thread1-js/06-advanced-functions/07-new-function/article.md
Comment thread1-js/06-advanced-functions/07-new-function/article.md
Comment thread1-js/06-advanced-functions/07-new-function/article.md
Comment thread1-js/06-advanced-functions/07-new-function/article.md
Comment thread1-js/06-advanced-functions/07-new-function/article.md
Comment thread1-js/06-advanced-functions/07-new-function/article.md
Comment thread1-js/06-advanced-functions/07-new-function/article.md
@javascript-translate-bot

javascript-translate-bot commented Dec 10, 2019

Copy link
Copy Markdown

Please make the requested changes. After it, add a comment "/done".
Then I'll ask for a new review 👻

EzequielCaste
EzequielCaste approved these changes Jun 16, 2020
View reviewed changes
Comment thread1-js/06-advanced-functions/07-new-function/article.md Outdated
Comment thread1-js/06-advanced-functions/07-new-function/article.md Outdated
Comment thread1-js/06-advanced-functions/07-new-function/article.md Outdated
Comment thread1-js/06-advanced-functions/07-new-function/article.md Outdated
Comment thread1-js/06-advanced-functions/07-new-function/article.md Outdated
Comment thread1-js/06-advanced-functions/07-new-function/article.md Outdated
Comment thread1-js/06-advanced-functions/07-new-function/article.md Outdated
Comment thread1-js/06-advanced-functions/07-new-function/article.md Outdated
Comment thread1-js/06-advanced-functions/07-new-function/article.md Outdated
Comment thread1-js/06-advanced-functions/07-new-function/article.md Outdated
@EzequielCaste
EzequielCaste merged commit 943b805 into javascript-tutorial:masterJun 16, 2020
@javascript-translate-bot

javascript-translate-bot commented Jun 16, 2020

Copy link
Copy Markdown

Thank you 💖 I updated the Progress Issue #17 🎉 🎉 🎉

@11joselu

11joselu commented Jun 17, 2020

Copy link
Copy Markdown
ContributorAuthor

Gracias @ezzep66

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@EzequielCasteEzequielCasteEzequielCaste approved these changes
+2 more reviewers
@jose-oscateguijose-oscateguijose-oscategui left review comments
@spideepspideepspideep requested changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

needs +1

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

7 participants

@11joselu@CLAassistant@javascript-translate-bot@spideep@jose-oscategui@EzequielCaste@vplentinax