Skip to content

WeakMap and WeakSet - #176

Merged
EzequielCaste merged 12 commits into
javascript-tutorial:masterfrom
vplentinax:weak
Jun 15, 2020
Merged

WeakMap and WeakSet#176
EzequielCaste merged 12 commits into
javascript-tutorial:masterfrom
vplentinax:weak

Conversation

@vplentinax

@vplentinaxvplentinax commented May 10, 2020

Copy link
Copy Markdown
Contributor

No description provided.

@javascript-translate-bot
javascript-translate-bot requested a review from a teamMay 10, 2020 06:22
@iliakaniliakan mentioned this pull request May 10, 2020
Open
cortizg
cortizg reviewed Jun 9, 2020
View reviewed changes

@cortizgcortizg left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

discrepo en dejar Array en las traducciones, este review lo dejo como comentario, pero hay unas traducciones pequeñas que se pasaron por alto como "Like this"

Comment thread1-js/05-data-types/weakmap-weakset/01-recipients-read/solution.md
Otra solución diferente podría ser agregar una propiedad como `message.isRead = true` a un mensaje después de leerlo. Como los objetos de mensajes son administrados por otro código, generalmente se desaconseja, pero podemos usar una propiedad simbólica para evitar conflictos.

Like this:
```js

@cortizgcortizgJun 9, 2020

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Como esto:

Comment thread1-js/05-data-types/weakmap-weakset/01-recipients-read/task.md

---

# Almacenar banderas "no leídas"

@cortizgcortizgJun 9, 2020

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Mencionaba Joaquin que banderas se deja como flags, tal como hace MDN

Comment thread1-js/05-data-types/weakmap-weakset/01-recipients-read/task.md
# Almacenar banderas "no leídas"

Hay un array de mensajes:

@cortizgcortizgJun 9, 2020

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

array es arreglo, incluso MDN dice arreglo

Comment thread1-js/05-data-types/weakmap-weakset/02-recipients-when-read/task.md

# Almacenar fechas de lectura

Hay un array semejante al de la actividad anterior [previous task](info:task/recipients-read). La sitación es similar:

@cortizgcortizgJun 9, 2020

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

array es arreglo https://developer.mozilla.org/es/docs/Glossary/Arreglos

Comment thread1-js/05-data-types/weakmap-weakset/02-recipients-when-read/task.md Outdated

En la tarea anterior solo necesitábamos almacenar el hecho de "sí / no". Ahora necesitamos almacenar la fecha, y solo debe permanecer en la memoria hasta que el mensaje sea recolectado como basura.

P.D Las fechas se pueden almacenar como objetos de la clase incorporada `Fecha`, que cubriremos más adelante.

@cortizgcortizgJun 9, 2020

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

la clase incorporada (builtin) se llama Date: OJO

Comment thread1-js/05-data-types/weakmap-weakset/article.md

Por lo general, las propiedades de un objeto o elementos de un array u otra estructura de datos se consideran accesibles y se mantienen en la memoria mientras esa estructura de datos permanezca en la memoria.

Por ejemplo, si colocamos un objeto en un array, mientras el array esté vivo, el objeto también estará vivo, incluso si no hay otras referencias a él.

@cortizgcortizgJun 9, 2020

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

array es arreglo https://developer.mozilla.org/es/docs/Glossary/Arreglos

Comment thread1-js/05-data-types/weakmap-weakset/article.md
john = null; // sobrescribe la referencia

*!*
// John se almacena dentro del array, por lo que no será recolectado por el recolector de basura

@cortizgcortizgJun 9, 2020

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

busqueda y reemplazo con editor de texto array por arreglo

Comment thread1-js/05-data-types/weakmap-weakset/article.md
Comment thread1-js/05-data-types/weakmap-weakset/article.md
cortizg
cortizg suggested changes Jun 9, 2020
View reviewed changes

@cortizgcortizg left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

traducciones que pasaron por alto y un typo

Comment thread1-js/05-data-types/weakmap-weakset/01-recipients-read/solution.md Outdated
Comment thread1-js/05-data-types/weakmap-weakset/02-recipients-when-read/task.md Outdated
Comment thread1-js/05-data-types/weakmap-weakset/article.md Outdated
Comment thread1-js/05-data-types/weakmap-weakset/article.md Outdated
@javascript-translate-bot

javascript-translate-bot commented Jun 9, 2020

Copy link
Copy Markdown

Please make the requested changes. After it, add a comment "/done".
Then I'll ask for a new review 👻

vplentinaxand others added 4 commits June 10, 2020 19:28
@vplentinax@cortizg
Update 1-js/05-data-types/weakmap-weakset/article.md
46913d1
Co-authored-by: Carlos Ortiz Gutiérrez <56600925+cortizg@users.noreply.github.com>
@vplentinax@cortizg
Update 1-js/05-data-types/weakmap-weakset/article.md
50372ba
Co-authored-by: Carlos Ortiz Gutiérrez <56600925+cortizg@users.noreply.github.com>
@vplentinax@cortizg
Update 1-js/05-data-types/weakmap-weakset/02-recipients-when-read/tas…
114d816
…k.md
Co-authored-by: Carlos Ortiz Gutiérrez <56600925+cortizg@users.noreply.github.com>
@vplentinax@cortizg
Update 1-js/05-data-types/weakmap-weakset/01-recipients-read/solution.md
1c9082b
Co-authored-by: Carlos Ortiz Gutiérrez <56600925+cortizg@users.noreply.github.com>
joaquinelio
joaquinelio approved these changes Jun 14, 2020
View reviewed changes

@joaquineliojoaquinelio left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Un par de cositas tipo "suggest" nomás.
Abandono la pelea de glosario array. Cambialo o no, then merge sin asco.

Comment thread1-js/05-data-types/weakmap-weakset/01-recipients-read/solution.md Outdated
Comment thread1-js/05-data-types/weakmap-weakset/article.md Outdated
Comment thread1-js/05-data-types/weakmap-weakset/article.md Outdated
Comment thread1-js/05-data-types/weakmap-weakset/article.md Outdated
Comment thread1-js/05-data-types/weakmap-weakset/article.md Outdated
Comment thread1-js/05-data-types/weakmap-weakset/article.md Outdated
Comment thread1-js/05-data-types/weakmap-weakset/article.md Outdated
EzequielCasteand others added 7 commits June 15, 2020 18:24
@EzequielCaste@joaquinelio
Update 1-js/05-data-types/weakmap-weakset/article.md
7ec5e4b
Co-authored-by: joaquinelio <joaquinelio@gmail.com>
@EzequielCaste@joaquinelio
Update 1-js/05-data-types/weakmap-weakset/article.md
e8a6054
Co-authored-by: joaquinelio <joaquinelio@gmail.com>
@EzequielCaste@joaquinelio
Update 1-js/05-data-types/weakmap-weakset/article.md
1fa8c93
Co-authored-by: joaquinelio <joaquinelio@gmail.com>
@EzequielCaste@joaquinelio
Update 1-js/05-data-types/weakmap-weakset/article.md
af3268f
Co-authored-by: joaquinelio <joaquinelio@gmail.com>
@EzequielCaste@joaquinelio
Update 1-js/05-data-types/weakmap-weakset/article.md
826a7ef
Co-authored-by: joaquinelio <joaquinelio@gmail.com>
@EzequielCaste@joaquinelio
Update 1-js/05-data-types/weakmap-weakset/article.md
c66d582
Co-authored-by: joaquinelio <joaquinelio@gmail.com>
@EzequielCaste@joaquinelio
Update 1-js/05-data-types/weakmap-weakset/01-recipients-read/solution.md
6c6d71a
Co-authored-by: joaquinelio <joaquinelio@gmail.com>
@EzequielCaste
EzequielCaste merged commit a4edb73 into javascript-tutorial:masterJun 15, 2020
@javascript-translate-bot

javascript-translate-bot commented Jun 15, 2020

Copy link
Copy Markdown

Thank you 💖 I updated the Progress Issue #17 🎉 🎉 🎉

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@joaquineliojoaquineliojoaquinelio approved these changes
+1 more reviewer
@cortizgcortizgcortizg requested changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

needs +1

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@vplentinax@javascript-translate-bot@joaquinelio@cortizg@EzequielCaste