Skip to content

Property flags and descriptors - #183

Merged
EzequielCaste merged 13 commits into
javascript-tutorial:masterfrom
kenliten:master
Jul 1, 2020
Merged

Property flags and descriptors#183
EzequielCaste merged 13 commits into
javascript-tutorial:masterfrom
kenliten:master

Conversation

@kenliten

@kenlitenkenliten commented May 12, 2020

Copy link
Copy Markdown
Contributor

No description provided.

@javascript-translate-bot
javascript-translate-bot requested a review from a teamMay 12, 2020 03:16
@CLAassistant

CLAassistant commented May 12, 2020•
edited
Loading

Copy link
Copy Markdown

CLA assistant check
All committers have signed the CLA.

@iliakaniliakan mentioned this pull request May 12, 2020
Open
EzequielCaste
EzequielCaste requested changes Jun 24, 2020
View reviewed changes

@EzequielCasteEzequielCaste left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hay problemas con el número de las líneas a partir de línea 127. Verificar con artículo original EN

Alguna sugerencia?

Comment thread1-js/07-object-properties/01-property-descriptors/article.md Outdated
Comment thread1-js/07-object-properties/01-property-descriptors/article.md Outdated
Comment thread1-js/07-object-properties/01-property-descriptors/article.md Outdated
@javascript-translate-bot

javascript-translate-bot commented Jun 24, 2020

Copy link
Copy Markdown

Please make the requested changes. After it, add a comment "/done".
Then I'll ask for a new review 👻

vplentinaxand others added 3 commits June 25, 2020 14:52
@vplentinax@EzequielCaste
Update 1-js/07-object-properties/01-property-descriptors/article.md
eed1c43
Co-authored-by: Ezequiel Castellanos <51804994+ezzep66@users.noreply.github.com>
@vplentinax@EzequielCaste
Update 1-js/07-object-properties/01-property-descriptors/article.md
531b243
Co-authored-by: Ezequiel Castellanos <51804994+ezzep66@users.noreply.github.com>
@vplentinax@EzequielCaste
Update 1-js/07-object-properties/01-property-descriptors/article.md
52788c2
Co-authored-by: Ezequiel Castellanos <51804994+ezzep66@users.noreply.github.com>
@vplentinax

vplentinax commented Jun 25, 2020

Copy link
Copy Markdown
Contributor

/done

vplentinax
vplentinax previously requested changes Jun 25, 2020
View reviewed changes

@vplentinaxvplentinax left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Le faltaron partes por traducir. Las estructuras coinciden EN vs ES

Comment thread1-js/07-object-properties/01-property-descriptors/article.md
Comment thread1-js/07-object-properties/01-property-descriptors/article.md
@javascript-translate-bot

javascript-translate-bot commented Jun 25, 2020

Copy link
Copy Markdown

Please make the requested changes. After it, add a comment "/done".
Then I'll ask for a new review 👻

@vplentinax

vplentinax commented Jun 30, 2020

Copy link
Copy Markdown
Contributor

/done

@vplentinax

vplentinax commented Jun 30, 2020

Copy link
Copy Markdown
Contributor

Volver a revisar

@joaquinelio
Update article.md
840c9ae
añadido triple grave linea 127
@joaquinelio
Update article.md
654c618
Editado smart header y contenido 251 - 254
joaquinelio
joaquinelio approved these changes Jun 30, 2020
View reviewed changes

@joaquineliojoaquinelio left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Edité el archivo directamente, dejo registro:
127 agregado formato gravegravegrave,
no se puede hacer suggest porque el triple tilde lo cierra y borraria la linea
251-254 ??? el smart header es completamente distinto...
dejo en coment el original y también edito directamente por la misma razon del triple tilde.

Comment thread1-js/07-object-properties/01-property-descriptors/article.md Outdated
Notable exception: a value of non-configurable, but writable property can be changed.

The idea of `configurable: false` is to prevent changes to property flags and its deletion, not changes to its value.
```smart header="Los errores aparecen solo en uso estricto"

@joaquineliojoaquinelioJun 30, 2020

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Original 251-252
___smart header="Los errores aparecen solo en uso estricto"
En el modo no estricto, no aparecen errores al escribir en propiedades de solo lectura y semejantes. Pero la operación no será ejecutada. Las acciones viola-identificadores son silenciadas e ignoradas en modo no estricto.

@joaquinelio
Update article.md
b2c4ded
fix a la edición de 254
EzequielCaste
EzequielCaste approved these changes Jul 1, 2020
View reviewed changes

@EzequielCasteEzequielCaste left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

todo bien salvo algunas correcciones

Comment thread1-js/07-object-properties/01-property-descriptors/article.md Outdated
Comment thread1-js/07-object-properties/01-property-descriptors/article.md Outdated
Comment thread1-js/07-object-properties/01-property-descriptors/article.md Outdated
@EzequielCaste
EzequielCaste merged commit 02780d9 into javascript-tutorial:masterJul 1, 2020
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@joaquineliojoaquineliojoaquinelio approved these changes
@EzequielCasteEzequielCasteEzequielCaste approved these changes
@vplentinaxvplentinaxvplentinax left review comments

Assignees

No one assigned

Labels

needs +1

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@kenliten@CLAassistant@javascript-translate-bot@vplentinax@joaquinelio@EzequielCaste