Skip to content

Optional chaining '?.' - #190

Merged
EzequielCaste merged 10 commits into
javascript-tutorial:masterfrom
vplentinax:chaining
Jul 1, 2020
Merged

Optional chaining '?.'#190
EzequielCaste merged 10 commits into
javascript-tutorial:masterfrom
vplentinax:chaining

Conversation

@vplentinax

@vplentinaxvplentinax commented May 14, 2020

Copy link
Copy Markdown
Contributor

No description provided.

@javascript-translate-bot
javascript-translate-bot requested a review from a teamMay 14, 2020 20:45
@vplentinaxvplentinax changed the title Optional chaining '?.' Optional chaining '?.'Jun 16, 2020
@iliakaniliakan mentioned this pull request Jun 16, 2020
Open
@joaquinelio
joaquinelio self-requested a review June 30, 2020 00:05
joaquinelio
joaquinelio requested changes Jun 30, 2020
View reviewed changes

@joaquineliojoaquinelio left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@vplentinax
NO hay errores de concepto,
así que no me esperes, cambialos o no y consideralo approved.

Comment thread1-js/04-object-basics/07-optional-chaining/article.md Outdated
Comment thread1-js/04-object-basics/07-optional-chaining/article.md Outdated
Comment thread1-js/04-object-basics/07-optional-chaining/article.md
Comment thread1-js/04-object-basics/07-optional-chaining/article.md Outdated
Comment thread1-js/04-object-basics/07-optional-chaining/article.md
Comment thread1-js/04-object-basics/07-optional-chaining/article.md Outdated
Comment thread1-js/04-object-basics/07-optional-chaining/article.md Outdated
Comment thread1-js/04-object-basics/07-optional-chaining/article.md Outdated
Comment thread1-js/04-object-basics/07-optional-chaining/article.md
@javascript-translate-bot

javascript-translate-bot commented Jun 30, 2020

Copy link
Copy Markdown

Please make the requested changes. After it, add a comment "/done".
Then I'll ask for a new review 👻

vplentinaxand others added 8 commits June 30, 2020 13:23
@vplentinax@joaquinelio
Update 1-js/04-object-basics/07-optional-chaining/article.md
a72b21b
Co-authored-by: joaquinelio <joaquinelio@gmail.com>
@vplentinax@joaquinelio
Update 1-js/04-object-basics/07-optional-chaining/article.md
7a54930
Co-authored-by: joaquinelio <joaquinelio@gmail.com>
@vplentinax@joaquinelio
Update 1-js/04-object-basics/07-optional-chaining/article.md
348c258
Co-authored-by: joaquinelio <joaquinelio@gmail.com>
@vplentinax@joaquinelio
Update 1-js/04-object-basics/07-optional-chaining/article.md
48f60c2
Co-authored-by: joaquinelio <joaquinelio@gmail.com>
@vplentinax@joaquinelio
Update 1-js/04-object-basics/07-optional-chaining/article.md
76de5bb
Co-authored-by: joaquinelio <joaquinelio@gmail.com>
@vplentinax@joaquinelio
Update 1-js/04-object-basics/07-optional-chaining/article.md
2f1a6e5
Co-authored-by: joaquinelio <joaquinelio@gmail.com>
@vplentinax@joaquinelio
Update 1-js/04-object-basics/07-optional-chaining/article.md
3bf37d3
Co-authored-by: joaquinelio <joaquinelio@gmail.com>
@vplentinax@joaquinelio
Update 1-js/04-object-basics/07-optional-chaining/article.md
f1cb7da
Co-authored-by: joaquinelio <joaquinelio@gmail.com>
@vplentinax

vplentinax commented Jun 30, 2020

Copy link
Copy Markdown
ContributorAuthor

/done

@javascript-translate-bot
javascript-translate-bot requested a review from a teamJune 30, 2020 17:25
@cortizg

cortizg commented Jul 1, 2020

Copy link
Copy Markdown
Contributor

ups!

@EzequielCaste

EzequielCaste commented Jul 1, 2020

Copy link
Copy Markdown
Contributor

ups!

qué significa ups! ??

aprobaste sin revisar?

@cortizg

cortizg commented Jul 1, 2020

Copy link
Copy Markdown
Contributor

ups!

qué significa ups! ??

aprobaste sin revisar?

Aprobé sin estar involucrado... Pensé que no me dejaría...

@EzequielCaste
EzequielCaste merged commit ab53d84 into javascript-tutorial:masterJul 1, 2020
@javascript-translate-bot

javascript-translate-bot commented Jul 1, 2020

Copy link
Copy Markdown

Thank you 💖 I updated the Progress Issue #17 🎉 🎉 🎉

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@joaquineliojoaquineliojoaquinelio approved these changes
+1 more reviewer
@cortizgcortizgcortizg approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

needs +1

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@vplentinax@javascript-translate-bot@cortizg@EzequielCaste@joaquinelio