Skip to content

Methods of primitives - #199

Merged
joaquinelio merged 7 commits into
javascript-tutorial:masterfrom
joaquinelio:primitives-methods
Jun 21, 2020
Merged

Methods of primitives#199
joaquinelio merged 7 commits into
javascript-tutorial:masterfrom
joaquinelio:primitives-methods

Conversation

@joaquinelio

@joaquineliojoaquinelio commented May 21, 2020•
edited
Loading

Copy link
Copy Markdown
Member

EDIT:
Don BOT dio error en el PR: remite al PR #105 previo que cerré,
éste #199 es el bueno, probado con server local y todo.

primitives-methods
basado en /en. más nuevo (3 años) que /es.

  • article.md agrega 7mo tipo bigint,
  • solution.md corrige y simplifica la respuesta,
    esto NO está en el master español

No veo actividad acá en meses pero no queria tirar el laburo.
Pero creo q aprendí git, gracias @11joselu

----EDIT 2--------------
AAGGGHH!!
ESTE branch primitives-methods está LIMPIO pero hoy arruiné mi master

creo que

Debi:
mi master, despues del reset, push
estado -LIMPIO-
clonar MI master en la otra terminal, branch, etc

Hice: creo
reset, no push ERROR
clone desde master tutorial ERROR
branch, upstream, pr ERROR no haber chequeado status de mi origin
master pull... ERROR pero como origin el mio sin actualizar ?? creo
reset 1 ¿ERROR?
volvió 8 meses, no al clone ???

no entiendo el resultado
El branch está bien y limpio... el PR es correcto
aunque el bot sigue viendo el pr cerrado como pendiente

Lección:
Aunque entienda el esquema,
hay que hacer un mapa mental y confirmarlo (log, remote, status,...) antes de ejecutar los comandos.

por que escribo todo esto
porque la cuarentena me está reventando los sesos quiero cruzar a la plaza a comer una pizzaaaaaa
no es aun la hora de llorar de hoy sigamos media hora mas
mmm

@javascript-translate-bot
javascript-translate-bot requested a review from a teamMay 21, 2020 07:17
@javascript-translate-bot

javascript-translate-bot commented May 21, 2020

Copy link
Copy Markdown

Error: the article already has PR number in the Progress Issue #17, it's 105 ⁉️

EzequielCaste
EzequielCaste requested changes Jun 2, 2020
View reviewed changes

@EzequielCasteEzequielCaste left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"wrapper objects" se podría traducir como objeto envolvente

Comment thread1-js/05-data-types/01-primitives-methods/1-string-new-property/solution.md Outdated
Comment thread1-js/05-data-types/01-primitives-methods/1-string-new-property/solution.md Outdated
Comment thread1-js/05-data-types/01-primitives-methods/1-string-new-property/solution.md Outdated
Comment thread1-js/05-data-types/01-primitives-methods/article.md Outdated
Comment thread1-js/05-data-types/01-primitives-methods/article.md Outdated
Comment thread1-js/05-data-types/01-primitives-methods/article.md Outdated
Comment thread1-js/05-data-types/01-primitives-methods/article.md Outdated
Comment thread1-js/05-data-types/01-primitives-methods/article.md Outdated
Comment thread1-js/05-data-types/01-primitives-methods/article.md Outdated
Comment thread1-js/05-data-types/01-primitives-methods/article.md Outdated
@javascript-translate-bot

javascript-translate-bot commented Jun 2, 2020

Copy link
Copy Markdown

Please make the requested changes. After it, add a comment "/done".
Then I'll ask for a new review 👻

joaquinelioand others added 4 commits June 1, 2020 23:33
@joaquinelio@EzequielCaste
Update 1-js/05-data-types/01-primitives-methods/1-string-new-property…
dac5512
…/solution.md
Co-authored-by: Ezequiel Castellanos <51804994+ezzep66@users.noreply.github.com>
@joaquinelio@EzequielCaste
Update 1-js/05-data-types/01-primitives-methods/1-string-new-property…
2541e70
…/solution.md
Co-authored-by: Ezequiel Castellanos <51804994+ezzep66@users.noreply.github.com>
@joaquinelio@EzequielCaste
Update 1-js/05-data-types/01-primitives-methods/article.md
2c0eac1
Co-authored-by: Ezequiel Castellanos <51804994+ezzep66@users.noreply.github.com>
@joaquinelio@EzequielCaste
Apply suggestions from code review
0c0d3d2
maomeno...
Co-authored-by: Ezequiel Castellanos <51804994+ezzep66@users.noreply.github.com>
@joaquinelio

joaquinelio commented Jun 2, 2020

Copy link
Copy Markdown
MemberAuthor

/done

@javascript-translate-bot
javascript-translate-bot requested a review from a teamJune 2, 2020 03:03
@iliakaniliakan mentioned this pull request Jun 3, 2020
Open
@joaquinelio@EzequielCaste
Update 1-js/05-data-types/01-primitives-methods/1-string-new-property…
ee4c625
…/solution.md
Co-authored-by: Ezequiel Castellanos <51804994+ezzep66@users.noreply.github.com>
@joaquinelio

joaquinelio commented Jun 6, 2020

Copy link
Copy Markdown
MemberAuthor

/done

@joaquinelio
joaquinelio merged commit 243f044 into javascript-tutorial:masterJun 21, 2020
@javascript-translate-bot

javascript-translate-bot commented Jun 21, 2020

Copy link
Copy Markdown

Thank you 💖 I updated the Progress Issue #17 🎉 🎉 🎉

@joaquinelio
joaquinelio deleted the primitives-methods branch July 15, 2020 03:17
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@EzequielCasteEzequielCasteEzequielCaste requested changes

Assignees

No one assigned

Labels

review needed

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@joaquinelio@javascript-translate-bot@EzequielCaste