Skip to content

Numbers - #200

Merged
vplentinax merged 4 commits into
javascript-tutorial:masterfrom
joaquinelio:numbers
Jun 6, 2020
Merged

Numbers#200
vplentinax merged 4 commits into
javascript-tutorial:masterfrom
joaquinelio:numbers

Conversation

@joaquinelio

@joaquineliojoaquinelio commented May 22, 2020

Copy link
Copy Markdown
Member

1.5.2 number completito y probado con server local

NOTAS

diff - Me basé en EN.javascript.info
que es más nuevo, tiene algunas correcciones,
e incluye breve descripción de bigInt (hay un link al capítulo bigInt que no existe -easy fix, boss-)

Volé (parte de) un párrafo que tiene sentido en inglés pero no en castellano,
referida a cómo abrevian en palabras los números "somos perezosos", en español no usamos esas abreviaturas y en ESTE particular caso no tiene sentido explicarlas y aclarar que nosotros no lo hacemos.

@javascript-translate-bot
javascript-translate-bot requested a review from a teamMay 22, 2020 20:11
EzequielCaste
EzequielCaste requested changes Jun 1, 2020
View reviewed changes

@EzequielCasteEzequielCaste left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

me pareció bien.
sugerí algunos cambios.
🚀 🍕

Comment thread1-js/05-data-types/02-number/1-sum-interface/solution.md Outdated
Comment thread1-js/05-data-types/02-number/1-sum-interface/task.md Outdated
Comment thread1-js/05-data-types/02-number/1-sum-interface/task.md Outdated
Comment thread1-js/05-data-types/02-number/2-why-rounded-down/solution.md Outdated
Comment thread1-js/05-data-types/02-number/3-repeat-until-number/solution.md Outdated
Comment thread1-js/05-data-types/02-number/article.md Outdated
Comment thread1-js/05-data-types/02-number/article.md Outdated
Comment thread1-js/05-data-types/02-number/article.md Outdated
Comment thread1-js/05-data-types/02-number/article.md
Comment thread1-js/05-data-types/02-number/article.md Outdated
@javascript-translate-bot

javascript-translate-bot commented Jun 1, 2020

Copy link
Copy Markdown

Please make the requested changes. After it, add a comment "/done".
Then I'll ask for a new review 👻

joaquinelioand others added 2 commits June 2, 2020 00:25
@joaquinelio@EzequielCaste
Apply suggestions from code review
c5435e4
/done
Co-authored-by: Ezequiel Castellanos <51804994+ezzep66@users.noreply.github.com>
@joaquinelio@EzequielCaste
Apply suggestions from code review
71e68bc
/done
Co-authored-by: Ezequiel Castellanos <51804994+ezzep66@users.noreply.github.com>
@joaquineliojoaquinelio changed the title numbersNumbersJun 3, 2020
@iliakaniliakan mentioned this pull request Jun 3, 2020
Open
EzequielCaste
EzequielCaste approved these changes Jun 4, 2020
View reviewed changes

@EzequielCasteEzequielCaste left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok

@vplentinax
vplentinax merged commit e94892d into javascript-tutorial:masterJun 6, 2020
@javascript-translate-bot

javascript-translate-bot commented Jun 6, 2020

Copy link
Copy Markdown

Thank you 💖 I updated the Progress Issue #17 🎉 🎉 🎉

@joaquinelio
joaquinelio deleted the numbers branch July 15, 2020 03:18
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@EzequielCasteEzequielCasteEzequielCaste approved these changes

Assignees

No one assigned

Labels

needs +1

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@joaquinelio@javascript-translate-bot@EzequielCaste@vplentinax