Skip to content

Decorators and forwarding, call/apply - #205

Merged
vplentinax merged 11 commits into
javascript-tutorial:masterfrom
vplentinax:decorators
Jul 3, 2020
Merged

Decorators and forwarding, call/apply#205
vplentinax merged 11 commits into
javascript-tutorial:masterfrom
vplentinax:decorators

Conversation

@vplentinax

@vplentinaxvplentinax commented May 24, 2020

Copy link
Copy Markdown
Contributor

No description provided.

@javascript-translate-bot
javascript-translate-bot requested a review from a teamMay 24, 2020 23:18
@iliakaniliakan mentioned this pull request May 24, 2020
Open
@joaquinelio

joaquinelio commented Jun 2, 2020

Copy link
Copy Markdown
Member

3 pending reviewers?
Espero no haberme equivocado con los conflictos se me cruzaban los ojos.

joaquinelio
joaquinelio requested changes Jul 1, 2020
View reviewed changes

@joaquineliojoaquinelio left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

unos pocos cambios,
then
lo doy por bueno

Comment thread1-js/06-advanced-functions/09-call-apply-decorators/02-delay/task.md Outdated
Comment thread1-js/06-advanced-functions/09-call-apply-decorators/01-spy-decorator/task.md
Comment thread1-js/06-advanced-functions/09-call-apply-decorators/04-throttle/solution.md Outdated
Comment thread1-js/06-advanced-functions/09-call-apply-decorators/article.md Outdated
Comment thread1-js/06-advanced-functions/09-call-apply-decorators/article.md Outdated
Comment thread1-js/06-advanced-functions/09-call-apply-decorators/article.md Outdated
Comment thread1-js/06-advanced-functions/09-call-apply-decorators/article.md Outdated
Comment thread1-js/06-advanced-functions/09-call-apply-decorators/article.md Outdated
Comment thread1-js/06-advanced-functions/09-call-apply-decorators/article.md
Comment thread1-js/06-advanced-functions/09-call-apply-decorators/article.md Outdated
@javascript-translate-bot

javascript-translate-bot commented Jul 1, 2020

Copy link
Copy Markdown

Please make the requested changes. After it, add a comment "/done".
Then I'll ask for a new review 👻

vplentinaxand others added 8 commits July 1, 2020 13:53
@vplentinax@joaquinelio
Update 1-js/06-advanced-functions/09-call-apply-decorators/02-delay/t…
2b55933
…ask.md
Co-authored-by: joaquinelio <joaquinelio@gmail.com>
@vplentinax@joaquinelio
Update 1-js/06-advanced-functions/09-call-apply-decorators/04-throttl…
6459ac4
…e/solution.md
Co-authored-by: joaquinelio <joaquinelio@gmail.com>
@vplentinax@joaquinelio
Update 1-js/06-advanced-functions/09-call-apply-decorators/article.md
41121bb
Co-authored-by: joaquinelio <joaquinelio@gmail.com>
@vplentinax@joaquinelio
Update 1-js/06-advanced-functions/09-call-apply-decorators/article.md
4d76e41
Co-authored-by: joaquinelio <joaquinelio@gmail.com>
@vplentinax@joaquinelio
Update 1-js/06-advanced-functions/09-call-apply-decorators/article.md
771a79f
Co-authored-by: joaquinelio <joaquinelio@gmail.com>
@vplentinax@joaquinelio
Update 1-js/06-advanced-functions/09-call-apply-decorators/article.md
fd754f1
Co-authored-by: joaquinelio <joaquinelio@gmail.com>
@vplentinax@joaquinelio
Update 1-js/06-advanced-functions/09-call-apply-decorators/article.md
5de203e
Co-authored-by: joaquinelio <joaquinelio@gmail.com>
@vplentinax@joaquinelio
Update 1-js/06-advanced-functions/09-call-apply-decorators/article.md
266ca70
Co-authored-by: joaquinelio <joaquinelio@gmail.com>
@vplentinax

vplentinax commented Jul 1, 2020

Copy link
Copy Markdown
ContributorAuthor

/done

@javascript-translate-bot
javascript-translate-bot requested a review from a teamJuly 1, 2020 18:05
@vplentinax@joaquinelio
Update 1-js/06-advanced-functions/09-call-apply-decorators/article.md
c0a8b2f
Co-authored-by: joaquinelio <joaquinelio@gmail.com>
joaquinelio
joaquinelio approved these changes Jul 2, 2020
View reviewed changes

@joaquineliojoaquinelio left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"se enseña así"
Se suma propiedad/valor
bueno, hay cosas peores. Cuando nuestros inteligentes militares fueron a Malvinas y llegaron a Goose Green, lo llamaron "ganso verde", no sé si en burla. Y claro todos los noticieros debían decirle así.
Lo importante es que en la cabeza se figure el concepto correcto. Convención.

@vplentinax
vplentinax merged commit 2c0c020 into javascript-tutorial:masterJul 3, 2020
@javascript-translate-bot

javascript-translate-bot commented Jul 3, 2020

Copy link
Copy Markdown

Thank you 💖 I updated the Progress Issue #17 🎉 🎉 🎉

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@joaquineliojoaquineliojoaquinelio approved these changes
@EzequielCasteEzequielCasteAwaiting requested review from EzequielCaste

Assignees

No one assigned

Labels

needs +1

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@vplentinax@joaquinelio@javascript-translate-bot