Skip to content

Conditional operators: if, '?' - #231

Merged
EzequielCaste merged 37 commits into
javascript-tutorial:masterfrom
vplentinax:Giorgiosaud-conditional-if
Jun 20, 2020
Merged

Conditional operators: if, '?' #231
EzequielCaste merged 37 commits into
javascript-tutorial:masterfrom
vplentinax:Giorgiosaud-conditional-if

Conversation

@vplentinax

@vplentinaxvplentinax commented Jun 5, 2020

Copy link
Copy Markdown
Contributor

Este PR es la corrección al articulo traducido por el colaborador Giorgiosaud Conditional if #95 . Dicho PR será cerrado y reenumerado en el Issue 17.

@javascript-translate-bot
javascript-translate-bot requested a review from a teamJune 5, 2020 18:23
@iliakaniliakan mentioned this pull request Jun 5, 2020
Open
@joaquinelio

joaquinelio commented Jun 5, 2020•
edited
Loading

Copy link
Copy Markdown
Member

Les recuerdo, acá el giorgio editó los SVG.
No se editan, hay un procedimiento parametrizado para traducirlos.

joaquinelio
joaquinelio previously requested changes Jun 14, 2020
View reviewed changes

@joaquineliojoaquinelio left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Si corrigen la ortografía que sugerí,
que el segundo reviewer que haga el merge

Comment thread1-js/02-first-steps/10-ifelse/article.md Outdated
Comment thread1-js/02-first-steps/10-ifelse/article.md Outdated
Comment thread1-js/02-first-steps/10-ifelse/article.md Outdated
Comment thread1-js/02-first-steps/10-ifelse/article.md Outdated
Comment thread1-js/02-first-steps/10-ifelse/article.md Outdated
Comment thread1-js/02-first-steps/10-ifelse/article.md Outdated
Comment thread1-js/02-first-steps/10-ifelse/article.md Outdated
Comment thread1-js/02-first-steps/10-ifelse/2-check-standard/task.md Outdated
Comment thread1-js/02-first-steps/10-ifelse/5-rewrite-if-question/task.md Outdated
Comment thread1-js/02-first-steps/10-ifelse/article.md Outdated
@javascript-translate-bot

javascript-translate-bot commented Jun 14, 2020

Copy link
Copy Markdown

Please make the requested changes. After it, add a comment "/done".
Then I'll ask for a new review 👻

vplentinaxand others added 19 commits June 16, 2020 12:11
@vplentinax@joaquinelio
Update 1-js/02-first-steps/10-ifelse/article.md
e9b7747
Co-authored-by: joaquinelio <joaquinelio@gmail.com>
@vplentinax@joaquinelio
Update 1-js/02-first-steps/10-ifelse/article.md
c72776f
Co-authored-by: joaquinelio <joaquinelio@gmail.com>
@vplentinax@joaquinelio
Update 1-js/02-first-steps/10-ifelse/article.md
1c10a2b
Co-authored-by: joaquinelio <joaquinelio@gmail.com>
@vplentinax@joaquinelio
Update 1-js/02-first-steps/10-ifelse/article.md
643b511
Co-authored-by: joaquinelio <joaquinelio@gmail.com>
@vplentinax@joaquinelio
Update 1-js/02-first-steps/10-ifelse/article.md
26f6448
Co-authored-by: joaquinelio <joaquinelio@gmail.com>
@vplentinax@joaquinelio
Update 1-js/02-first-steps/10-ifelse/article.md
dfe7d40
Co-authored-by: joaquinelio <joaquinelio@gmail.com>
@vplentinax@joaquinelio
Update 1-js/02-first-steps/10-ifelse/article.md
7977b4a
Co-authored-by: joaquinelio <joaquinelio@gmail.com>
@vplentinax@joaquinelio
Update 1-js/02-first-steps/10-ifelse/2-check-standard/task.md
e2bb1ec
Co-authored-by: joaquinelio <joaquinelio@gmail.com>
@vplentinax@joaquinelio
Update 1-js/02-first-steps/10-ifelse/5-rewrite-if-question/task.md
0bb1510
Co-authored-by: joaquinelio <joaquinelio@gmail.com>
@vplentinax@joaquinelio
Update 1-js/02-first-steps/10-ifelse/article.md
adefcea
Co-authored-by: joaquinelio <joaquinelio@gmail.com>
@vplentinax@joaquinelio
Update 1-js/02-first-steps/10-ifelse/article.md
10bdedb
Co-authored-by: joaquinelio <joaquinelio@gmail.com>
@vplentinax@joaquinelio
Update 1-js/02-first-steps/10-ifelse/article.md
50ed670
Co-authored-by: joaquinelio <joaquinelio@gmail.com>
@vplentinax@joaquinelio
Update 1-js/02-first-steps/10-ifelse/article.md
fc95df9
Co-authored-by: joaquinelio <joaquinelio@gmail.com>
@vplentinax@joaquinelio
Update 1-js/02-first-steps/10-ifelse/article.md
d6686c0
Co-authored-by: joaquinelio <joaquinelio@gmail.com>
@vplentinax@joaquinelio
Update 1-js/02-first-steps/10-ifelse/article.md
96c3ae7
Co-authored-by: joaquinelio <joaquinelio@gmail.com>
@vplentinax@joaquinelio
Update 1-js/02-first-steps/10-ifelse/article.md
341830f
Co-authored-by: joaquinelio <joaquinelio@gmail.com>
@vplentinax@joaquinelio
Update 1-js/02-first-steps/10-ifelse/article.md
fbbb9c0
Co-authored-by: joaquinelio <joaquinelio@gmail.com>
@vplentinax@joaquinelio
Update 1-js/02-first-steps/10-ifelse/article.md
a29d26e
Co-authored-by: joaquinelio <joaquinelio@gmail.com>
@vplentinax@joaquinelio
Update 1-js/02-first-steps/10-ifelse/article.md
18cac2f
Co-authored-by: joaquinelio <joaquinelio@gmail.com>
vplentinaxand others added 6 commits June 16, 2020 12:18
@vplentinax@joaquinelio
Update 1-js/02-first-steps/10-ifelse/article.md
f3a2697
Co-authored-by: joaquinelio <joaquinelio@gmail.com>
@vplentinax@joaquinelio
Update 1-js/02-first-steps/10-ifelse/article.md
a589360
Co-authored-by: joaquinelio <joaquinelio@gmail.com>
@vplentinax@joaquinelio
Update 1-js/02-first-steps/10-ifelse/article.md
c477d72
Co-authored-by: joaquinelio <joaquinelio@gmail.com>
@vplentinax@joaquinelio
Update 1-js/02-first-steps/10-ifelse/article.md
1848326
Co-authored-by: joaquinelio <joaquinelio@gmail.com>
@vplentinax@joaquinelio
Update 1-js/02-first-steps/10-ifelse/article.md
a76a61c
Co-authored-by: joaquinelio <joaquinelio@gmail.com>
@vplentinax@joaquinelio
Update 1-js/02-first-steps/10-ifelse/article.md
0953da0
Co-authored-by: joaquinelio <joaquinelio@gmail.com>
@vplentinax

vplentinax commented Jun 16, 2020

Copy link
Copy Markdown
ContributorAuthor

/done

@javascript-translate-bot
javascript-translate-bot requested a review from a teamJune 16, 2020 16:30
EzequielCaste
EzequielCaste requested changes Jun 20, 2020
View reviewed changes
Comment thread1-js/02-first-steps/10-ifelse/1-if-zero-string/solution.md Outdated
Comment thread1-js/02-first-steps/10-ifelse/1-if-zero-string/solution.md Outdated
Comment thread1-js/02-first-steps/10-ifelse/1-if-zero-string/task.md Outdated
Comment thread1-js/02-first-steps/10-ifelse/1-if-zero-string/task.md Outdated
Comment thread1-js/02-first-steps/10-ifelse/2-check-standard/ifelse_task2/index.html Outdated
Comment thread1-js/02-first-steps/10-ifelse/article.md Outdated
Comment thread1-js/02-first-steps/10-ifelse/article.md Outdated
Comment thread1-js/02-first-steps/10-ifelse/article.md Outdated
Comment thread1-js/02-first-steps/10-ifelse/article.md Outdated
Comment thread1-js/02-first-steps/10-ifelse/article.md Outdated
@javascript-translate-bot

javascript-translate-bot commented Jun 20, 2020

Copy link
Copy Markdown

Please make the requested changes. After it, add a comment "/done".
Then I'll ask for a new review 👻

@EzequielCaste
EzequielCaste merged commit cb0982e into javascript-tutorial:masterJun 20, 2020
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@EzequielCasteEzequielCasteEzequielCaste approved these changes
@joaquineliojoaquineliojoaquinelio left review comments

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@vplentinax@joaquinelio@javascript-translate-bot@EzequielCaste