Skip to content

Developer console - #255

Merged
vplentinax merged 11 commits into
javascript-tutorial:masterfrom
EzequielCaste:devTools-translation
Jun 30, 2020
Merged

Developer console#255
vplentinax merged 11 commits into
javascript-tutorial:masterfrom
EzequielCaste:devTools-translation

Conversation

@EzequielCaste

@EzequielCasteEzequielCaste commented Jun 15, 2020

Copy link
Copy Markdown
Contributor

No description provided.

@javascript-translate-bot
javascript-translate-bot requested a review from a teamJune 15, 2020 14:59
@iliakaniliakan mentioned this pull request Jun 15, 2020
Open
cortizg
cortizg suggested changes Jun 28, 2020
View reviewed changes

@cortizgcortizg left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Full review, traducciones, typos y comentarios

Comment thread1-js/01-getting-started/4-devtools/article.md Outdated
Comment thread1-js/01-getting-started/4-devtools/article.md Outdated
Comment thread1-js/01-getting-started/4-devtools/article.md Outdated
Comment thread1-js/01-getting-started/4-devtools/article.md Outdated
Comment thread1-js/01-getting-started/4-devtools/article.md Outdated
Comment thread1-js/01-getting-started/4-devtools/article.md Outdated
Comment thread1-js/01-getting-started/4-devtools/article.md Outdated
Comment thread1-js/01-getting-started/4-devtools/article.md Outdated
Comment thread1-js/01-getting-started/4-devtools/article.md Outdated
Comment thread1-js/01-getting-started/4-devtools/article.md Outdated
@javascript-translate-bot

javascript-translate-bot commented Jun 28, 2020

Copy link
Copy Markdown

Please make the requested changes. After it, add a comment "/done".
Then I'll ask for a new review 👻

EzequielCasteand others added 10 commits June 28, 2020 10:12
@EzequielCaste
Update 1-js/01-getting-started/4-devtools/article.md
f0b33ab
@EzequielCaste@cortizg
Update 1-js/01-getting-started/4-devtools/article.md
7f7b046
Co-authored-by: Carlos Ortiz Gutiérrez <56600925+cortizg@users.noreply.github.com>
@EzequielCaste@cortizg
Update 1-js/01-getting-started/4-devtools/article.md
526fc47
Co-authored-by: Carlos Ortiz Gutiérrez <56600925+cortizg@users.noreply.github.com>
@EzequielCaste@cortizg
Update 1-js/01-getting-started/4-devtools/article.md
1a835fc
Co-authored-by: Carlos Ortiz Gutiérrez <56600925+cortizg@users.noreply.github.com>
@EzequielCaste@cortizg
Update 1-js/01-getting-started/4-devtools/article.md
5cbc3a5
Co-authored-by: Carlos Ortiz Gutiérrez <56600925+cortizg@users.noreply.github.com>
@EzequielCaste@cortizg
Update 1-js/01-getting-started/4-devtools/article.md
7bf42b5
Co-authored-by: Carlos Ortiz Gutiérrez <56600925+cortizg@users.noreply.github.com>
@EzequielCaste@cortizg
Update 1-js/01-getting-started/4-devtools/article.md
ba3a255
Co-authored-by: Carlos Ortiz Gutiérrez <56600925+cortizg@users.noreply.github.com>
@EzequielCaste@cortizg
Update 1-js/01-getting-started/4-devtools/article.md
ab1d97c
Co-authored-by: Carlos Ortiz Gutiérrez <56600925+cortizg@users.noreply.github.com>
@EzequielCaste@cortizg
Update 1-js/01-getting-started/4-devtools/article.md
a912056
Co-authored-by: Carlos Ortiz Gutiérrez <56600925+cortizg@users.noreply.github.com>
@EzequielCaste@cortizg
Update 1-js/01-getting-started/4-devtools/article.md
558c24b
Co-authored-by: Carlos Ortiz Gutiérrez <56600925+cortizg@users.noreply.github.com>
@EzequielCaste
EzequielCaste removed the request for review from vplentinaxJune 29, 2020 01:07
@EzequielCaste

EzequielCaste commented Jun 29, 2020

Copy link
Copy Markdown
ContributorAuthor

/done

@cortizg

cortizg commented Jun 29, 2020

Copy link
Copy Markdown
Contributor

/done

@EzequielCaste

EzequielCaste commented Jun 29, 2020

Copy link
Copy Markdown
ContributorAuthor

@cortizg podrías fijarte si tienes la opción de Aprobar ?

@EzequielCaste

EzequielCaste commented Jun 29, 2020

Copy link
Copy Markdown
ContributorAuthor

perfecto!

vplentinax
vplentinax approved these changes Jun 30, 2020
View reviewed changes

@vplentinaxvplentinax left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Merge! :)

@vplentinax

vplentinax commented Jun 30, 2020•
edited
Loading

Copy link
Copy Markdown
Contributor

Sorry, ando probando el tema de aprobar jaja... Pero se puede hacer merge...

@vplentinax
vplentinax merged commit 99fd6ab into javascript-tutorial:masterJun 30, 2020
@javascript-translate-bot

javascript-translate-bot commented Jun 30, 2020

Copy link
Copy Markdown

Thank you 💖 I updated the Progress Issue #17 🎉 🎉 🎉

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@vplentinaxvplentinaxvplentinax approved these changes
+1 more reviewer
@cortizgcortizgcortizg approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

needs +1

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@EzequielCaste@javascript-translate-bot@cortizg@vplentinax