Skip to content

Map and Set - #263

Merged
vplentinax merged 24 commits into
javascript-tutorial:masterfrom
vplentinax:mset
Jul 5, 2020
Merged

Map and Set#263
vplentinax merged 24 commits into
javascript-tutorial:masterfrom
vplentinax:mset

Conversation

@vplentinax

@vplentinaxvplentinax commented Jun 18, 2020

Copy link
Copy Markdown
Contributor

Arreglado los errores de formato.

@javascript-translate-bot
javascript-translate-bot requested a review from a teamJune 18, 2020 21:41
@iliakaniliakan mentioned this pull request Jun 18, 2020
Open
@EzequielCaste
EzequielCaste self-requested a review July 4, 2020 14:03
EzequielCaste
EzequielCaste requested changes Jul 4, 2020
View reviewed changes

@EzequielCasteEzequielCaste left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hay error al comienzo de 1-js/05-data-types/07-map-set/02-filter-anagrams/solution.md
No se ha respetado los números de las líneas. Debe comenzar en línea N° 1 y no en la N°2.

Por favor corregir así puedo seguir con la revisión.

Comment thread1-js/05-data-types/07-map-set/01-array-unique-map/task.md
Comment thread1-js/05-data-types/07-map-set/01-array-unique-map/task.md Outdated
Comment thread1-js/05-data-types/07-map-set/01-array-unique-map/task.md
Comment thread1-js/05-data-types/07-map-set/01-array-unique-map/task.md Outdated
Comment thread1-js/05-data-types/07-map-set/01-array-unique-map/task.md
Comment thread1-js/05-data-types/07-map-set/01-array-unique-map/task.md
Comment thread1-js/05-data-types/07-map-set/01-array-unique-map/task.md
Comment thread1-js/05-data-types/07-map-set/01-array-unique-map/task.md Outdated
@javascript-translate-bot

javascript-translate-bot commented Jul 4, 2020

Copy link
Copy Markdown

Please make the requested changes. After it, add a comment "/done".
Then I'll ask for a new review 👻

@EzequielCaste
update solution
981da7f
arreglé el problema de los espacios.
Por favor tienen que coincidir los números de las líneas con el documento Original.
@EzequielCaste
update task
e4ceae7
problemas con la numeración de líneas
@EzequielCaste
update solution
78e1bfa
número de líneas
@EzequielCaste
corrección de líneas
e61c2a6
respetar el número de línea
@EzequielCaste
corrección número líneas
1c79cbe
@EzequielCaste
fixed line numbers
883cd95
EzequielCaste
EzequielCaste requested changes Jul 4, 2020
View reviewed changes

@EzequielCasteEzequielCaste left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

muchos problemas con espacios donde no deberían estar.
Se debe respetar el número de línea del documento original.

Comment thread1-js/05-data-types/07-map-set/03-iterable-keys/task.md Outdated
Comment thread1-js/05-data-types/07-map-set/article.md Outdated
Comment thread1-js/05-data-types/07-map-set/article.md Outdated
Comment thread1-js/05-data-types/07-map-set/article.md Outdated
Comment thread1-js/05-data-types/07-map-set/article.md Outdated
Comment thread1-js/05-data-types/07-map-set/article.md Outdated
Comment thread1-js/05-data-types/07-map-set/article.md Outdated
Comment thread1-js/05-data-types/07-map-set/article.md Outdated
Comment thread1-js/05-data-types/07-map-set/article.md Outdated
@javascript-translate-bot

javascript-translate-bot commented Jul 4, 2020

Copy link
Copy Markdown

Please make the requested changes. After it, add a comment "/done".
Then I'll ask for a new review 👻

vplentinaxand others added 12 commits July 4, 2020 19:15
@vplentinax@EzequielCaste
Update 1-js/05-data-types/07-map-set/01-array-unique-map/task.md
e6f57ea
Co-authored-by: Ezequiel Castellanos <51804994+ezzep66@users.noreply.github.com>
@vplentinax@EzequielCaste
Update 1-js/05-data-types/07-map-set/01-array-unique-map/task.md
af49a81
Co-authored-by: Ezequiel Castellanos <51804994+ezzep66@users.noreply.github.com>
@vplentinax@EzequielCaste
Update 1-js/05-data-types/07-map-set/01-array-unique-map/task.md
459c874
Co-authored-by: Ezequiel Castellanos <51804994+ezzep66@users.noreply.github.com>
@vplentinax@EzequielCaste
Update 1-js/05-data-types/07-map-set/01-array-unique-map/task.md
f6f6016
Co-authored-by: Ezequiel Castellanos <51804994+ezzep66@users.noreply.github.com>
@vplentinax@EzequielCaste
Update 1-js/05-data-types/07-map-set/01-array-unique-map/task.md
438b4d7
Co-authored-by: Ezequiel Castellanos <51804994+ezzep66@users.noreply.github.com>
@vplentinax@EzequielCaste
Update 1-js/05-data-types/07-map-set/01-array-unique-map/task.md
e101acc
Co-authored-by: Ezequiel Castellanos <51804994+ezzep66@users.noreply.github.com>
@vplentinax@EzequielCaste
Update 1-js/05-data-types/07-map-set/01-array-unique-map/task.md
f754d71
Co-authored-by: Ezequiel Castellanos <51804994+ezzep66@users.noreply.github.com>
@vplentinax@EzequielCaste
Update 1-js/05-data-types/07-map-set/03-iterable-keys/task.md
740687f
Co-authored-by: Ezequiel Castellanos <51804994+ezzep66@users.noreply.github.com>
@vplentinax@EzequielCaste
Update 1-js/05-data-types/07-map-set/article.md
444e0a5
Co-authored-by: Ezequiel Castellanos <51804994+ezzep66@users.noreply.github.com>
@vplentinax@EzequielCaste
Update 1-js/05-data-types/07-map-set/article.md
669b0ff
Co-authored-by: Ezequiel Castellanos <51804994+ezzep66@users.noreply.github.com>
@vplentinax@EzequielCaste
Update 1-js/05-data-types/07-map-set/article.md
c3f6fc4
Co-authored-by: Ezequiel Castellanos <51804994+ezzep66@users.noreply.github.com>
@vplentinax@EzequielCaste
Update 1-js/05-data-types/07-map-set/article.md
b2df4f7
Co-authored-by: Ezequiel Castellanos <51804994+ezzep66@users.noreply.github.com>
vplentinaxand others added 5 commits July 4, 2020 19:18
@vplentinax@EzequielCaste
Update 1-js/05-data-types/07-map-set/article.md
2c56508
Co-authored-by: Ezequiel Castellanos <51804994+ezzep66@users.noreply.github.com>
@vplentinax@EzequielCaste
Update 1-js/05-data-types/07-map-set/article.md
74fee8b
Co-authored-by: Ezequiel Castellanos <51804994+ezzep66@users.noreply.github.com>
@vplentinax@EzequielCaste
Update 1-js/05-data-types/07-map-set/article.md
3178435
Co-authored-by: Ezequiel Castellanos <51804994+ezzep66@users.noreply.github.com>
@vplentinax@EzequielCaste
Update 1-js/05-data-types/07-map-set/article.md
3b5c116
Co-authored-by: Ezequiel Castellanos <51804994+ezzep66@users.noreply.github.com>
@vplentinax
Update task.md
7dcaca0
@vplentinax

vplentinax commented Jul 4, 2020

Copy link
Copy Markdown
ContributorAuthor

/done

@javascript-translate-bot
javascript-translate-bot requested a review from a teamJuly 4, 2020 23:23
@vplentinax
vplentinax merged commit 6249f2a into javascript-tutorial:masterJul 5, 2020
@javascript-translate-bot

javascript-translate-bot commented Jul 5, 2020

Copy link
Copy Markdown

Thank you 💖 I updated the Progress Issue #17 🎉 🎉 🎉

@joaquinelio

joaquinelio commented Jul 5, 2020•
edited
Loading

Copy link
Copy Markdown
Member

@vplentinax@ezzep66
¿Merged? Lo tenía recién en una pestaña para revisión...
Estoy de ACUERDO con los merge aprobados por la trusted people, (después de la carga, revisar el repo entero)
¿pero qué pasó con eso del doble review que pide don Bot?
No me quejo, es saber cuál es el criterio.

@vplentinax

vplentinax commented Jul 5, 2020

Copy link
Copy Markdown
ContributorAuthor

En mis PR el segundo review lo doy yo jejeje.

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@EzequielCasteEzequielCasteEzequielCaste approved these changes

Assignees

No one assigned

Labels

needs +1

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@vplentinax@javascript-translate-bot@joaquinelio@EzequielCaste