Skip to content

Currying - #287

Merged
joaquinelio merged 15 commits into
javascript-tutorial:masterfrom
teocicciari:master
Jul 18, 2020
Merged

Currying#287
joaquinelio merged 15 commits into
javascript-tutorial:masterfrom
teocicciari:master

Conversation

@teocicciari

@teocicciariteocicciari commented Jun 29, 2020

Copy link
Copy Markdown
Contributor

No description provided.

@javascript-translate-bot
javascript-translate-bot requested a review from a teamJune 29, 2020 02:06
@iliakaniliakan mentioned this pull request Jun 29, 2020
Open
@CLAassistant

CLAassistant commented Jun 29, 2020•
edited
Loading

Copy link
Copy Markdown

CLA assistant check
All committers have signed the CLA.

joaquinelio
joaquinelio requested changes Jul 5, 2020
View reviewed changes

@joaquineliojoaquinelio left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Muy clara,
cambios menores.
Por favor, pedimos respetar la numeración de líneas original,
pues facilita tanto la revisión como la actualización con el repo inglés.
Creo que los suggest arreglan la numeración pero por favor probalo, puedo equivocarme.

Comment thread1-js/99-js-misc/03-currying-partials/article.md Outdated
Comment thread1-js/99-js-misc/03-currying-partials/article.md Outdated
Comment thread1-js/99-js-misc/03-currying-partials/article.md Outdated
Comment thread1-js/99-js-misc/03-currying-partials/article.md Outdated
Comment thread1-js/99-js-misc/03-currying-partials/article.md Outdated
Comment thread1-js/99-js-misc/03-currying-partials/article.md Outdated
Comment thread1-js/99-js-misc/03-currying-partials/article.md Outdated
Comment thread1-js/99-js-misc/03-currying-partials/article.md Outdated
Comment thread1-js/99-js-misc/03-currying-partials/article.md Outdated
Comment thread1-js/99-js-misc/03-currying-partials/article.md Outdated
@javascript-translate-bot

javascript-translate-bot commented Jul 5, 2020

Copy link
Copy Markdown

Please make the requested changes. After it, add a comment "/done".
Then I'll ask for a new review 👻

@joaquinelio

joaquinelio commented Jul 17, 2020

Copy link
Copy Markdown
Member

@vplentinax
este es simple, pero requiere maintainer SALVO que estés con algo gordo (como sueles).

No respondio en 2 semanas, pero no vi mal el articulo.
Podrias darle una leida, hacerle mis commit si estas dw acuerdo o los reviso si no,
y asi cerramos el circulo

vplentinaxand others added 13 commits July 17, 2020 20:29
@vplentinax@joaquinelio
Update 1-js/99-js-misc/03-currying-partials/article.md
b310c66
Co-authored-by: joaquinelio <joaquinelio@gmail.com>
@vplentinax@joaquinelio
Update 1-js/99-js-misc/03-currying-partials/article.md
e6434b3
Co-authored-by: joaquinelio <joaquinelio@gmail.com>
@vplentinax@joaquinelio
Update 1-js/99-js-misc/03-currying-partials/article.md
319bd2b
Co-authored-by: joaquinelio <joaquinelio@gmail.com>
@vplentinax@joaquinelio
Update 1-js/99-js-misc/03-currying-partials/article.md
c8dceaa
Co-authored-by: joaquinelio <joaquinelio@gmail.com>
@vplentinax@joaquinelio
Update 1-js/99-js-misc/03-currying-partials/article.md
b0bd653
Co-authored-by: joaquinelio <joaquinelio@gmail.com>
@vplentinax@joaquinelio
Update 1-js/99-js-misc/03-currying-partials/article.md
f7ab311
Co-authored-by: joaquinelio <joaquinelio@gmail.com>
@vplentinax@joaquinelio
Update 1-js/99-js-misc/03-currying-partials/article.md
90a0498
Co-authored-by: joaquinelio <joaquinelio@gmail.com>
@vplentinax@joaquinelio
Update 1-js/99-js-misc/03-currying-partials/article.md
a923c95
Co-authored-by: joaquinelio <joaquinelio@gmail.com>
@vplentinax@joaquinelio
Update 1-js/99-js-misc/03-currying-partials/article.md
428b5ec
Co-authored-by: joaquinelio <joaquinelio@gmail.com>
@vplentinax@joaquinelio
Update 1-js/99-js-misc/03-currying-partials/article.md
8404826
Co-authored-by: joaquinelio <joaquinelio@gmail.com>
@vplentinax@joaquinelio
Update 1-js/99-js-misc/03-currying-partials/article.md
3915bd2
Co-authored-by: joaquinelio <joaquinelio@gmail.com>
@vplentinax@joaquinelio
Update 1-js/99-js-misc/03-currying-partials/article.md
38fe5e8
Co-authored-by: joaquinelio <joaquinelio@gmail.com>
@vplentinax@joaquinelio
Update 1-js/99-js-misc/03-currying-partials/article.md
f49de17
Co-authored-by: joaquinelio <joaquinelio@gmail.com>
@vplentinax

vplentinax commented Jul 18, 2020

Copy link
Copy Markdown
Contributor

/done

@vplentinax@joaquinelio
Update 1-js/99-js-misc/03-currying-partials/article.md
b8f7f2f
Co-authored-by: joaquinelio <joaquinelio@gmail.com>
@vplentinax

vplentinax commented Jul 18, 2020

Copy link
Copy Markdown
Contributor

/done

@vplentinax

vplentinax commented Jul 18, 2020

Copy link
Copy Markdown
Contributor

Se arregló el problema de las líneas! @joaquinelio

maksumi
maksumi approved these changes Jul 18, 2020
View reviewed changes

@maksumimaksumi left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Its ok!!!

vplentinax
vplentinax approved these changes Jul 18, 2020
View reviewed changes

@vplentinaxvplentinax left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nos fuimos!

@joaquinelio
joaquinelio merged commit 6c54880 into javascript-tutorial:masterJul 18, 2020
@javascript-translate-bot

javascript-translate-bot commented Jul 18, 2020

Copy link
Copy Markdown

Thank you 💖 I updated the Progress Issue #17 🎉 🎉 🎉

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@joaquineliojoaquineliojoaquinelio approved these changes
@maksumimaksumimaksumi approved these changes
@vplentinaxvplentinaxvplentinax approved these changes

Assignees

No one assigned

Labels

ready to merge

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@teocicciari@CLAassistant@javascript-translate-bot@joaquinelio@vplentinax@maksumi