Skip to content

Sets and ranges [...] - #296

Merged
joaquinelio merged 8 commits into
javascript-tutorial:masterfrom
cortizg:es.javascript.info.9-08-sr
Jul 13, 2020
Merged

Sets and ranges [...]#296
joaquinelio merged 8 commits into
javascript-tutorial:masterfrom
cortizg:es.javascript.info.9-08-sr

Conversation

@cortizg

@cortizgcortizg commented Jul 11, 2020•
edited
Loading

Copy link
Copy Markdown
Contributor

No description provided.

@cortizg
traduccion 9-08-sr
9ef788e
typos
typo2
typo en código de ejemplo
typo3
@javascript-translate-bot
javascript-translate-bot requested a review from a teamJuly 11, 2020 04:38
@iliakaniliakan mentioned this pull request Jul 11, 2020
Open
cortizg
cortizg commented Jul 11, 2020
View reviewed changes

@cortizgcortizg left a comment

Copy link
Copy Markdown
ContributorAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

typos

Comment thread9-regular-expressions/08-regexp-character-sets-and-ranges/1-find-range-1/solution.md Outdated
Comment thread9-regular-expressions/08-regexp-character-sets-and-ranges/article.md Outdated
Comment thread9-regular-expressions/08-regexp-character-sets-and-ranges/article.md Outdated
Comment thread9-regular-expressions/08-regexp-character-sets-and-ranges/article.md

```js run
for(let i=0; i<'𝒳𝒴'.length; i++) {
for(let i = 0; i < '𝒳𝒴'.length; i++) {

@cortizgcortizgJul 11, 2020

Copy link
Copy Markdown
ContributorAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

en las buenas prácticas los operadores deben de estar separados por un espacio, y linter tambièn lo recuerda.

@vplentinaxvplentinaxJul 13, 2020

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Y aquí?

@cortizgcortizgJul 13, 2020

Copy link
Copy Markdown
ContributorAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ya está listo

joaquinelio
joaquinelio requested changes Jul 11, 2020
View reviewed changes

@joaquineliojoaquinelio left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

2 pequeños...

Comment thread9-regular-expressions/08-regexp-character-sets-and-ranges/article.md Outdated
Comment thread9-regular-expressions/08-regexp-character-sets-and-ranges/article.md Outdated
@javascript-translate-bot

javascript-translate-bot commented Jul 11, 2020

Copy link
Copy Markdown

Please make the requested changes. After it, add a comment "/done".
Then I'll ask for a new review 👻

@cortizg

cortizg commented Jul 11, 2020

Copy link
Copy Markdown
ContributorAuthor

/done

@javascript-translate-bot
javascript-translate-bot requested a review from a teamJuly 11, 2020 14:28
joaquinelio
joaquinelio reviewed Jul 12, 2020
View reviewed changes
Comment thread9-regular-expressions/08-regexp-character-sets-and-ranges/article.md Outdated
@joaquinelio
Update 9-regular-expressions/08-regexp-character-sets-and-ranges/arti…
1f62050
…cle.md
esquiusmi...
aceptaste una bandera, pongo la otra
a desgano, pero para concordar.
joaquinelio
joaquinelio approved these changes Jul 12, 2020
View reviewed changes

@joaquineliojoaquinelio left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@cortizg

cortizg commented Jul 13, 2020

Copy link
Copy Markdown
ContributorAuthor

/done

@javascript-translate-bot
javascript-translate-bot requested a review from a teamJuly 13, 2020 00:43
@cortizg
cortizg requested review from vplentinax and removed request for a teamJuly 13, 2020 00:43
vplentinax
vplentinax approved these changes Jul 13, 2020
View reviewed changes

@vplentinaxvplentinax left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok..!

@joaquinelio
joaquinelio merged commit e192dda into javascript-tutorial:masterJul 13, 2020
@javascript-translate-bot

javascript-translate-bot commented Jul 13, 2020

Copy link
Copy Markdown

Thank you 💖 I updated the Progress Issue #17 🎉 🎉 🎉

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@joaquineliojoaquineliojoaquinelio approved these changes
@vplentinaxvplentinaxvplentinax approved these changes

Assignees

No one assigned

Labels

ready to merge

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@cortizg@javascript-translate-bot@joaquinelio@vplentinax