Skip to content

Reference Type - #304

Merged
joaquinelio merged 20 commits into
javascript-tutorial:masterfrom
maksumi:referenceType
Jul 21, 2020
Merged

Reference Type#304
joaquinelio merged 20 commits into
javascript-tutorial:masterfrom
maksumi:referenceType

Conversation

@maksumi

Copy link
Copy Markdown
Collaborator

No description provided.

@joaquineliojoaquinelio left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nada que decir, si no lo entendí.

Corregi los typos al menos.

Andamos escasos de reviewers qye sepan js en profundidad como esto.
Iguual Creo que el capitulo no esta muy deporado en el original...

Comment thread1-js/99-js-misc/04-reference-type/2-check-syntax/solution.md Outdated
Comment thread1-js/99-js-misc/04-reference-type/2-check-syntax/solution.md Outdated
Comment thread1-js/99-js-misc/04-reference-type/2-check-syntax/solution.md Outdated
Comment thread1-js/99-js-misc/04-reference-type/3-why-this/solution.md Outdated
Comment thread1-js/99-js-misc/04-reference-type/3-why-this/solution.md Outdated
Comment thread1-js/99-js-misc/04-reference-type/article.md Outdated
Comment thread1-js/99-js-misc/04-reference-type/article.md Outdated
Comment thread1-js/99-js-misc/04-reference-type/article.md Outdated
Comment thread1-js/99-js-misc/04-reference-type/article.md Outdated
Comment thread1-js/99-js-misc/04-reference-type/article.md Outdated
@javascript-translate-bot

Copy link
Copy Markdown

Please make the requested changes. After it, add a comment "/done".
Then I'll ask for a new review 👻

Maksumi Murakamiand others added 12 commits July 15, 2020 21:52
Co-authored-by: joaquinelio <joaquinelio@gmail.com>
Co-authored-by: joaquinelio <joaquinelio@gmail.com>
Co-authored-by: joaquinelio <joaquinelio@gmail.com>
Co-authored-by: joaquinelio <joaquinelio@gmail.com>
Co-authored-by: joaquinelio <joaquinelio@gmail.com>
Co-authored-by: joaquinelio <joaquinelio@gmail.com>
Co-authored-by: joaquinelio <joaquinelio@gmail.com>
Co-authored-by: joaquinelio <joaquinelio@gmail.com>
Co-authored-by: joaquinelio <joaquinelio@gmail.com>
Co-authored-by: joaquinelio <joaquinelio@gmail.com>
@maksumi

Copy link
Copy Markdown
CollaboratorAuthor

/done

Co-authored-by: joaquinelio <joaquinelio@gmail.com>
@maksumi

Copy link
Copy Markdown
CollaboratorAuthor

/done

@maksumi
maksumi requested review from joaquinelio and removed request for a teamJuly 17, 2020 07:02
Maksumi Murakamiand others added 2 commits July 18, 2020 11:42
Co-authored-by: joaquinelio <joaquinelio@gmail.com>
@maksumi

Copy link
Copy Markdown
CollaboratorAuthor

/done

@javascript-translate-bot
javascript-translate-bot requested a review from a teamJuly 18, 2020 16:43

@joaquineliojoaquinelio left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Creo que está perfecto en concepto.

typos.

Comment thread1-js/99-js-misc/04-reference-type/2-check-syntax/solution.md Outdated
Comment thread1-js/99-js-misc/04-reference-type/2-check-syntax/solution.md Outdated
Comment thread1-js/99-js-misc/04-reference-type/article.md Outdated
@vplentinax

Copy link
Copy Markdown
Contributor

Corregir typos y aceptamos!

Maksumi Murakamiand others added 3 commits July 20, 2020 16:20
Co-authored-by: joaquinelio <joaquinelio@gmail.com>
Co-authored-by: joaquinelio <joaquinelio@gmail.com>
Co-authored-by: joaquinelio <joaquinelio@gmail.com>
@maksumi

Copy link
Copy Markdown
CollaboratorAuthor

/done

@vplentinaxvplentinax left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nos fuimos!

@joaquinelio
joaquinelio merged commit 17864bb into javascript-tutorial:masterJul 21, 2020
@javascript-translate-bot

Copy link
Copy Markdown

Thank you 💖 I updated the Progress Issue #17 🎉 🎉 🎉

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants

@maksumi@javascript-translate-bot@vplentinax@joaquinelio