Scripts: async, defer by dbritto-dev · Pull Request #324 · javascript-tutorial/es.javascript.info

dbritto-dev · 2020-07-26T04:03:23Z

No description provided.

CLAassistant · 2020-07-26T04:03:33Z

All committers have signed the CLA.

joaquinelio

Está bien, typos y tildes

podes aceptar, pelearme o ignorarme...
pero...
Creo que te ofreciste para review?
de los PR, con etiquetas "review needed", son los que no tuvieron revisión
o la tuvieron y el autor hizo/rechazó los cambios
Si está esperando "change req" no creo que valga la pena revisar, que el autor revise primero

javascript-translate-bot · 2020-07-27T04:45:10Z

Please make the requested changes. After it, add a comment "/done".
Then I'll ask for a new review 👻

Co-authored-by: joaquinelio <joaquinelio@gmail.com>

dbritto-dev · 2020-07-27T06:00:31Z

/done

joaquinelio

Ok.
autor y/o 2do reviewer,
*clic para arreglar nro linea, algo menor
*No estoy convencido de la tabla en 185 (de origen), pero el evento y la relacion con los scripts se explican bien en el art.
Más que ok.

Co-authored-by: joaquinelio <joaquinelio@gmail.com>

dbritto-dev · 2020-07-27T23:34:41Z

/done

vplentinax

Ok!

javascript-translate-bot · 2020-07-29T02:19:01Z

Thank you 💖 I updated the Progress Issue #17 🎉 🎉 🎉

dbritto-dev added 3 commits July 25, 2020 22:55

Translate - Scripts: async, defer
110c128

Update article.md
387d40f

Update article.md
3392801

javascript-translate-bot added the review needed label Jul 26, 2020

iliakan mentioned this pull request Jul 26, 2020
Spanish Translation Progress #17
Open

joaquinelio self-requested a review July 27, 2020 03:47

joaquinelio requested changes Jul 27, 2020
View reviewed changes

javascript-translate-bot removed the review needed label Jul 27, 2020

javascript-translate-bot added the changes requested label Jul 27, 2020

dbritto-devand others added 19 commits July 27, 2020 00:02

Update 2-ui/5-loading/02-script-async-defer/article.md
04fe54f
Co-authored-by: joaquinelio <joaquinelio@gmail.com>

Update 2-ui/5-loading/02-script-async-defer/article.md
f13cceb
Co-authored-by: joaquinelio <joaquinelio@gmail.com>

Update 2-ui/5-loading/02-script-async-defer/article.md
344e441
Co-authored-by: joaquinelio <joaquinelio@gmail.com>

Update 2-ui/5-loading/02-script-async-defer/article.md
bb5d273
Co-authored-by: joaquinelio <joaquinelio@gmail.com>

Update article.md
5c441b2

Update 2-ui/5-loading/02-script-async-defer/article.md
ad6a1fd
Co-authored-by: joaquinelio <joaquinelio@gmail.com>

Update 2-ui/5-loading/02-script-async-defer/article.md
89185ba
Co-authored-by: joaquinelio <joaquinelio@gmail.com>

Update 2-ui/5-loading/02-script-async-defer/article.md
6475b1c
Co-authored-by: joaquinelio <joaquinelio@gmail.com>

Update 2-ui/5-loading/02-script-async-defer/article.md
f576eb0
Co-authored-by: joaquinelio <joaquinelio@gmail.com>

Update 2-ui/5-loading/02-script-async-defer/article.md
656d411
Co-authored-by: joaquinelio <joaquinelio@gmail.com>

Update 2-ui/5-loading/02-script-async-defer/article.md
91d7706
Co-authored-by: joaquinelio <joaquinelio@gmail.com>

Update 2-ui/5-loading/02-script-async-defer/article.md
83e8176
Co-authored-by: joaquinelio <joaquinelio@gmail.com>

Update 2-ui/5-loading/02-script-async-defer/article.md
844042d
Co-authored-by: joaquinelio <joaquinelio@gmail.com>

Update 2-ui/5-loading/02-script-async-defer/article.md
e4aecf7
Co-authored-by: joaquinelio <joaquinelio@gmail.com>

Update 2-ui/5-loading/02-script-async-defer/article.md
91b3af0
Co-authored-by: joaquinelio <joaquinelio@gmail.com>

Update 2-ui/5-loading/02-script-async-defer/article.md
fe973fc
Co-authored-by: joaquinelio <joaquinelio@gmail.com>

Update 2-ui/5-loading/02-script-async-defer/article.md
e925239
Co-authored-by: joaquinelio <joaquinelio@gmail.com>

Update 2-ui/5-loading/02-script-async-defer/article.md
a0b8670
Co-authored-by: joaquinelio <joaquinelio@gmail.com>

Update 2-ui/5-loading/02-script-async-defer/article.md
a2449ac
Co-authored-by: joaquinelio <joaquinelio@gmail.com>

dbritto-devand others added 3 commits July 27, 2020 00:48

Update 2-ui/5-loading/02-script-async-defer/article.md
212eb55
Co-authored-by: joaquinelio <joaquinelio@gmail.com>

Update 2-ui/5-loading/02-script-async-defer/article.md
60d5e05
Co-authored-by: joaquinelio <joaquinelio@gmail.com>

Update article.md
dea6a11

javascript-translate-bot added review needed and removed changes requested labels Jul 27, 2020

dbritto-dev requested a review from joaquinelio July 27, 2020 18:34

joaquinelio approved these changes Jul 27, 2020
View reviewed changes

Comment thread2-ui/5-loading/02-script-async-defer/article.md

javascript-translate-bot added needs +1 and removed review needed labels Jul 27, 2020

Update 2-ui/5-loading/02-script-async-defer/article.md
b326102
Co-authored-by: joaquinelio <joaquinelio@gmail.com>

javascript-translate-bot added the review needed label Jul 27, 2020

dbritto-dev requested a review from joaquinelio July 27, 2020 23:35

vplentinax approved these changes Jul 29, 2020
View reviewed changes

vplentinax added ready to merge needs +1 and removed needs +1 review needed ready to merge labels Jul 29, 2020

joaquinelio merged commit b565bbb into javascript-tutorial:masterJul 29, 2020

Uh oh!

Conversation

dbritto-dev commented Jul 26, 2020

Uh oh!

CLAassistant commented Jul 26, 2020• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

joaquinelio left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

javascript-translate-bot commented Jul 27, 2020

Uh oh!

dbritto-dev commented Jul 27, 2020

Uh oh!

joaquinelio left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

dbritto-dev commented Jul 27, 2020

Uh oh!

vplentinax left a comment

Choose a reason for hiding this comment

Uh oh!

javascript-translate-bot commented Jul 29, 2020

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

CLAassistant commented Jul 26, 2020•
edited
Loading