Skip to content

Error handling with promises - #329

Merged
vplentinax merged 7 commits into
javascript-tutorial:masterfrom
george28cs:promises-error-handling
Jul 31, 2020
Merged

Error handling with promises#329
vplentinax merged 7 commits into
javascript-tutorial:masterfrom
george28cs:promises-error-handling

Conversation

@george28cs

@george28csgeorge28cs commented Jul 29, 2020

Copy link
Copy Markdown
Contributor

Hola, envío el PR correspondiente a la traducción de "Manejo de errores con promesas".

@CLAassistant

CLAassistant commented Jul 29, 2020•
edited
Loading

Copy link
Copy Markdown

CLA assistant check
All committers have signed the CLA.

@george28csgeorge28cs changed the title promises error handling v0promises error handlingJul 29, 2020
@joaquineliojoaquinelio changed the title promises error handlingError handling with promisesJul 29, 2020
@iliakaniliakan mentioned this pull request Jul 29, 2020
Open
@joaquinelio
joaquinelio self-requested a review July 29, 2020 15:50
joaquinelio
joaquinelio requested changes Jul 29, 2020
View reviewed changes

@joaquineliojoaquinelio left a comment •
edited
Loading

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@george28cs y reviewers
*Poco para corregir, no vi err de concepto,
ojalá un reviewer con más espalda JS que la mia lo mire...

*Tu PR está OK, Los archivos son los correctos y se ve muy bien.
*El nombre del PR debe ser exactamente (mayusc incluida) para que bot lo registre, nada grave, casi siempre lo modificamos a mano (cambié el nombre y actualicé el issue17).

NOTA: *Los arch originales inglés fueron modificados ayer y se generaron 2 conflictos:
Uno lo arreglé directamente en el traducido (el otro era gramatica inglés, no nos afecta)

Comment thread1-js/11-async/04-promise-error-handling/article.md Outdated
Comment thread1-js/11-async/04-promise-error-handling/article.md Outdated
Comment thread1-js/11-async/04-promise-error-handling/article.md Outdated
Comment thread1-js/11-async/04-promise-error-handling/article.md Outdated
Comment thread1-js/11-async/04-promise-error-handling/article.md Outdated
@javascript-translate-bot

javascript-translate-bot commented Jul 29, 2020

Copy link
Copy Markdown

Please make the requested changes. After it, add a comment "/done".
Then I'll ask for a new review 👻

george28csand others added 5 commits July 29, 2020 18:07
@george28cs@joaquinelio
Update 1-js/11-async/04-promise-error-handling/article.md
016922b
Co-authored-by: joaquinelio <joaquinelio@gmail.com>
@george28cs@joaquinelio
Update 1-js/11-async/04-promise-error-handling/article.md
2119ff6
Co-authored-by: joaquinelio <joaquinelio@gmail.com>
@george28cs@joaquinelio
Update 1-js/11-async/04-promise-error-handling/article.md
26000d8
Co-authored-by: joaquinelio <joaquinelio@gmail.com>
@george28cs@joaquinelio
Update 1-js/11-async/04-promise-error-handling/article.md
bd63d4d
Co-authored-by: joaquinelio <joaquinelio@gmail.com>
@george28cs@joaquinelio
Update 1-js/11-async/04-promise-error-handling/article.md
e51ca46
Co-authored-by: joaquinelio <joaquinelio@gmail.com>
@george28cs

george28cs commented Jul 29, 2020

Copy link
Copy Markdown
ContributorAuthor

/done

joaquinelio
joaquinelio approved these changes Jul 30, 2020
View reviewed changes

@joaquineliojoaquinelio left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lo veo bien...
a 2do reviewer, ¿es suficientemente clara la explicacion? promise, then, try, catch, y anidados...

vplentinax
vplentinax approved these changes Jul 31, 2020
View reviewed changes

@vplentinaxvplentinax left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Correcto, fluido. @joaquinelio , todos los conceptos se entienden bien.

@vplentinax
vplentinax merged commit 2dfdbb3 into javascript-tutorial:masterJul 31, 2020
@javascript-translate-bot

javascript-translate-bot commented Jul 31, 2020

Copy link
Copy Markdown

Thank you 💖 I updated the Progress Issue #17 🎉 🎉 🎉

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@joaquineliojoaquineliojoaquinelio approved these changes
@vplentinaxvplentinaxvplentinax approved these changes

Assignees

No one assigned

Labels

ready to merge

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@george28cs@CLAassistant@javascript-translate-bot@joaquinelio@vplentinax