Skip to content

Events: change, input, cut, copy, paste - #333

Merged
EzequielCaste merged 20 commits into
javascript-tutorial:masterfrom
nahuelcoder:nahuelcoder-form-events
Aug 5, 2020
Merged

Events: change, input, cut, copy, paste#333
EzequielCaste merged 20 commits into
javascript-tutorial:masterfrom
nahuelcoder:nahuelcoder-form-events

Conversation

@nahuelcoder

@nahuelcodernahuelcoder commented Aug 4, 2020

Copy link
Copy Markdown
Contributor

No description provided.

@iliakaniliakan mentioned this pull request Aug 4, 2020
Open
@joaquinelio
joaquinelio self-requested a review August 4, 2020 15:10
joaquinelio
joaquinelio requested changes Aug 4, 2020
View reviewed changes

@joaquineliojoaquinelio left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Trata de que los nros de linea coincidan, facilita la review y la actualización desde el ingles.
Ok, pero sugiero pequeños cambios. Y algun acento.
Tomá mate. 🧉

reviewer
*Don Bot está medio perezoso, el nombre está ok pero hubo que agregar 333 al issue a mano, ojo al merge.
*4 arch traducidos, cant y versión archivos ok, NO probé task con los 2 htm traducidos,
pero parece ok.

Comment thread2-ui/4-forms-controls/3-events-change-input/1-deposit-calculator/solution.view/index.html Outdated
Comment thread2-ui/4-forms-controls/3-events-change-input/1-deposit-calculator/source.view/index.html Outdated
Comment thread2-ui/4-forms-controls/3-events-change-input/1-deposit-calculator/task.md Outdated
Comment thread2-ui/4-forms-controls/3-events-change-input/1-deposit-calculator/task.md Outdated
Comment thread2-ui/4-forms-controls/3-events-change-input/article.md Outdated
Comment thread2-ui/4-forms-controls/3-events-change-input/article.md Outdated
Comment thread2-ui/4-forms-controls/3-events-change-input/article.md Outdated
Comment thread2-ui/4-forms-controls/3-events-change-input/article.md Outdated
Comment thread2-ui/4-forms-controls/3-events-change-input/article.md Outdated
Comment thread2-ui/4-forms-controls/3-events-change-input/article.md Outdated
@javascript-translate-bot

javascript-translate-bot commented Aug 4, 2020

Copy link
Copy Markdown

Please make the requested changes. After it, add a comment "/done".
Then I'll ask for a new review 👻

nahuelcoderand others added 10 commits August 4, 2020 13:40
@nahuelcoder@joaquinelio
Update 2-ui/4-forms-controls/3-events-change-input/1-deposit-calculat…
d369922
…or/solution.view/index.html
Co-authored-by: joaquinelio <joaquinelio@gmail.com>
@nahuelcoder@joaquinelio
Update 2-ui/4-forms-controls/3-events-change-input/1-deposit-calculat…
9bbbc84
…or/source.view/index.html
Co-authored-by: joaquinelio <joaquinelio@gmail.com>
@nahuelcoder@joaquinelio
Update 2-ui/4-forms-controls/3-events-change-input/1-deposit-calculat…
8831b79
…or/task.md
Co-authored-by: joaquinelio <joaquinelio@gmail.com>
@nahuelcoder@joaquinelio
Update 2-ui/4-forms-controls/3-events-change-input/1-deposit-calculat…
8a2add4
…or/task.md
Co-authored-by: joaquinelio <joaquinelio@gmail.com>
@nahuelcoder
Update article.md
bef1f0b
@nahuelcoder@joaquinelio
Update 2-ui/4-forms-controls/3-events-change-input/article.md
b468075
Co-authored-by: joaquinelio <joaquinelio@gmail.com>
@nahuelcoder@joaquinelio
Update 2-ui/4-forms-controls/3-events-change-input/article.md
9cb4d94
Co-authored-by: joaquinelio <joaquinelio@gmail.com>
@nahuelcoder@joaquinelio
Update 2-ui/4-forms-controls/3-events-change-input/article.md
67a6dec
Co-authored-by: joaquinelio <joaquinelio@gmail.com>
@nahuelcoder@joaquinelio
Update 2-ui/4-forms-controls/3-events-change-input/article.md
a7167a3
Co-authored-by: joaquinelio <joaquinelio@gmail.com>
@nahuelcoder@joaquinelio
Update 2-ui/4-forms-controls/3-events-change-input/article.md
91ecc00
Co-authored-by: joaquinelio <joaquinelio@gmail.com>
@nahuelcoder

nahuelcoder commented Aug 4, 2020

Copy link
Copy Markdown
ContributorAuthor

/done

joaquinelio
joaquinelio approved these changes Aug 4, 2020
View reviewed changes

@joaquineliojoaquinelio left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Uh- acabo de aprender el significado de -- en ingles (hay un par acá)
y cómo deberíamos traducirlo.

Apruebo, pero podrías
modificarlo –si queres– (igual me entero): si lo creyeras importante.

Probando gramatica jeje

EzequielCaste
EzequielCaste requested changes Aug 4, 2020
View reviewed changes

@EzequielCasteEzequielCaste left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Bien traducido.
Hice algunos pequeños cambios.

Comment thread2-ui/4-forms-controls/3-events-change-input/article.md Outdated
Comment thread2-ui/4-forms-controls/3-events-change-input/article.md Outdated
Comment thread2-ui/4-forms-controls/3-events-change-input/article.md Outdated
Comment thread2-ui/4-forms-controls/3-events-change-input/article.md Outdated
Comment thread2-ui/4-forms-controls/3-events-change-input/article.md Outdated
Comment thread2-ui/4-forms-controls/3-events-change-input/article.md Outdated
Comment thread2-ui/4-forms-controls/3-events-change-input/article.md Outdated
Comment thread2-ui/4-forms-controls/3-events-change-input/article.md Outdated
Comment thread2-ui/4-forms-controls/3-events-change-input/article.md Outdated
@javascript-translate-bot

javascript-translate-bot commented Aug 4, 2020

Copy link
Copy Markdown

Please make the requested changes. After it, add a comment "/done".
Then I'll ask for a new review 👻

nahuelcoderand others added 3 commits August 5, 2020 10:24
@nahuelcoder@EzequielCaste
Update 2-ui/4-forms-controls/3-events-change-input/article.md
8bd040e
Co-authored-by: Ezequiel Castellanos <51804994+ezzep66@users.noreply.github.com>
@nahuelcoder@EzequielCaste
Update 2-ui/4-forms-controls/3-events-change-input/article.md
fc9a2de
Co-authored-by: Ezequiel Castellanos <51804994+ezzep66@users.noreply.github.com>
@nahuelcoder@EzequielCaste
Update 2-ui/4-forms-controls/3-events-change-input/article.md
729fc97
Co-authored-by: Ezequiel Castellanos <51804994+ezzep66@users.noreply.github.com>
nahuelcoderand others added 6 commits August 5, 2020 10:29
@nahuelcoder
Update article.md
9a0f19f
@nahuelcoder@EzequielCaste
Update 2-ui/4-forms-controls/3-events-change-input/article.md
433eff8
Co-authored-by: Ezequiel Castellanos <51804994+ezzep66@users.noreply.github.com>
@nahuelcoder@EzequielCaste
Update 2-ui/4-forms-controls/3-events-change-input/article.md
10bd620
Co-authored-by: Ezequiel Castellanos <51804994+ezzep66@users.noreply.github.com>
@nahuelcoder@EzequielCaste
Update 2-ui/4-forms-controls/3-events-change-input/article.md
c5f2ec2
Co-authored-by: Ezequiel Castellanos <51804994+ezzep66@users.noreply.github.com>
@nahuelcoder@EzequielCaste
Update 2-ui/4-forms-controls/3-events-change-input/article.md
3dac9e0
Co-authored-by: Ezequiel Castellanos <51804994+ezzep66@users.noreply.github.com>
@nahuelcoder@EzequielCaste
Update 2-ui/4-forms-controls/3-events-change-input/article.md
0b8adf2
Co-authored-by: Ezequiel Castellanos <51804994+ezzep66@users.noreply.github.com>
@nahuelcoder

nahuelcoder commented Aug 5, 2020

Copy link
Copy Markdown
ContributorAuthor

/done

@EzequielCaste
EzequielCaste merged commit 62d4c63 into javascript-tutorial:masterAug 5, 2020
@javascript-translate-bot

javascript-translate-bot commented Aug 5, 2020

Copy link
Copy Markdown

Thank you 💖 I updated the Progress Issue #17 🎉 🎉 🎉

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@joaquineliojoaquineliojoaquinelio approved these changes
@EzequielCasteEzequielCasteEzequielCaste approved these changes

Assignees

No one assigned

Labels

needs +1review needed

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@nahuelcoder@javascript-translate-bot@joaquinelio@EzequielCaste