Skip to content

Object methods, "this" - #343

Merged
maksumi merged 16 commits into
javascript-tutorial:masterfrom
joaquinelio:obmeto
Aug 16, 2020
Merged

Object methods, "this"#343
maksumi merged 16 commits into
javascript-tutorial:masterfrom
joaquinelio:obmeto

Conversation

@joaquinelio

@joaquineliojoaquinelio commented Aug 11, 2020

Copy link
Copy Markdown
Member

No description provided.

@iliakaniliakan mentioned this pull request Aug 11, 2020
Open
dbritto-dev
dbritto-dev suggested changes Aug 13, 2020
View reviewed changes
Comment thread1-js/04-object-basics/04-object-methods/4-object-property-this/task.md Outdated
Comment thread1-js/04-object-basics/04-object-methods/8-chain-calls/task.md Outdated
Comment thread1-js/04-object-basics/04-object-methods/article.md Outdated
Comment thread1-js/04-object-basics/04-object-methods/article.md Outdated
Comment thread1-js/04-object-basics/04-object-methods/article.md Outdated
Comment thread1-js/04-object-basics/04-object-methods/article.md Outdated
Comment thread1-js/04-object-basics/04-object-methods/article.md Outdated
Comment thread1-js/04-object-basics/04-object-methods/article.md Outdated
@javascript-translate-bot

javascript-translate-bot commented Aug 13, 2020

Copy link
Copy Markdown

Please make the requested changes. After it, add a comment "/done".
Then I'll ask for a new review 👻

joaquinelioand others added 9 commits August 14, 2020 07:13
@joaquinelio@dbritto-dev
Update 1-js/04-object-basics/04-object-methods/article.md
6ea2d55
Co-authored-by: Danilo Britto <ddbn.c2@gmail.com>
@joaquinelio@dbritto-dev
Update 1-js/04-object-basics/04-object-methods/article.md
6f38e54
Co-authored-by: Danilo Britto <ddbn.c2@gmail.com>
@joaquinelio@dbritto-dev
Update 1-js/04-object-basics/04-object-methods/article.md
0893548
Co-authored-by: Danilo Britto <ddbn.c2@gmail.com>
@joaquinelio@dbritto-dev
Update 1-js/04-object-basics/04-object-methods/article.md
cec58a6
Co-authored-by: Danilo Britto <ddbn.c2@gmail.com>
@joaquinelio@dbritto-dev
Update 1-js/04-object-basics/04-object-methods/4-object-property-this…
12bef1e
…/task.md
Co-authored-by: Danilo Britto <ddbn.c2@gmail.com>
@joaquinelio@dbritto-dev
Update 1-js/04-object-basics/04-object-methods/8-chain-calls/task.md
39d13f7
Co-authored-by: Danilo Britto <ddbn.c2@gmail.com>
@joaquinelio@dbritto-dev
Update 1-js/04-object-basics/04-object-methods/article.md
fc63d96
Co-authored-by: Danilo Britto <ddbn.c2@gmail.com>
@joaquinelio@dbritto-dev
Update 1-js/04-object-basics/04-object-methods/article.md
f0bfccc
Co-authored-by: Danilo Britto <ddbn.c2@gmail.com>
@joaquinelio
Update article.md
a0a4875
@joaquinelio

joaquinelio commented Aug 14, 2020

Copy link
Copy Markdown
MemberAuthor

/done

maksumi
maksumi reviewed Aug 15, 2020
View reviewed changes

@maksumimaksumi left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hay algo que me causa confusión y creo que es bueno que nos lo verifiquemos. Leí un diccionario y creo que tienes razón en el "before" pero no estoy seguro ya que hay código de ejemplo que no puedo observar en modo review, así que revisaré el artículo con formato. Por otro lado a veces es difícil concentrarse en todo el contexto del artículo mientras haces review, entonces creo que eso me está pasando. Lo leeré y comprenderé antes de regresar a aprobar en caso de que tengas razón

Comment thread1-js/04-object-basics/04-object-methods/4-object-property-this/solution.md Outdated
Comment thread1-js/04-object-basics/04-object-methods/4-object-property-this/solution.md Outdated
Comment thread1-js/04-object-basics/04-object-methods/4-object-property-this/solution.md Outdated
Aquí el valor de `this` dentro de `makeUser()` es `undefined`, porque es llamado como una función, no como un método con sintaxis de punto.

The value of `this` is one for the whole function, code blocks and object literals do not affect it.
El valor de `this` es uno para la función entera, bloques de código y objetos literales no lo afectan.

@maksumimaksumiAug 15, 2020

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
El valor de `this` es uno para la función entera, bloques de código y objetos literales no lo afectan.
El valor de `this` es uno para la función entera. Bloques de código y objetos literales no lo afectan.

Funciona bien así como dos oraciones independientes en el mismo párrafo y pienso que se entiende mejor. Si lo leo con la coma me voy de corrido y pienso que es "función entera, bloques de código y objetos literales" hasta que mi cerebro hace corto circuito al encontrarse con "no lo afectan".

@dbritto-devdbritto-devAug 16, 2020

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@maksumi la coma es justamente de pausa en este caso. No se recomiendo usa punto para dar pausa o separar oraciones pequeñas.

@joaquineliojoaquinelioAug 16, 2020

Copy link
Copy Markdown
MemberAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

creo qu amerita un " ; " !!!
si está mal no me importa.

Creo que se lee bien en una oracion si lee con el ritmo adecuado,
tambien reo que se puede poner en dos oraciones aunque se corte un poquito

pero asi no hay duda:
El valor de this es uno para la función entera; bloques de código y objetos literales no lo afectan.

podria haber puesto
fun entera, ni bloquess ni lieterales...
fun entera (biques y leterales....)
muy feo.

Comment thread1-js/04-object-basics/04-object-methods/4-object-property-this/solution.md Outdated
Comment thread1-js/04-object-basics/04-object-methods/8-chain-calls/task.md Outdated
Comment thread1-js/04-object-basics/04-object-methods/article.md Outdated
Comment thread1-js/04-object-basics/04-object-methods/article.md Outdated
Comment thread1-js/04-object-basics/04-object-methods/article.md Outdated
Comment thread1-js/04-object-basics/04-object-methods/article.md Outdated
Comment thread1-js/04-object-basics/04-object-methods/article.md Outdated
joaquinelioand others added 4 commits August 15, 2020 19:53
@joaquinelioMaksumi Murakami
Update 1-js/04-object-basics/04-object-methods/4-object-property-this…
41c48b0
…/solution.md
Co-authored-by: Maksumi Murakami <maksumimurakami@gmail.com>
@joaquinelioMaksumi Murakami
Apply suggestions from code review
3803ad0
Co-authored-by: Maksumi Murakami <maksumimurakami@gmail.com>
@joaquinelioMaksumi Murakami
Update 1-js/04-object-basics/04-object-methods/article.md
1b97e0f
Co-authored-by: Maksumi Murakami <maksumimurakami@gmail.com>
@joaquinelio
Update article.md
5b91491
@joaquinelio

joaquinelio commented Aug 15, 2020•
edited
Loading

Copy link
Copy Markdown
MemberAuthor

el nombre viejo es usado!
no me parece "esta en uso", porque no lo está, trata de usarlo.
igual lo cambie a
¡usa el nombre viejo!
asi que al pobre lo siguen usando

a.X.b
cuál está delante de la X ?
y cual detras ?
uno escribe una palabra detras de otra...
si, es medio tramposo. Asi qe te hice caso y puse "antes" que no deja lugar a dudas.

No deja uar batch aca "onversation" , hice todo en "files changed" y otrass resolvi
vuelvo aca y aparecen alg sin resolver
igual edite y estan los cambios hechos y loss que no, resuesltos.

@joaquinelio

joaquinelio commented Aug 15, 2020

Copy link
Copy Markdown
MemberAuthor

/done

maksumi
maksumi approved these changes Aug 16, 2020
View reviewed changes
Comment thread1-js/04-object-basics/04-object-methods/article.md
@maksumi
maksumi merged commit 56ea948 into javascript-tutorial:masterAug 16, 2020
@javascript-translate-bot

javascript-translate-bot commented Aug 16, 2020

Copy link
Copy Markdown

Thank you 💖 I updated the Progress Issue #17 🎉 🎉 🎉

@joaquinelio
joaquinelio deleted the obmeto branch August 21, 2020 18:50
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@maksumimaksumimaksumi approved these changes
+1 more reviewer
@dbritto-devdbritto-devdbritto-dev approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

needs +1

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@joaquinelio@javascript-translate-bot@dbritto-dev@maksumi