Date and Time by Fedebornaz · Pull Request #352 · javascript-tutorial/es.javascript.info

Fedebornaz · 2020-08-18T21:53:55Z

Traducción del artículo Date and Time con sus respectivos ejercicios.

CLAassistant · 2020-08-18T21:54:00Z

All committers have signed the CLA.

maksumi · 2020-08-19T05:13:48Z

Revisando

joaquinelio

ok, lindo trabajo

Linea 97
agregaie ``` que falta (marca el final de un box), que no puedo agregar como suggest
ademass con eso los nros de linea van a coincidir

javascript-translate-bot · 2020-08-19T09:35:42Z

Please make the requested changes. After it, add a comment "/done".
Then I'll ask for a new review 👻

Co-authored-by: joaquinelio <joaquinelio@gmail.com>

…script.info into date-and-time

Fedebornaz · 2020-08-19T14:50:40Z

/done

joaquinelio

Me atreví a hacer unos commits así pasamos directamente a 2da revisión,
typos, "función", "desde" en una suggest mia, la s me falla (también sos revisor de mis revisiones, podes leerlas, cambiarlas, discutirlas) y

y , pido disculpas, volví atrás la sugerencia timestamp. Habia buscado mal la primera referencia, está perfectamente definida al principio. Así que saqué la re-definicipon desprolija que hice más adelante.

maksumi · 2020-08-19T23:05:02Z

Estaba revisando este artículo pero no podré cumplir con él a buena hora. Par no detenerlo más, pido la ayuda de @vplentinax, @EzequielCaste o algún otro reviewer que se tome la molestia de venir por aquí, leer el comentario y quiera echar una manita de gato con esto. Mil gracias de antemano

vplentinax

Pequeñas cositas, el resto correcto. Corregido esto, aprobamos.

javascript-translate-bot · 2020-08-27T23:27:38Z

Please make the requested changes. After it, add a comment "/done".
Then I'll ask for a new review 👻

Co-authored-by: Valentina VP <34555644+vplentinax@users.noreply.github.com>

Fedebornaz · 2020-08-28T01:36:13Z

Muchas gracias @vplentinax y @joaquinelio por tomarse el tiempo para hacer las reviews! Veo que la mayoría de las correcciones que me hicieron fueron typos, voy a investigar si hay alguna extensión de VSCode de corrector ortográfico que esté buena. Si tienen alguna otra herramienta que recomienden les agradezco!

Fedebornaz · 2020-08-28T01:36:37Z

/done

vplentinax

Ok!

Según repo EN.

Según repo EN

joaquinelio · 2020-08-28T04:34:17Z

alguna extensión de VSCode de corrector ortográfico que esté buena. Si tienen alguna otra herramienta que recomienden les agradezco!

@Fedebornaz don maksumi recomendó
Spanish code spell checker
pero no lo probé... y sigo con los typos...

Traducción del artículo Date and Time
81b3a90

javascript-translate-bot added the review needed label Aug 18, 2020

joaquinelio requested changes Aug 19, 2020
View reviewed changes

javascript-translate-bot added changes requested and removed review needed labels Aug 19, 2020

iliakan mentioned this pull request Aug 19, 2020
Spanish Translation Progress #17
Open

Fedebornazand others added 19 commits August 19, 2020 11:31

Update 1-js/05-data-types/11-date/1-new-date/solution.md
0230231
Co-authored-by: joaquinelio <joaquinelio@gmail.com>

Update 1-js/05-data-types/11-date/3-weekday/task.md
5ed3cfa
Co-authored-by: joaquinelio <joaquinelio@gmail.com>

Update 1-js/05-data-types/11-date/4-get-date-ago/solution.md
c815759
Co-authored-by: joaquinelio <joaquinelio@gmail.com>

Update 1-js/05-data-types/11-date/4-get-date-ago/task.md
3d69f63
Co-authored-by: joaquinelio <joaquinelio@gmail.com>

Update 1-js/05-data-types/11-date/4-get-date-ago/task.md
8ed2752
Co-authored-by: joaquinelio <joaquinelio@gmail.com>

Update 1-js/05-data-types/11-date/5-last-day-of-month/task.md
b5bf760
Co-authored-by: joaquinelio <joaquinelio@gmail.com>

Update 1-js/05-data-types/11-date/5-last-day-of-month/task.md
d60abda
Co-authored-by: joaquinelio <joaquinelio@gmail.com>

Update 1-js/05-data-types/11-date/article.md
79c88fb
Co-authored-by: joaquinelio <joaquinelio@gmail.com>

Update 1-js/05-data-types/11-date/article.md
415e063
Co-authored-by: joaquinelio <joaquinelio@gmail.com>

Update 1-js/05-data-types/11-date/article.md
4f5de13
Co-authored-by: joaquinelio <joaquinelio@gmail.com>

Update 1-js/05-data-types/11-date/8-format-date-relative/task.md
f619ed7
Co-authored-by: joaquinelio <joaquinelio@gmail.com>

Update 1-js/05-data-types/11-date/article.md
602a2d1
Co-authored-by: joaquinelio <joaquinelio@gmail.com>

Update 1-js/05-data-types/11-date/article.md
4fce385
Co-authored-by: joaquinelio <joaquinelio@gmail.com>

Update 1-js/05-data-types/11-date/article.md
6c114e2
Co-authored-by: joaquinelio <joaquinelio@gmail.com>

Update 1-js/05-data-types/11-date/article.md
401c423
Co-authored-by: joaquinelio <joaquinelio@gmail.com>

Update 1-js/05-data-types/11-date/article.md
80b74c7
Co-authored-by: joaquinelio <joaquinelio@gmail.com>

Update 1-js/05-data-types/11-date/article.md
6b4af91
Co-authored-by: joaquinelio <joaquinelio@gmail.com>

agregados caracteres de cierre de box en línea 97
d53946c

Merge branch 'date-and-time' ofhttps://github.com/Fedebornaz/es.java…
ee2b149
…script.info into date-and-time

javascript-translate-bot removed the changes requested label Aug 19, 2020

javascript-translate-bot added the review needed label Aug 19, 2020

joaquinelio added 4 commits August 19, 2020 17:14

Update article.md
48e5264

Update task.md
b59c98c

Update solution.md
191567f

Update article.md
1f4722f

joaquinelio approved these changes Aug 19, 2020
View reviewed changes

javascript-translate-bot added needs +1 and removed review needed labels Aug 19, 2020

vplentinax requested changes Aug 27, 2020
View reviewed changes

Comment thread1-js/05-data-types/11-date/article.md Outdated
Comment thread1-js/05-data-types/11-date/article.md Outdated
Comment thread1-js/05-data-types/11-date/article.md Outdated
Comment thread1-js/05-data-types/11-date/2-get-week-day/solution.md Outdated

javascript-translate-bot added the changes requested label Aug 27, 2020

Fedebornazand others added 4 commits August 27, 2020 22:26

Update 1-js/05-data-types/11-date/article.md
1147101
Co-authored-by: Valentina VP <34555644+vplentinax@users.noreply.github.com>

Update 1-js/05-data-types/11-date/article.md
f3bdfca
Co-authored-by: Valentina VP <34555644+vplentinax@users.noreply.github.com>

Update 1-js/05-data-types/11-date/article.md
63681a2
Co-authored-by: Valentina VP <34555644+vplentinax@users.noreply.github.com>

Update 1-js/05-data-types/11-date/2-get-week-day/solution.md
450593e
Co-authored-by: Valentina VP <34555644+vplentinax@users.noreply.github.com>

javascript-translate-bot added review needed and removed changes requested labels Aug 28, 2020

vplentinax approved these changes Aug 28, 2020
View reviewed changes

vplentinax added ready to merge and removed needs +1 review needed labels Aug 28, 2020

vplentinax added 2 commits August 27, 2020 22:56

Update solution.md
046c2fc
Según repo EN.

Update solution.md
e343aa2
Según repo EN

joaquinelio merged commit c944cdf into javascript-tutorial:masterAug 28, 2020

Uh oh!

Conversation

Fedebornaz commented Aug 18, 2020

Uh oh!

CLAassistant commented Aug 18, 2020• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

maksumi commented Aug 19, 2020

Uh oh!

joaquinelio left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

javascript-translate-bot commented Aug 19, 2020

Uh oh!

Fedebornaz commented Aug 19, 2020

Uh oh!

joaquinelio left a comment

Choose a reason for hiding this comment

Uh oh!

maksumi commented Aug 19, 2020• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

vplentinax left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

javascript-translate-bot commented Aug 27, 2020

Uh oh!

Fedebornaz commented Aug 28, 2020

Uh oh!

Fedebornaz commented Aug 28, 2020

Uh oh!

vplentinax left a comment

Choose a reason for hiding this comment

Uh oh!

joaquinelio commented Aug 28, 2020

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

CLAassistant commented Aug 18, 2020•
edited
Loading

maksumi commented Aug 19, 2020•
edited
Loading