Skip to content

Long polling - #354

Merged
vplentinax merged 11 commits into
javascript-tutorial:masterfrom
homero304:Long-polling
Aug 27, 2020
Merged

Long polling#354
vplentinax merged 11 commits into
javascript-tutorial:masterfrom
homero304:Long-polling

Conversation

@homero304

@homero304homero304 commented Aug 22, 2020

Copy link
Copy Markdown
Contributor

Hi. Please review my PR.
question. How can i see the svg image in the article ?
I have the following error: /long-polling.svg: Could not execute GraphicsMagick/ImageMagick: identify "-ping" "-format" "{"width":%w,"height":%h}" "/long-polling.svg
I tried to install ImageMagick7 -- https://linuxconfig.org/how-to-install-imagemagick-7-on-ubuntu-18-04-linux
but ran into trouble when i tried to run the server again. It was complaining that it could not create a symbolic link for ImageMagick7++...la

Thanks
Regards,
Homero Marin

@iliakaniliakan mentioned this pull request Aug 22, 2020
Open
@joaquinelio
joaquinelio self-requested a review August 22, 2020 23:03
@joaquinelio

joaquinelio commented Aug 22, 2020

Copy link
Copy Markdown
Member

Sobre img sobre server, ni idea. Igual no hace falta, Eze los tradujo todos, si no modificas el link funcionará.
Acá mismo lo podes probar "file changes" y en el menu "...", "view file"

¡Eh!

@iliakan iliakan mentioned this pull request 12 minutes ago Spanish Translation Progress #17

¡Fui yo quien lo agregó hace 12 minutos! Este bot más boleado cada día.

joaquinelio
joaquinelio requested changes Aug 23, 2020
View reviewed changes

@joaquineliojoaquinelio left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Algunas cosas...

que sugerí tambien cambiar en inglés
jeje Apuesto que lo rechaza pero que lo rescribe uno que sí sabe inglés.

Comment thread5-network/10-long-polling/article.md Outdated
Comment thread5-network/10-long-polling/article.md Outdated
Comment thread5-network/10-long-polling/article.md Outdated
Comment thread5-network/10-long-polling/article.md Outdated
Comment thread5-network/10-long-polling/article.md Outdated
Comment thread5-network/10-long-polling/article.md Outdated
Comment thread5-network/10-long-polling/longpoll.view/browser.js Outdated
Comment thread5-network/10-long-polling/longpoll.view/server.js Outdated
@javascript-translate-bot

javascript-translate-bot commented Aug 23, 2020

Copy link
Copy Markdown

Please make the requested changes. After it, add a comment "/done".
Then I'll ask for a new review 👻

omero329and others added 9 commits August 22, 2020 20:48
@omero329@joaquinelio
Update 5-network/10-long-polling/article.md
a00d708
acentuacion de conjugacion estar en subjuntivo
Co-authored-by: joaquinelio <joaquinelio@gmail.com>
@omero329@joaquinelio
Update 5-network/10-long-polling/article.md
30108fa
cuesstión de percepcion...
Co-authored-by: joaquinelio <joaquinelio@gmail.com>
@omero329@joaquinelio
Update 5-network/10-long-polling/article.md
dae638f
conexiones, procesos y memoria consumida
Co-authored-by: joaquinelio <joaquinelio@gmail.com>
@omero329@joaquinelio
Update 5-network/10-long-polling/article.md
03a0d17
lenguajes, problema de implementacion no del lenguaje en si. algunos lenguajes son mas amigables que otros
Co-authored-by: joaquinelio <joaquinelio@gmail.com>
@omero329@joaquinelio
Update 5-network/10-long-polling/longpoll.view/browser.js
1372c70
pasado de expirar
Co-authored-by: joaquinelio <joaquinelio@gmail.com>
@omero329@joaquinelio
Update 5-network/10-long-polling/longpoll.view/server.js
8355a92
a -> para
Co-authored-by: joaquinelio <joaquinelio@gmail.com>
@omero329@joaquinelio
Update 5-network/10-long-polling/article.md
7510557
periodico
Co-authored-by: joaquinelio <joaquinelio@gmail.com>
@omero329
error 502: tiempo de espera agotado
2f4d805
@omero329
cerró la conexión
882a263
@homero304

homero304 commented Aug 23, 2020

Copy link
Copy Markdown
ContributorAuthor

/done

joaquinelio
joaquinelio approved these changes Aug 23, 2020
View reviewed changes

@joaquineliojoaquinelio left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

vplentinax
vplentinax approved these changes Aug 27, 2020
View reviewed changes

@vplentinaxvplentinax left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok!

@vplentinax
vplentinax merged commit fa5cee7 into javascript-tutorial:masterAug 27, 2020
@javascript-translate-bot

javascript-translate-bot commented Aug 27, 2020

Copy link
Copy Markdown

Thank you 💖 I updated the Progress Issue #17 🎉 🎉 🎉

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@joaquineliojoaquineliojoaquinelio approved these changes
@vplentinaxvplentinaxvplentinax approved these changes

Assignees

No one assigned

Labels

ready to merge

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@homero304@joaquinelio@javascript-translate-bot@vplentinax@omero329