Skip to content

Cross-window communication - #367

Merged
EzequielCaste merged 11 commits into
javascript-tutorial:masterfrom
homero304:Cross-window-communication
Sep 1, 2020
Merged

Cross-window communication#367
EzequielCaste merged 11 commits into
javascript-tutorial:masterfrom
homero304:Cross-window-communication

Conversation

@homero304

@homero304homero304 commented Sep 1, 2020

Copy link
Copy Markdown
Contributor

Please review my PR

@joaquinelio
joaquinelio self-requested a review September 1, 2020 04:36
joaquinelio
joaquinelio requested changes Sep 1, 2020
View reviewed changes

@joaquineliojoaquinelio left a comment •
edited
Loading

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Bot no puso #pr al issue, ojo reviewerrs

me acabo de dar cuenta de q Ilya peca de "en otras palabras"
pero no voy a leer el coso este de nuevo,
aviso por si alguien tiene ganas de mechar alternativas, "e decir"
por ahi ni vale la pena
el coso ete esta bueno, cambio menores solo ssugeridos
no pierdan tiempo que vaya a merge

Comment thread3-frames-and-windows/03-cross-window-communication/article.md Outdated
Comment thread3-frames-and-windows/03-cross-window-communication/article.md Outdated
Comment thread3-frames-and-windows/03-cross-window-communication/article.md Outdated
Comment thread3-frames-and-windows/03-cross-window-communication/article.md Outdated
@javascript-translate-bot

javascript-translate-bot commented Sep 1, 2020

Copy link
Copy Markdown

Please make the requested changes. After it, add a comment "/done".
Then I'll ask for a new review 👻

@iliakaniliakan mentioned this pull request Sep 1, 2020
Open
omero329and others added 4 commits September 1, 2020 01:44
@omero329@joaquinelio
Update 3-frames-and-windows/03-cross-window-communication/article.md
f15ce6d
Co-authored-by: joaquinelio <joaquinelio@gmail.com>
@omero329@joaquinelio
Update 3-frames-and-windows/03-cross-window-communication/article.md
ff63369
Co-authored-by: joaquinelio <joaquinelio@gmail.com>
@omero329@joaquinelio
Update 3-frames-and-windows/03-cross-window-communication/article.md
270a488
Co-authored-by: joaquinelio <joaquinelio@gmail.com>
@omero329@joaquinelio
Update 3-frames-and-windows/03-cross-window-communication/article.md
220f440
Co-authored-by: joaquinelio <joaquinelio@gmail.com>
@homero304

homero304 commented Sep 1, 2020

Copy link
Copy Markdown
ContributorAuthor

/done

EzequielCaste
EzequielCaste requested changes Sep 1, 2020
View reviewed changes

@EzequielCasteEzequielCaste left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Super Bien la traducción 💯 🎉

algunos comentarios que podríamos debatir. nada grave...

Muchas gracias por tu aporte.

Comment thread3-frames-and-windows/03-cross-window-communication/article.md Outdated
Comment thread3-frames-and-windows/03-cross-window-communication/article.md Outdated
Comment thread3-frames-and-windows/03-cross-window-communication/article.md Outdated
Comment thread3-frames-and-windows/03-cross-window-communication/article.md Outdated
Comment thread3-frames-and-windows/03-cross-window-communication/article.md Outdated
Comment thread3-frames-and-windows/03-cross-window-communication/article.md Outdated
@javascript-translate-bot

javascript-translate-bot commented Sep 1, 2020

Copy link
Copy Markdown

Please make the requested changes. After it, add a comment "/done".
Then I'll ask for a new review 👻

omero329and others added 6 commits September 1, 2020 09:35
@omero329@EzequielCaste
Update 3-frames-and-windows/03-cross-window-communication/article.md
f7adb65
Co-authored-by: Ezequiel Castellanos <51804994+EzequielCaste@users.noreply.github.com>
@omero329@EzequielCaste
Update 3-frames-and-windows/03-cross-window-communication/article.md
0682c4f
Co-authored-by: Ezequiel Castellanos <51804994+EzequielCaste@users.noreply.github.com>
@omero329@EzequielCaste
Update 3-frames-and-windows/03-cross-window-communication/article.md
a276b4b
Co-authored-by: Ezequiel Castellanos <51804994+EzequielCaste@users.noreply.github.com>
@omero329@EzequielCaste
Update 3-frames-and-windows/03-cross-window-communication/article.md
fd63b84
Co-authored-by: Ezequiel Castellanos <51804994+EzequielCaste@users.noreply.github.com>
@omero329@EzequielCaste
Update 3-frames-and-windows/03-cross-window-communication/article.md
7701bdc
Co-authored-by: Ezequiel Castellanos <51804994+EzequielCaste@users.noreply.github.com>
@omero329
line:266 cadenas->strings
0726d44
@homero304

homero304 commented Sep 1, 2020

Copy link
Copy Markdown
ContributorAuthor

/done

@EzequielCaste
EzequielCaste merged commit 4a84bb5 into javascript-tutorial:masterSep 1, 2020
@javascript-translate-bot

javascript-translate-bot commented Sep 1, 2020

Copy link
Copy Markdown

Thank you 💖 I updated the Progress Issue #17 🎉 🎉 🎉

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@joaquineliojoaquineliojoaquinelio approved these changes
@EzequielCasteEzequielCasteEzequielCaste approved these changes

Assignees

No one assigned

Labels

needs +1review needed

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@homero304@javascript-translate-bot@joaquinelio@EzequielCaste@omero329