Skip to content

Bubbling and capturing - #372

Merged
joaquinelio merged 21 commits into
javascript-tutorial:masterfrom
mariomenjr:article/02-bubling-and-capturing
Sep 8, 2020
Merged

Bubbling and capturing#372
joaquinelio merged 21 commits into
javascript-tutorial:masterfrom
mariomenjr:article/02-bubling-and-capturing

Conversation

@mariomenjr

@mariomenjrmariomenjr commented Sep 3, 2020

Copy link
Copy Markdown
Contributor

@CLAassistant

CLAassistant commented Sep 3, 2020•
edited
Loading

Copy link
Copy Markdown

CLA assistant check
All committers have signed the CLA.

@joaquineliojoaquinelio mentioned this pull request Sep 3, 2020
Closed
joaquinelio
joaquinelio requested changes Sep 3, 2020
View reviewed changes

@joaquineliojoaquinelio left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

typos

Me gustó que usaras "manejadores". Uso controladores para otra cosa (como... controllers)
pero otros reviewers los prefieren. Veremos

Comment thread2-ui/2-events/02-bubbling-and-capturing/article.md Outdated
Comment thread2-ui/2-events/02-bubbling-and-capturing/article.md Outdated
Comment thread2-ui/2-events/02-bubbling-and-capturing/article.md Outdated
Comment thread2-ui/2-events/02-bubbling-and-capturing/article.md Outdated
Comment thread2-ui/2-events/02-bubbling-and-capturing/article.md Outdated
Comment thread2-ui/2-events/02-bubbling-and-capturing/article.md Outdated
Comment thread2-ui/2-events/02-bubbling-and-capturing/article.md Outdated
Comment thread2-ui/2-events/02-bubbling-and-capturing/article.md Outdated
Comment thread2-ui/2-events/02-bubbling-and-capturing/article.md Outdated
Comment thread2-ui/2-events/02-bubbling-and-capturing/article.md Outdated
@javascript-translate-bot

javascript-translate-bot commented Sep 3, 2020

Copy link
Copy Markdown

Please make the requested changes. After it, add a comment "/done".
Then I'll ask for a new review 👻

@iliakaniliakan mentioned this pull request Sep 3, 2020
Open
mariomenjrand others added 16 commits September 3, 2020 20:05
@mariomenjr@joaquinelio
Update 2-ui/2-events/02-bubbling-and-capturing/article.md
e8ee2a0
Co-authored-by: joaquinelio <joaquinelio@gmail.com>
@mariomenjr@joaquinelio
Update 2-ui/2-events/02-bubbling-and-capturing/article.md
1d9f8d9
Co-authored-by: joaquinelio <joaquinelio@gmail.com>
@mariomenjr@joaquinelio
Update 2-ui/2-events/02-bubbling-and-capturing/article.md
9864344
Añadiendo tilde.
Co-authored-by: joaquinelio <joaquinelio@gmail.com>
@mariomenjr@joaquinelio
Update 2-ui/2-events/02-bubbling-and-capturing/article.md
9bdaae3
Co-authored-by: joaquinelio <joaquinelio@gmail.com>
@mariomenjr@joaquinelio
Update 2-ui/2-events/02-bubbling-and-capturing/article.md
aa996e9
Reemplazar `dónde` por `donde`
Co-authored-by: joaquinelio <joaquinelio@gmail.com>
@mariomenjr@joaquinelio
Update 2-ui/2-events/02-bubbling-and-capturing/article.md
086b2a4
Co-authored-by: joaquinelio <joaquinelio@gmail.com>
@mariomenjr@joaquinelio
Update 2-ui/2-events/02-bubbling-and-capturing/article.md
7ded877
Co-authored-by: joaquinelio <joaquinelio@gmail.com>
@mariomenjr@joaquinelio
Update 2-ui/2-events/02-bubbling-and-capturing/article.md
539738d
Co-authored-by: joaquinelio <joaquinelio@gmail.com>
@mariomenjr@joaquinelio
Update 2-ui/2-events/02-bubbling-and-capturing/article.md
c1c8227
Co-authored-by: joaquinelio <joaquinelio@gmail.com>
@mariomenjr@joaquinelio
Update 2-ui/2-events/02-bubbling-and-capturing/article.md
6f697f7
Co-authored-by: joaquinelio <joaquinelio@gmail.com>
@mariomenjr@joaquinelio
Update 2-ui/2-events/02-bubbling-and-capturing/article.md
b3132a1
Co-authored-by: joaquinelio <joaquinelio@gmail.com>
@mariomenjr@joaquinelio
Update 2-ui/2-events/02-bubbling-and-capturing/article.md
2140566
Co-authored-by: joaquinelio <joaquinelio@gmail.com>
@mariomenjr@joaquinelio
Update 2-ui/2-events/02-bubbling-and-capturing/article.md
48a7084
Co-authored-by: joaquinelio <joaquinelio@gmail.com>
@mariomenjr@joaquinelio
Update 2-ui/2-events/02-bubbling-and-capturing/article.md
a8aa672
Co-authored-by: joaquinelio <joaquinelio@gmail.com>
@mariomenjr
Fix left suggestion in PR#372
eda8b0c
@mariomenjr
Fix minor typos
f1d5214
@mariomenjr

mariomenjr commented Sep 4, 2020

Copy link
Copy Markdown
ContributorAuthor

/done

joaquinelio
joaquinelio approved these changes Sep 4, 2020
View reviewed changes

@joaquineliojoaquinelio left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

vplentinax
vplentinax approved these changes Sep 8, 2020
View reviewed changes

@vplentinaxvplentinax left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Correcto

@joaquinelio
joaquinelio merged commit 6aca5c8 into javascript-tutorial:masterSep 8, 2020
@javascript-translate-bot

javascript-translate-bot commented Sep 8, 2020

Copy link
Copy Markdown

Thank you 💖 I updated the Progress Issue #17 🎉 🎉 🎉

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@joaquineliojoaquineliojoaquinelio approved these changes
@vplentinaxvplentinaxvplentinax approved these changes

Assignees

No one assigned

Labels

ready to merge

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@mariomenjr@CLAassistant@javascript-translate-bot@joaquinelio@vplentinax