Skip to content

XMLHttpRequest - #377

Merged
joaquinelio merged 26 commits into
javascript-tutorial:masterfrom
kenliten:master
Sep 15, 2020
Merged

XMLHttpRequest#377
joaquinelio merged 26 commits into
javascript-tutorial:masterfrom
kenliten:master

Conversation

@kenliten

@kenlitenkenliten commented Sep 9, 2020

Copy link
Copy Markdown
Contributor

Full translated XMLHttpRequest to spanish

@iliakaniliakan mentioned this pull request Sep 9, 2020
Open
joaquinelio
joaquinelio requested changes Sep 9, 2020
View reviewed changes

@joaquineliojoaquinelio left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Es formato md, no html crudo. No van los simbolos htm.
Y algunos acentos más...

JA!
Tendría que habértelo dejado, pero para cuando me di cuenta ya había avanzado y me emperré...

Comment thread5-network/08-xmlhttprequest/article.md Outdated
Comment thread5-network/08-xmlhttprequest/article.md Outdated
Comment thread5-network/08-xmlhttprequest/article.md Outdated
Comment thread5-network/08-xmlhttprequest/article.md Outdated
Comment thread5-network/08-xmlhttprequest/article.md Outdated
Comment thread5-network/08-xmlhttprequest/article.md Outdated
Comment thread5-network/08-xmlhttprequest/article.md Outdated
Comment thread5-network/08-xmlhttprequest/article.md Outdated
Comment thread5-network/08-xmlhttprequest/article.md Outdated
Comment thread5-network/08-xmlhttprequest/article.md Outdated
@javascript-translate-bot

javascript-translate-bot commented Sep 9, 2020

Copy link
Copy Markdown

Please make the requested changes. After it, add a comment "/done".
Then I'll ask for a new review 👻

joaquinelioand others added 11 commits September 9, 2020 10:21
@joaquinelio
Update article.md
59e4318
Otoniel Reyes Galay@joaquinelio
Update 5-network/08-xmlhttprequest/article.md
ec3cf01
Co-authored-by: joaquinelio <joaquinelio@gmail.com>
Otoniel Reyes Galay@joaquinelio
Update 5-network/08-xmlhttprequest/article.md
996c93f
Co-authored-by: joaquinelio <joaquinelio@gmail.com>
Otoniel Reyes Galay@joaquinelio
Update 5-network/08-xmlhttprequest/article.md
9705f09
Co-authored-by: joaquinelio <joaquinelio@gmail.com>
Otoniel Reyes Galay@joaquinelio
Update 5-network/08-xmlhttprequest/article.md
637a408
Co-authored-by: joaquinelio <joaquinelio@gmail.com>
Otoniel Reyes Galay@joaquinelio
Update 5-network/08-xmlhttprequest/article.md
45c54db
Co-authored-by: joaquinelio <joaquinelio@gmail.com>
Otoniel Reyes Galay@joaquinelio
Update 5-network/08-xmlhttprequest/article.md
d5cd214
Co-authored-by: joaquinelio <joaquinelio@gmail.com>
Otoniel Reyes Galay@joaquinelio
Update 5-network/08-xmlhttprequest/article.md
d1cb89b
Co-authored-by: joaquinelio <joaquinelio@gmail.com>
Otoniel Reyes Galay@joaquinelio
Update 5-network/08-xmlhttprequest/article.md
51409c1
Co-authored-by: joaquinelio <joaquinelio@gmail.com>
Otoniel Reyes Galay@joaquinelio
Update 5-network/08-xmlhttprequest/article.md
008550c
Co-authored-by: joaquinelio <joaquinelio@gmail.com>
Otoniel Reyes Galay@joaquinelio
Update 5-network/08-xmlhttprequest/article.md
4ffe79b
Co-authored-by: joaquinelio <joaquinelio@gmail.com>
@kenliten

kenliten commented Sep 14, 2020

Copy link
Copy Markdown
ContributorAuthor

/done

Otoniel Reyes Galayand others added 7 commits September 14, 2020 03:10
Otoniel Reyes Galay@joaquinelio
Update 5-network/08-xmlhttprequest/article.md
0d4c51d
Co-authored-by: joaquinelio <joaquinelio@gmail.com>
Otoniel Reyes Galay@joaquinelio
Update 5-network/08-xmlhttprequest/article.md
648b83a
Co-authored-by: joaquinelio <joaquinelio@gmail.com>
Otoniel Reyes Galay@joaquinelio
Update 5-network/08-xmlhttprequest/article.md
1ab4dac
Co-authored-by: joaquinelio <joaquinelio@gmail.com>
Otoniel Reyes Galay@joaquinelio
Update 5-network/08-xmlhttprequest/article.md
5a25272
Co-authored-by: joaquinelio <joaquinelio@gmail.com>
Otoniel Reyes Galay@joaquinelio
Update 5-network/08-xmlhttprequest/article.md
43d5cc5
Co-authored-by: joaquinelio <joaquinelio@gmail.com>
Otoniel Reyes Galay@joaquinelio
Update 5-network/08-xmlhttprequest/article.md
bc49505
Co-authored-by: joaquinelio <joaquinelio@gmail.com>
Otoniel Reyes Galay@joaquinelio
Update 5-network/08-xmlhttprequest/article.md
e643c2c
Co-authored-by: joaquinelio <joaquinelio@gmail.com>
Otoniel Reyes Galayand others added 6 commits September 14, 2020 03:14
Otoniel Reyes Galay@joaquinelio
Update 5-network/08-xmlhttprequest/article.md
c4e70f8
Co-authored-by: joaquinelio <joaquinelio@gmail.com>
Otoniel Reyes Galay@joaquinelio
Apply suggestions from code review
f42b65c
Co-authored-by: joaquinelio <joaquinelio@gmail.com>
Otoniel Reyes Galay@joaquinelio
Apply suggestions from code review
edb5fa7
Co-authored-by: joaquinelio <joaquinelio@gmail.com>
Otoniel Reyes Galay@joaquinelio
Apply suggestions from code review
364bee4
Co-authored-by: joaquinelio <joaquinelio@gmail.com>
@joaquinelio
Update article.md
93a0d57
@joaquinelio
Update article.md
5223e91
joaquinelio
joaquinelio approved these changes Sep 14, 2020
View reviewed changes

@joaquineliojoaquinelio left a comment •
edited
Loading

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

Me gustó que hayas puesto "nativo",
mucho más que "incorporado" que no es muy intuitivo y como se entiende de inmediato no sugerí el cambio...
Es más, lo pondría en el glosario... aunque ya tenemos demasiado avanzado.
Es más, sugeriría un cambio masivo.
Es más, iría a MDN a cambiarlo ahí... aunque hay cosas peores.

vplentinax
vplentinax approved these changes Sep 14, 2020
View reviewed changes

@vplentinaxvplentinax left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

¡Fuímonos!

@joaquinelio
joaquinelio merged commit 57eeb9f into javascript-tutorial:masterSep 15, 2020
@javascript-translate-bot

javascript-translate-bot commented Sep 15, 2020

Copy link
Copy Markdown

Thank you 💖 I updated the Progress Issue #17 🎉 🎉 🎉

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@joaquineliojoaquineliojoaquinelio approved these changes
@vplentinaxvplentinaxvplentinax approved these changes

Assignees

No one assigned

Labels

ready to merge

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@kenliten@javascript-translate-bot@joaquinelio@vplentinax