Skip to content

Browser default actions - #378

Merged
joaquinelio merged 13 commits into
javascript-tutorial:masterfrom
homero304:Browser-default-actions
Sep 15, 2020
Merged

Browser default actions#378
joaquinelio merged 13 commits into
javascript-tutorial:masterfrom
homero304:Browser-default-actions

Conversation

@homero304

@homero304homero304 commented Sep 11, 2020

Copy link
Copy Markdown
Contributor

please review my PR

@homero304
homero304force-pushed the Browser-default-actions branch from a5d87fc to 243a87cCompareSeptember 11, 2020 03:20
joaquinelio
joaquinelio requested changes Sep 11, 2020
View reviewed changes

@joaquineliojoaquinelio left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Creo que no hay errores y todas son sugerencias de estilo, aplicala s o cambialas si queres

Comment thread2-ui/2-events/04-default-browser-action/article.md Outdated
Comment thread2-ui/2-events/04-default-browser-action/article.md Outdated
Comment thread2-ui/2-events/04-default-browser-action/article.md Outdated
Comment thread2-ui/2-events/04-default-browser-action/1-why-return-false-fails/solution.md Outdated
Comment thread2-ui/2-events/04-default-browser-action/2-catch-link-navigation/solution.md Outdated
Comment thread2-ui/2-events/04-default-browser-action/3-image-gallery/source.view/index.html Outdated
@javascript-translate-bot

javascript-translate-bot commented Sep 11, 2020

Copy link
Copy Markdown

Please make the requested changes. After it, add a comment "/done".
Then I'll ask for a new review 👻

@joaquineliojoaquinelio mentioned this pull request Sep 11, 2020
Open
omero329and others added 7 commits September 11, 2020 08:25
@omero329@joaquinelio
Update 2-ui/2-events/04-default-browser-action/article.md
c17b5f6
Co-authored-by: joaquinelio <joaquinelio@gmail.com>
@omero329@joaquinelio
Update 2-ui/2-events/04-default-browser-action/article.md
91cf14a
Co-authored-by: joaquinelio <joaquinelio@gmail.com>
@omero329
'Entonces','de inmediato'
41f89c1
@omero329@joaquinelio
Update 2-ui/2-events/04-default-browser-action/1-why-return-false-fai…
9389b69
…ls/solution.md
Co-authored-by: joaquinelio <joaquinelio@gmail.com>
@omero329@joaquinelio
Update 2-ui/2-events/04-default-browser-action/2-catch-link-navigatio…
52bdeda
…n/solution.md
Co-authored-by: joaquinelio <joaquinelio@gmail.com>
@omero329@joaquinelio
Update 2-ui/2-events/04-default-browser-action/3-image-gallery/source…
febee0a
….view/index.html
Co-authored-by: joaquinelio <joaquinelio@gmail.com>
@omero329
Merge branch 'Browser-default-actions' ofhttps://github.com/homero30…
9bd14bd
…4/es.javascript.info into Browser-default-actions
@homero304

homero304 commented Sep 11, 2020

Copy link
Copy Markdown
ContributorAuthor

/done

joaquinelio
joaquinelio requested changes Sep 12, 2020
View reviewed changes

@joaquineliojoaquinelio left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

¿me disculpas que haya agregado mas cosas? de estilo tambien

salvo un acento faltante que note haciendo zoom

Comment thread2-ui/2-events/04-default-browser-action/article.md Outdated
Comment thread2-ui/2-events/04-default-browser-action/2-catch-link-navigation/task.md Outdated
Comment thread2-ui/2-events/04-default-browser-action/article.md Outdated
Comment thread2-ui/2-events/04-default-browser-action/article.md Outdated
Comment thread2-ui/2-events/04-default-browser-action/article.md Outdated
@javascript-translate-bot

javascript-translate-bot commented Sep 12, 2020

Copy link
Copy Markdown

Please make the requested changes. After it, add a comment "/done".
Then I'll ask for a new review 👻

omero329and others added 5 commits September 12, 2020 10:45
@omero329@joaquinelio
Update 2-ui/2-events/04-default-browser-action/article.md
b79e278
Co-authored-by: joaquinelio <joaquinelio@gmail.com>
@omero329@joaquinelio
Update 2-ui/2-events/04-default-browser-action/2-catch-link-navigatio…
f074459
…n/task.md
Co-authored-by: joaquinelio <joaquinelio@gmail.com>
@omero329@joaquinelio
Update 2-ui/2-events/04-default-browser-action/article.md
b18160b
Co-authored-by: joaquinelio <joaquinelio@gmail.com>
@omero329@joaquinelio
Update 2-ui/2-events/04-default-browser-action/article.md
95bda95
Co-authored-by: joaquinelio <joaquinelio@gmail.com>
@omero329@joaquinelio
Update 2-ui/2-events/04-default-browser-action/article.md
ae338c5
Co-authored-by: joaquinelio <joaquinelio@gmail.com>
@homero304

homero304 commented Sep 12, 2020

Copy link
Copy Markdown
ContributorAuthor

/done

joaquinelio
joaquinelio approved these changes Sep 12, 2020
View reviewed changes

@joaquineliojoaquinelio left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

vplentinax
vplentinax approved these changes Sep 14, 2020
View reviewed changes

@vplentinaxvplentinax left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Bien!

@joaquinelio
joaquinelio merged commit 5d87fd8 into javascript-tutorial:masterSep 15, 2020
@javascript-translate-bot

javascript-translate-bot commented Sep 15, 2020

Copy link
Copy Markdown

Thank you 💖 I updated the Progress Issue #17 🎉 🎉 🎉

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@joaquineliojoaquineliojoaquinelio approved these changes
@vplentinaxvplentinaxvplentinax approved these changes

Assignees

No one assigned

Labels

ready to merge

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@homero304@javascript-translate-bot@joaquinelio@vplentinax@omero329