Skip to content

Server Sent Events - #381

Merged
joaquinelio merged 7 commits into
javascript-tutorial:masterfrom
homero304:Server-Sent-Events
Sep 21, 2020
Merged

Server Sent Events#381
joaquinelio merged 7 commits into
javascript-tutorial:masterfrom
homero304:Server-Sent-Events

Conversation

@homero304

@homero304homero304 commented Sep 17, 2020

Copy link
Copy Markdown
Contributor

please review my PR

@javascript-translate-botjavascript-translate-bot mentioned this pull request Sep 17, 2020
Open
joaquinelio
joaquinelio requested changes Sep 20, 2020
View reviewed changes

@joaquineliojoaquinelio left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

muy claro, tá bueno
un par de cositas nomás

Comment thread5-network/12-server-sent-events/article.md Outdated
Comment thread5-network/12-server-sent-events/article.md Outdated
@javascript-translate-bot

javascript-translate-bot commented Sep 20, 2020

Copy link
Copy Markdown

Please make the requested changes. After it, add a comment "/done".
Then I'll ask for a new review 👻

omero329and others added 2 commits September 20, 2020 07:20
@omero329@joaquinelio
Update 5-network/12-server-sent-events/article.md
82d2366
Co-authored-by: joaquinelio <joaquinelio@gmail.com>
@omero329@joaquinelio
Update 5-network/12-server-sent-events/article.md
72f9898
Co-authored-by: joaquinelio <joaquinelio@gmail.com>
@homero304

homero304 commented Sep 20, 2020

Copy link
Copy Markdown
ContributorAuthor

/done

joaquinelio
joaquinelio requested changes Sep 20, 2020
View reviewed changes

@joaquineliojoaquinelio left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sorry por la vuelta
una que sugerí me molesta,

y otra que molestaba no supe sugerir antes.

Molesta tambien lo de "cross origin", no traducirlo ni explicarlo,
pero linkea a FETCH en este mismo capitulo y es donde lo explica asi que es correcto que quede así.

Comment thread5-network/12-server-sent-events/article.md Outdated
Comment thread5-network/12-server-sent-events/article.md Outdated
@javascript-translate-bot

javascript-translate-bot commented Sep 20, 2020

Copy link
Copy Markdown

Please make the requested changes. After it, add a comment "/done".
Then I'll ask for a new review 👻

vplentinax
vplentinax approved these changes Sep 20, 2020
View reviewed changes

@vplentinaxvplentinax left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok!

omero329and others added 2 commits September 20, 2020 15:26
@omero329@joaquinelio
Update 5-network/12-server-sent-events/article.md
cd290ad
Co-authored-by: joaquinelio <joaquinelio@gmail.com>
@omero329@joaquinelio
Update 5-network/12-server-sent-events/article.md
aff46c4
Co-authored-by: joaquinelio <joaquinelio@gmail.com>
@homero304

homero304 commented Sep 20, 2020

Copy link
Copy Markdown
ContributorAuthor

/done

@joaquinelio
joaquinelio merged commit 7de52cc into javascript-tutorial:masterSep 21, 2020
@javascript-translate-bot

javascript-translate-bot commented Sep 21, 2020

Copy link
Copy Markdown

Thank you 💖 I updated the Progress Issue #17 🎉 🎉 🎉

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@joaquineliojoaquineliojoaquinelio approved these changes
@vplentinaxvplentinaxvplentinax approved these changes

Assignees

No one assigned

Labels

needs +1review needed

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@homero304@javascript-translate-bot@joaquinelio@vplentinax@omero329