Skip to content

Methods of RegExp and String - #414

Merged
joaquinelio merged 53 commits into
javascript-tutorial:masterfrom
dbritto-dev:methods-of-regexp-and-string
Oct 12, 2020
Merged

Methods of RegExp and String#414
joaquinelio merged 53 commits into
javascript-tutorial:masterfrom
dbritto-dev:methods-of-regexp-and-string

Conversation

@dbritto-dev

Copy link
Copy Markdown
Contributor

No description provided.

@dbritto-dev

Copy link
Copy Markdown
ContributorAuthor

@joaquinelio yo creo que ahora ya esta bien

@joaquineliojoaquinelio left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • Si rescribis en lugar de usar las suggest, cuida los acentos que les agregué/quité
  • una de las correccione esta sin suggest porque el md con graves me lo impide
  • para mi es valido "retornar" como el "devolver" que sugerimos en todos lados, no se que piensan otros. Sugerimos consistencia pero no creo que esto confunda a nadie.
  • no creo que debas usarr lista en lugar de array, para quien solo sepa js lista no tiene entidad. No lo puse en suggest porque en el momento dudaba...

Comment thread9-regular-expressions/17-regexp-methods/article.md Outdated
Comment thread9-regular-expressions/17-regexp-methods/article.md Outdated
Comment thread9-regular-expressions/17-regexp-methods/article.md Outdated
Comment thread9-regular-expressions/17-regexp-methods/article.md Outdated
Comment thread9-regular-expressions/17-regexp-methods/article.md Outdated
Comment thread9-regular-expressions/17-regexp-methods/article.md Outdated
Comment thread9-regular-expressions/17-regexp-methods/article.md Outdated
Comment thread9-regular-expressions/17-regexp-methods/article.md
Comment thread9-regular-expressions/17-regexp-methods/article.md Outdated
Comment thread9-regular-expressions/17-regexp-methods/article.md Outdated
@javascript-translate-bot

Copy link
Copy Markdown

Please make the requested changes. After it, add a comment "/done".
Then I'll ask for a new review 👻

dbritto-devand others added 7 commits October 9, 2020 00:40
Co-authored-by: joaquinelio <joaquinelio@gmail.com>
Co-authored-by: joaquinelio <joaquinelio@gmail.com>
Co-authored-by: joaquinelio <joaquinelio@gmail.com>
Co-authored-by: joaquinelio <joaquinelio@gmail.com>
Co-authored-by: joaquinelio <joaquinelio@gmail.com>
Co-authored-by: joaquinelio <joaquinelio@gmail.com>
Co-authored-by: joaquinelio <joaquinelio@gmail.com>
Comment thread9-regular-expressions/17-regexp-methods/article.md Outdated
Comment thread9-regular-expressions/17-regexp-methods/article.md Outdated
dbritto-devand others added 12 commits October 9, 2020 08:42
Co-authored-by: joaquinelio <joaquinelio@gmail.com>
Co-authored-by: joaquinelio <joaquinelio@gmail.com>
Co-authored-by: joaquinelio <joaquinelio@gmail.com>
Co-authored-by: joaquinelio <joaquinelio@gmail.com>
Co-authored-by: joaquinelio <joaquinelio@gmail.com>
Co-authored-by: joaquinelio <joaquinelio@gmail.com>
Co-authored-by: joaquinelio <joaquinelio@gmail.com>
Co-authored-by: joaquinelio <joaquinelio@gmail.com>
Co-authored-by: joaquinelio <joaquinelio@gmail.com>
Co-authored-by: joaquinelio <joaquinelio@gmail.com>
dbritto-devand others added 7 commits October 9, 2020 13:54
Co-authored-by: joaquinelio <joaquinelio@gmail.com>
Co-authored-by: joaquinelio <joaquinelio@gmail.com>
Co-authored-by: joaquinelio <joaquinelio@gmail.com>
Co-authored-by: joaquinelio <joaquinelio@gmail.com>
Co-authored-by: joaquinelio <joaquinelio@gmail.com>
Co-authored-by: joaquinelio <joaquinelio@gmail.com>
Co-authored-by: joaquinelio <joaquinelio@gmail.com>
Comment thread9-regular-expressions/17-regexp-methods/article.md Outdated
@dbritto-dev

Copy link
Copy Markdown
ContributorAuthor

/done

@joaquineliojoaquinelio left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

AAAHHHH!!!
¿¿¿Lo pase al ingles con el signo "!" ????? sorrysorrysorrysorrysorry

linea 274
supongo que w+ es solamente "world"

ya está, me quemé.
perdon si los arrastre a uds tambien...

Comment thread9-regular-expressions/17-regexp-methods/article.md Outdated
@javascript-translate-bot

Copy link
Copy Markdown

Please make the requested changes. After it, add a comment "/done".
Then I'll ask for a new review 👻

Co-authored-by: joaquinelio <joaquinelio@gmail.com>
@dbritto-dev

Copy link
Copy Markdown
ContributorAuthor

/done

@vplentinaxvplentinax left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok

@joaquinelio
joaquinelio merged commit cab278a into javascript-tutorial:masterOct 12, 2020
@javascript-translate-bot

Copy link
Copy Markdown

Thank you 💖 I updated the Progress Issue #17 🎉 🎉 🎉

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants

@dbritto-dev@javascript-translate-bot@vplentinax@joaquinelio