Skip to content

Node properties: type, tag and contents - #422

Merged
joaquinelio merged 21 commits into
javascript-tutorial:masterfrom
homero304:Node-properties_type-tag-and-contents
Oct 15, 2020
Merged

Node properties: type, tag and contents#422
joaquinelio merged 21 commits into
javascript-tutorial:masterfrom
homero304:Node-properties_type-tag-and-contents

Conversation

@homero304

@homero304homero304 commented Oct 12, 2020

Copy link
Copy Markdown
Contributor

please review my PR

@javascript-translate-bot
javascript-translate-bot requested a review from a teamOctober 12, 2020 00:22
@javascript-translate-botjavascript-translate-bot mentioned this pull request Oct 12, 2020
Open
joaquinelio
joaquinelio requested changes Oct 12, 2020
View reviewed changes

@joaquineliojoaquinelio left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

correcciones y divagues...

y sorry si algun coment parece agresivo no lo es, solo estoy jugando.
es que nunca antes en mi vida usé bugs, era perfecto
y en las ultimas sync puse dos y todavia no me recupero del shock.

Ah, creo que hay correctores automaticos metiendo el rabo
bad Homer..!

Comment thread2-ui/1-document/05-basic-dom-node-properties/2-tree-info/solution.md Outdated
Comment thread2-ui/1-document/05-basic-dom-node-properties/3-tag-in-comment/solution.md Outdated
Comment thread2-ui/1-document/05-basic-dom-node-properties/4-where-document-in-hierarchy/solution.md Outdated
Comment thread2-ui/1-document/05-basic-dom-node-properties/4-where-document-in-hierarchy/solution.md Outdated
Comment thread2-ui/1-document/05-basic-dom-node-properties/4-where-document-in-hierarchy/task.md Outdated
Comment thread2-ui/1-document/05-basic-dom-node-properties/article.md Outdated
Comment thread2-ui/1-document/05-basic-dom-node-properties/article.md Outdated
Comment thread2-ui/1-document/05-basic-dom-node-properties/article.md Outdated
Comment thread2-ui/1-document/05-basic-dom-node-properties/article.md Outdated
Comment thread2-ui/1-document/05-basic-dom-node-properties/article.md Outdated
@javascript-translate-bot

javascript-translate-bot commented Oct 12, 2020

Copy link
Copy Markdown

Please make the requested changes. After it, add a comment "/done".
Then I'll ask for a new review 👻

omero329and others added 11 commits October 12, 2020 06:31
@omero329@joaquinelio
Update 2-ui/1-document/05-basic-dom-node-properties/2-tree-info/solut…
b7db859
…ion.md
Co-authored-by: joaquinelio <joaquinelio@gmail.com>
@omero329@joaquinelio
Update 2-ui/1-document/05-basic-dom-node-properties/3-tag-in-comment/…
ce97b25
…solution.md
Co-authored-by: joaquinelio <joaquinelio@gmail.com>
@omero329@joaquinelio
Update 2-ui/1-document/05-basic-dom-node-properties/4-where-document-…
79e0683
…in-hierarchy/solution.md
Co-authored-by: joaquinelio <joaquinelio@gmail.com>
@omero329@joaquinelio
Update 2-ui/1-document/05-basic-dom-node-properties/4-where-document-…
5077fca
…in-hierarchy/solution.md
Co-authored-by: joaquinelio <joaquinelio@gmail.com>
@omero329@joaquinelio
Update 2-ui/1-document/05-basic-dom-node-properties/4-where-document-…
10b54a5
…in-hierarchy/task.md
Co-authored-by: joaquinelio <joaquinelio@gmail.com>
@omero329@joaquinelio
Update 2-ui/1-document/05-basic-dom-node-properties/article.md
872e7f4
Co-authored-by: joaquinelio <joaquinelio@gmail.com>
@omero329@joaquinelio
Update 2-ui/1-document/05-basic-dom-node-properties/article.md
8e92100
Co-authored-by: joaquinelio <joaquinelio@gmail.com>
@omero329@joaquinelio
Update 2-ui/1-document/05-basic-dom-node-properties/article.md
8c3fb5b
Co-authored-by: joaquinelio <joaquinelio@gmail.com>
@omero329@joaquinelio
Update 2-ui/1-document/05-basic-dom-node-properties/article.md
79a79be
Co-authored-by: joaquinelio <joaquinelio@gmail.com>
@omero329
Winnie-pooh
b54440b
@omero329
Merge branch 'Node-properties_type-tag-and-contents' ofhttps://githu…
c313b2c
…b.com/homero304/es.javascript.info into Node-properties_type-tag-and-contents
@javascript-translate-bot
javascript-translate-bot requested a review from a teamOctober 12, 2020 11:42
omero329and others added 7 commits October 12, 2020 06:42
@omero329@joaquinelio
Update 2-ui/1-document/05-basic-dom-node-properties/article.md
dc34f25
Co-authored-by: joaquinelio <joaquinelio@gmail.com>
@omero329@joaquinelio
Update 2-ui/1-document/05-basic-dom-node-properties/article.md
b7fd044
Co-authored-by: joaquinelio <joaquinelio@gmail.com>
@omero329@joaquinelio
Update 2-ui/1-document/05-basic-dom-node-properties/article.md
ed04f67
Co-authored-by: joaquinelio <joaquinelio@gmail.com>
@omero329@joaquinelio
Update 2-ui/1-document/05-basic-dom-node-properties/article.md
3be53c7
Co-authored-by: joaquinelio <joaquinelio@gmail.com>
@omero329@joaquinelio
Update 2-ui/1-document/05-basic-dom-node-properties/article.md
c040d70
Co-authored-by: joaquinelio <joaquinelio@gmail.com>
@omero329@joaquinelio
Update 2-ui/1-document/05-basic-dom-node-properties/article.md
2a3803b
Co-authored-by: joaquinelio <joaquinelio@gmail.com>
@omero329
integrada -> nativa
e79bc49
@homero304

homero304 commented Oct 12, 2020

Copy link
Copy Markdown
ContributorAuthor

/done

@joaquinelio

joaquinelio commented Oct 12, 2020•
edited
Loading

Copy link
Copy Markdown
Member

ah,
lo de "built in" era solo un comentario

"incorporada" es lo que usamos hasta ahora, seria "correcto" aunque en mi opinion muy facil de malinterpretar, las bibliotecas de 3ros tambien "incorporan" funciones
"integrada" me gustaba un poco más, no se por qué, me da idea de que ya esta ahi, no incorporado posteriormente en una biblioteca extra... "built-in" ="integrada" me gusta. No recuerdo ssi ses uso asi en algun lado.
"nativa" me parecia perfecta pero no lo habiamos ussado antes, y no lo discutimos antes, para mi esta bien, no lo habia sugerido porque podria haber desacuerdos,
Acepto cualquier version, pero no se los demás.

winnie pooh
jaj el comment que hice era por la mayuscula, en realidad si el codigo es coherente no me importaba. Sigue ok.
no se por que me pongo a hacer esos comentarios...
sorry

vplentinax
vplentinax approved these changes Oct 14, 2020
View reviewed changes

@vplentinaxvplentinax left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good!

@joaquinelio
joaquinelio merged commit ead3c54 into javascript-tutorial:masterOct 15, 2020
@javascript-translate-bot

javascript-translate-bot commented Oct 15, 2020

Copy link
Copy Markdown

Thank you 💖 I updated the Progress Issue #17 🎉 🎉 🎉

@joaquinelio

joaquinelio commented Oct 15, 2020•
edited
Loading

Copy link
Copy Markdown
Member

@vplentinax
🎉🎉🎉🎉🎉
Si sos el 2do ok, podes hacer merge sin esperarme,
salvo que no tengas tiempo de revisar online, ya cometi el error de no revisar bien, dejamelo es una satisfacción.
*El mensaje de idioma sigue saliendo, no problem, al tiempo deja de salir.
*Tambien tarda un poco más mostrar el índice español que la página. El índice ES el titulo de la pagina, asi que solo es esperar nosequé.
*Siempre revisar FORMATO no se ven los err de formato dentro de git
*Imagenes
*Las soluciones, que abran, ves enseguida si falta traduccion, y TAMBIEN he visto fallas de formato dentro
*Los links, suelo buscarlos y abrirloss con el boton del medio asi reviso todos juntos, internos y externos
-Los sandbox... culpable, demora mucho en abrir plunker y a veces son muchos...
*Que salga el msg del bot del issue17, para actualizar a mano si no lo ve por algo.

Y ESTE PR se vio perfecto
¡¡¡¡ Faltan 25 !!!!
🎉🎉🎉🎉🎉

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@joaquineliojoaquineliojoaquinelio approved these changes
@vplentinaxvplentinaxvplentinax approved these changes

Assignees

No one assigned

Labels

ready to merge

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@homero304@javascript-translate-bot@joaquinelio@vplentinax@omero329