Skip to content

Sticky flag "y", searching at position - #424

Merged
joaquinelio merged 11 commits into
javascript-tutorial:masterfrom
AbiF73:master
Dec 17, 2020
Merged

Sticky flag "y", searching at position#424
joaquinelio merged 11 commits into
javascript-tutorial:masterfrom
AbiF73:master

Conversation

@AbiF73

@AbiF73AbiF73 commented Oct 15, 2020

Copy link
Copy Markdown
Contributor

Hola! Tuve algunas dudas con algunas palabras, lo siento. Espero sus correcciones.

@javascript-translate-bot
javascript-translate-bot requested a review from a teamOctober 15, 2020 20:43
@CLAassistant

CLAassistant commented Oct 15, 2020•
edited
Loading

Copy link
Copy Markdown

CLA assistant check
All committers have signed the CLA.

joaquinelio
joaquinelio requested changes Oct 15, 2020
View reviewed changes

@joaquineliojoaquinelio left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

bienvenido
y bienvenido si continuas

Sabes de git ? veo que modificaste tu master
No nos afecta en el pr, pero lo mejor para trabajar en tu fork es
dejar el master intocable (solo actualizar desde nuestro fork)
generar en un branch y modificar alli
una vez hecho el pr y añadido al nuestro repo, puedes borrar el branch
y actualizar tu master desde nuestro remoto

Comment thread9-regular-expressions/16-regexp-sticky/article.md Outdated
Comment thread9-regular-expressions/16-regexp-sticky/article.md Outdated
Comment thread9-regular-expressions/16-regexp-sticky/article.md Outdated
Comment thread9-regular-expressions/16-regexp-sticky/article.md Outdated
Comment thread9-regular-expressions/16-regexp-sticky/article.md Outdated
Comment thread9-regular-expressions/16-regexp-sticky/article.md Outdated
Comment thread9-regular-expressions/16-regexp-sticky/article.md
We can get all matches in the loop:
Podemos conseguir todas las coincidencias en el loop:

```js run

@joaquineliojoaquinelioOct 15, 2020

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

¿Podrias traducir comentarios lineas 63 64 ?
github no me deja sugerir ahi (dentro de un bloque sin traducir)

Quizas tambien la 62 pero con cuidado:

alert( Se encontró ${result[0]} en la posición ${result.index} );

Comment thread9-regular-expressions/16-regexp-sticky/article.md Outdated
Comment thread9-regular-expressions/16-regexp-sticky/article.md Outdated
Comment thread9-regular-expressions/16-regexp-sticky/article.md Outdated
@javascript-translate-bot

javascript-translate-bot commented Oct 15, 2020

Copy link
Copy Markdown

Please make the requested changes. After it, add a comment "/done".
Then I'll ask for a new review 👻

@joaquineliojoaquinelio changed the title Update article.mdSticky flag "y", searching at positionOct 15, 2020
@joaquinelio

joaquinelio commented Oct 15, 2020

Copy link
Copy Markdown
Member

ah, para llevar el control (y Don Bot lo entienda)
cambié el nombre al PR

Sticky flag "y", searching at position

@joaquinelio

joaquinelio commented Oct 15, 2020

Copy link
Copy Markdown
Member

AAAHHHHHHH!!!!

Ilya marcó la version en ingles como WIP
el crazy va a rescribirlo todo!!!!

@joaquineliojoaquinelio mentioned this pull request Oct 15, 2020
Open
@vplentinax

vplentinax commented Oct 25, 2020

Copy link
Copy Markdown
Contributor

Después que se acepten las sugerencias de Joaquinelio, paso yo a revisar.

@vplentinax
vplentinax self-requested a review October 25, 2020 16:08
@joaquinelio

joaquinelio commented Oct 25, 2020

Copy link
Copy Markdown
Member

Después que se acepten las sugerencias de Joaquinelio, paso yo a revisar.

@vplentinax
El pr es de hace 10 dias, las suggest son de hace 10 dias...

Encima Ilya lo rescribió dos dias después.
Aun no se si hacer sync (ingles-ingles, seria directo) y que este quede con conflictos multiples
o esperar al merge de esto e descartar la nueva version para verla tranquilo

@vplentinax

vplentinax commented Oct 26, 2020

Copy link
Copy Markdown
Contributor

@joaquinelio Hazlo como te parezca más cómodo a ti. No tengo inconveniente con ninguna de las dos formas.

@joaquinelio

joaquinelio commented Nov 20, 2020

Copy link
Copy Markdown
Member

@vplentinax
Este es un art breve
El ingles fue reescrito o rescrito, (en repo esp deje version vieja para que esto no diera conflictos)
podriamos descartar esto y hacerlo de cero

por otro lado,
corrigiendo ortografia le daria MERGE,
es un art muy facil de entender
e Ilya hizo mucho cambio no dire superfluo pero...

@joaquineliojoaquinelio mentioned this pull request Dec 4, 2020
Closed
vplentinaxand others added 9 commits December 17, 2020 13:14
@vplentinax@joaquinelio
Update 9-regular-expressions/16-regexp-sticky/article.md
4769082
Co-authored-by: joaquinelio <joaquinelio@gmail.com>
@vplentinax@joaquinelio
Update 9-regular-expressions/16-regexp-sticky/article.md
b576771
Co-authored-by: joaquinelio <joaquinelio@gmail.com>
@vplentinax@joaquinelio
Update 9-regular-expressions/16-regexp-sticky/article.md
12bf852
Co-authored-by: joaquinelio <joaquinelio@gmail.com>
@vplentinax@joaquinelio
Update 9-regular-expressions/16-regexp-sticky/article.md
75a942e
Co-authored-by: joaquinelio <joaquinelio@gmail.com>
@vplentinax@joaquinelio
Update 9-regular-expressions/16-regexp-sticky/article.md
06bd468
Co-authored-by: joaquinelio <joaquinelio@gmail.com>
@vplentinax@joaquinelio
Update 9-regular-expressions/16-regexp-sticky/article.md
8f9d5dd
Co-authored-by: joaquinelio <joaquinelio@gmail.com>
@vplentinax@joaquinelio
Update 9-regular-expressions/16-regexp-sticky/article.md
38d3506
Co-authored-by: joaquinelio <joaquinelio@gmail.com>
@vplentinax@joaquinelio
Update 9-regular-expressions/16-regexp-sticky/article.md
041b2e4
Co-authored-by: joaquinelio <joaquinelio@gmail.com>
@vplentinax@joaquinelio
Update 9-regular-expressions/16-regexp-sticky/article.md
9e57705
Co-authored-by: joaquinelio <joaquinelio@gmail.com>
vplentinax
vplentinax approved these changes Dec 17, 2020
View reviewed changes

@vplentinaxvplentinax left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok

@joaquinelio
joaquinelio merged commit 5944323 into javascript-tutorial:masterDec 17, 2020
@javascript-translate-bot

javascript-translate-bot commented Dec 17, 2020

Copy link
Copy Markdown

Thank you 💖 I updated the Progress Issue #17 🎉 🎉 🎉

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@joaquineliojoaquineliojoaquinelio requested changes
@vplentinaxvplentinaxvplentinax approved these changes

Assignees

No one assigned

Labels

needs +1

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@AbiF73@CLAassistant@javascript-translate-bot@joaquinelio@vplentinax