Skip to content

Fetch: Download progress - #425

Merged
joaquinelio merged 5 commits into
javascript-tutorial:masterfrom
homero304:Fetch-Download-progress
Oct 19, 2020
Merged

Fetch: Download progress#425
joaquinelio merged 5 commits into
javascript-tutorial:masterfrom
homero304:Fetch-Download-progress

Conversation

@homero304

@homero304homero304 commented Oct 17, 2020

Copy link
Copy Markdown
Contributor

please review my PR

@javascript-translate-bot
javascript-translate-bot requested a review from a teamOctober 17, 2020 17:08
@javascript-translate-botjavascript-translate-bot mentioned this pull request Oct 17, 2020
Open
@homero304
homero304force-pushed the Fetch-Download-progress branch from 627a77a to ab53702CompareOctober 17, 2020 17:16
joaquinelio
joaquinelio requested changes Oct 17, 2020
View reviewed changes
Comment thread5-network/03-fetch-progress/article.md Outdated
Comment thread5-network/03-fetch-progress/article.md Outdated
Comment thread5-network/03-fetch-progress/article.md Outdated
Comment thread5-network/03-fetch-progress/article.md Outdated
@javascript-translate-bot

javascript-translate-bot commented Oct 17, 2020

Copy link
Copy Markdown

Please make the requested changes. After it, add a comment "/done".
Then I'll ask for a new review 👻

omero329and others added 4 commits October 17, 2020 18:01
@omero329@joaquinelio
Update 5-network/03-fetch-progress/article.md
b8de4d9
Co-authored-by: joaquinelio <joaquinelio@gmail.com>
@omero329@joaquinelio
Update 5-network/03-fetch-progress/article.md
4da7955
Co-authored-by: joaquinelio <joaquinelio@gmail.com>
@omero329@joaquinelio
Update 5-network/03-fetch-progress/article.md
57d1005
Co-authored-by: joaquinelio <joaquinelio@gmail.com>
@omero329@joaquinelio
Update 5-network/03-fetch-progress/article.md
e208693
Co-authored-by: joaquinelio <joaquinelio@gmail.com>
@homero304

homero304 commented Oct 17, 2020

Copy link
Copy Markdown
ContributorAuthor

/done

@javascript-translate-bot
javascript-translate-bot requested a review from a teamOctober 17, 2020 23:03
joaquinelio
joaquinelio approved these changes Oct 18, 2020
View reviewed changes

@joaquineliojoaquinelio left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok

vplentinax
vplentinax approved these changes Oct 19, 2020
View reviewed changes

@vplentinaxvplentinax left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok

@joaquinelio
joaquinelio merged commit 3771fa0 into javascript-tutorial:masterOct 19, 2020
@javascript-translate-bot

javascript-translate-bot commented Oct 19, 2020

Copy link
Copy Markdown

Thank you 💖 I updated the Progress Issue #17 🎉 🎉 🎉

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@joaquineliojoaquineliojoaquinelio approved these changes
@vplentinaxvplentinaxvplentinax approved these changes

Assignees

No one assigned

Labels

ready to merge

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@homero304@javascript-translate-bot@joaquinelio@vplentinax@omero329