Skip to content

Element size and scrolling - #433

Merged
joaquinelio merged 49 commits into
javascript-tutorial:masterfrom
lgabrielvleon:lgabrielvleon-patch-1
Dec 17, 2020
Merged

Element size and scrolling#433
joaquinelio merged 49 commits into
javascript-tutorial:masterfrom
lgabrielvleon:lgabrielvleon-patch-1

Conversation

@lgabrielvleon

Copy link
Copy Markdown
Contributor

Traducción del capítulo Element size and scrolling

@CLAassistant

CLAassistant commented Oct 22, 2020

Copy link
Copy Markdown

CLA assistant check
All committers have signed the CLA.

@joaquineliojoaquinelio changed the title Lgabrielvleon patch 1 - Element size and scrollingElement size and scrollingOct 22, 2020
@joaquinelio

joaquinelio commented Oct 22, 2020

Copy link
Copy Markdown
Member

Corregido nombre pr / issue17 pa'que Bot lo entienda

MERGE: !!!!!!!!!!!!!!!!!!!!!!!!!!!!
Tiene 4 tasks y mucho formato anidado,
verificar online como quedan, imposible probarlo debtro del hub

Listo, cuando se me pase la pereza lo reviso.
Hasta mañana zzzz

@joaquinelio
joaquinelio self-requested a review October 22, 2020 12:31
@vplentinax
vplentinax requested review from vplentinax and removed request for a teamOctober 25, 2020 17:01

@joaquineliojoaquinelio left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

varias cosas...
suelo re-revisar mi revision pero me estoy durmiendo

creo que edite el archivo para cambiar numeracion, si no fue en otro

Comment thread2-ui/1-document/09-size-and-scroll/2-scrollbar-width/task.md Outdated
Comment thread2-ui/1-document/09-size-and-scroll/2-scrollbar-width/task.md Outdated
Comment thread2-ui/1-document/09-size-and-scroll/4-put-ball-in-center/solution.md Outdated
Comment thread2-ui/1-document/09-size-and-scroll/4-put-ball-in-center/solution.md Outdated
Comment thread2-ui/1-document/09-size-and-scroll/4-put-ball-in-center/solution.md Outdated
Comment thread2-ui/1-document/09-size-and-scroll/article.md Outdated
Comment thread2-ui/1-document/09-size-and-scroll/article.md Outdated
Comment thread2-ui/1-document/09-size-and-scroll/article.md Outdated
Comment thread2-ui/1-document/09-size-and-scroll/article.md Outdated
Comment thread2-ui/1-document/09-size-and-scroll/article.md Outdated
@javascript-translate-bot

Copy link
Copy Markdown

Please make the requested changes. After it, add a comment "/done".
Then I'll ask for a new review 👻

lgabrielvleonand others added 2 commits October 25, 2020 19:13
Co-authored-by: joaquinelio <joaquinelio@gmail.com>
…task.md
Co-authored-by: joaquinelio <joaquinelio@gmail.com>
Co-authored-by: joaquinelio <joaquinelio@gmail.com>

@lgabrielvleonlgabrielvleon left a comment

Copy link
Copy Markdown
ContributorAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/done

lgabrielvleonand others added 2 commits October 25, 2020 19:24

@joaquineliojoaquinelio left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Creo que hoy tengo los ojos más limpios, encontré varios acentos faltantes...

Y vi que hay correcciones de tilde no aplicadas. Puedo dejarme convencer en css, pero con los acentos estoy bastante convencido...

Lo importante es que el texto se lee bien, lo prefiero online-

Comment thread2-ui/1-document/09-size-and-scroll/2-scrollbar-width/solution.md Outdated
Comment thread2-ui/1-document/09-size-and-scroll/2-scrollbar-width/task.md Outdated
Comment thread2-ui/1-document/09-size-and-scroll/4-put-ball-in-center/task.md Outdated
Comment thread2-ui/1-document/09-size-and-scroll/4-put-ball-in-center/task.md Outdated
Comment thread2-ui/1-document/09-size-and-scroll/6-width-vs-clientwidth/solution.md Outdated
Comment thread2-ui/1-document/09-size-and-scroll/article.md Outdated
Comment thread2-ui/1-document/09-size-and-scroll/article.md Outdated
Comment thread2-ui/1-document/09-size-and-scroll/article.md Outdated
Comment thread2-ui/1-document/09-size-and-scroll/article.md Outdated
Comment thread2-ui/1-document/09-size-and-scroll/article.md Outdated
@javascript-translate-bot

Copy link
Copy Markdown

Please make the requested changes. After it, add a comment "/done".
Then I'll ask for a new review 👻

@joaquinelio

Copy link
Copy Markdown
Member

@vplentinax
podes hacer lo mismo aqui?
este pr es completo, fue revisado, lo corrigio,
más revision y asi quedó

Tuvo ya mucho trabajo hecho, si te parece revisa y revisa mi revision,
es una buena adicion al repo

vplentinaxand others added 16 commits December 17, 2020 12:56
Co-authored-by: joaquinelio <joaquinelio@gmail.com>
Co-authored-by: joaquinelio <joaquinelio@gmail.com>
Co-authored-by: joaquinelio <joaquinelio@gmail.com>
Co-authored-by: joaquinelio <joaquinelio@gmail.com>
…tion.md
Co-authored-by: joaquinelio <joaquinelio@gmail.com>
Co-authored-by: joaquinelio <joaquinelio@gmail.com>
Co-authored-by: joaquinelio <joaquinelio@gmail.com>
Co-authored-by: joaquinelio <joaquinelio@gmail.com>
Co-authored-by: joaquinelio <joaquinelio@gmail.com>
Co-authored-by: joaquinelio <joaquinelio@gmail.com>
Co-authored-by: joaquinelio <joaquinelio@gmail.com>
Co-authored-by: joaquinelio <joaquinelio@gmail.com>
Co-authored-by: joaquinelio <joaquinelio@gmail.com>
Co-authored-by: joaquinelio <joaquinelio@gmail.com>
Co-authored-by: joaquinelio <joaquinelio@gmail.com>
Co-authored-by: joaquinelio <joaquinelio@gmail.com>

@vplentinaxvplentinax left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lo veo bien. Avancemos.

@javascript-translate-bot

Copy link
Copy Markdown

Thank you 💖 I updated the Progress Issue #17 🎉 🎉 🎉

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants

@lgabrielvleon@CLAassistant@joaquinelio@javascript-translate-bot@vplentinax