Forms: event and method submit by puntope · Pull Request #454 · javascript-tutorial/es.javascript.info

puntope · 2020-12-09T21:46:50Z

No description provided.

CLAassistant · 2020-12-09T21:46:55Z

All committers have signed the CLA.

joaquinelio

bienvenido

algunos acentos,
las cuestiones de forma podes ignorarme, el articulo es muy claro

tuviste el criterio de traducir value pero no name o type...
aja...
es que siempre ando buscando reviewers, aunque el bot te ignore podes dejar las correcciones y comentarios

otra forma de ayudar,
cada tanto hacemos merge desde ingles,
cuando hay más de un par de lineas descarto los cambios y los paso a issues. "actualizar"
Por un lado es mas facil porque es menos cantidad,
por otro lado mas complejo porque hay que comparar con el repo ingles,
revisar el historial de commits, y corregir los nros de lineas (me ayudo con vscode +gitlens que hace diff con cualquier remoto)

javascript-translate-bot · 2020-12-10T13:35:16Z

Please make the requested changes. After it, add a comment "/done".
Then I'll ask for a new review 👻

joaquinelio · 2020-12-10T13:36:16Z

Cambio titulo, agrego al issue a mano
confirmarlo al hacer merge

Co-authored-by: joaquinelio <joaquinelio@gmail.com>

…iew/index.html Co-authored-by: joaquinelio <joaquinelio@gmail.com>

Co-authored-by: joaquinelio <joaquinelio@gmail.com>

puntope · 2020-12-10T19:36:21Z

/done

puntope · 2020-12-10T19:37:34Z

/done

joaquinelio · 2020-12-10T21:52:24Z

hola, @puntope
casi ok
eeehhh... quedaron dos sin resolver,
de los que no negocio, "a veces" y un typo

edit
ah, ok: pereza de github "2 hidden...show more"

Co-authored-by: joaquinelio <joaquinelio@gmail.com>

puntope · 2020-12-10T21:55:11Z

/done

joaquinelio

wow that s was fast
...

yes!
👍

waiting for the second reviewer now...

vplentinax

Todo bien...

javascript-translate-bot · 2020-12-14T06:20:27Z

Thank you 💖 I updated the Progress Issue #17 🎉 🎉 🎉

puntope added 5 commits December 9, 2020 22:13

Forms: event and method submit
21fb24e

Update task.md
af25299

Update solution.md
62f6bc5

Update index.html
7a8321a

Update index.html
a1bf500

javascript-translate-bot added the review needed label Dec 9, 2020

javascript-translate-bot requested a review from a teamDecember 9, 2020 21:46

joaquinelio requested changes Dec 10, 2020
View reviewed changes

javascript-translate-bot added changes requested and removed review needed labels Dec 10, 2020

joaquinelio changed the title ~~Forms event and method submit~~Forms: event and method submitDec 10, 2020

joaquinelio mentioned this pull request Dec 10, 2020
Spanish Translation Progress #17
Open

puntopeand others added 9 commits December 10, 2020 20:34

Update 2-ui/4-forms-controls/4-forms-submit/1-modal-dialog/solution.md
ed8bf56
Co-authored-by: joaquinelio <joaquinelio@gmail.com>

Update 2-ui/4-forms-controls/4-forms-submit/1-modal-dialog/solution.md
a3f2a94
Co-authored-by: joaquinelio <joaquinelio@gmail.com>

Update 2-ui/4-forms-controls/4-forms-submit/1-modal-dialog/solution.v…
d5f8910
…iew/index.html Co-authored-by: joaquinelio <joaquinelio@gmail.com>

Update 2-ui/4-forms-controls/4-forms-submit/1-modal-dialog/task.md
b7350f2
Co-authored-by: joaquinelio <joaquinelio@gmail.com>

Update 2-ui/4-forms-controls/4-forms-submit/1-modal-dialog/task.md
9164cba
Co-authored-by: joaquinelio <joaquinelio@gmail.com>

Update 2-ui/4-forms-controls/4-forms-submit/article.md
9e2559a
Co-authored-by: joaquinelio <joaquinelio@gmail.com>

Update 2-ui/4-forms-controls/4-forms-submit/1-modal-dialog/solution.md
a1e0e94
Co-authored-by: joaquinelio <joaquinelio@gmail.com>

Update 2-ui/4-forms-controls/4-forms-submit/1-modal-dialog/task.md
8132ed7
Co-authored-by: joaquinelio <joaquinelio@gmail.com>

Update 2-ui/4-forms-controls/4-forms-submit/1-modal-dialog/task.md
f782995
Co-authored-by: joaquinelio <joaquinelio@gmail.com>

puntope closed this Dec 10, 2020

javascript-translate-bot added review needed and removed changes requested labels Dec 10, 2020

javascript-translate-bot requested a review from a teamDecember 10, 2020 19:36

puntope reopened this Dec 10, 2020

puntopeand others added 2 commits December 10, 2020 22:54

Update 2-ui/4-forms-controls/4-forms-submit/article.md
91715b7
Co-authored-by: joaquinelio <joaquinelio@gmail.com>

Update 2-ui/4-forms-controls/4-forms-submit/article.md
7cbe071
Co-authored-by: joaquinelio <joaquinelio@gmail.com>

joaquinelio approved these changes Dec 10, 2020
View reviewed changes

javascript-translate-bot added needs +1 and removed review needed labels Dec 10, 2020

vplentinax approved these changes Dec 13, 2020
View reviewed changes

vplentinax added ready to merge and removed needs +1 labels Dec 13, 2020

joaquinelio merged commit 85b14d2 into javascript-tutorial:masterDec 14, 2020

puntope deleted the Forms-event-and-method-submit branch December 14, 2020 09:43

Uh oh!

Conversation

puntope commented Dec 9, 2020

Uh oh!

CLAassistant commented Dec 9, 2020• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

joaquinelio left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

javascript-translate-bot commented Dec 10, 2020

Uh oh!

joaquinelio commented Dec 10, 2020

Uh oh!

puntope commented Dec 10, 2020

Uh oh!

puntope commented Dec 10, 2020

Uh oh!

joaquinelio commented Dec 10, 2020• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

puntope commented Dec 10, 2020

Uh oh!

joaquinelio left a comment

Choose a reason for hiding this comment

Uh oh!

vplentinax left a comment

Choose a reason for hiding this comment

Uh oh!

javascript-translate-bot commented Dec 14, 2020

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

CLAassistant commented Dec 9, 2020•
edited
Loading

joaquinelio commented Dec 10, 2020•
edited
Loading