Skip to content

Drag'n'Drop with mouse events - #466

Merged
joaquinelio merged 12 commits into
javascript-tutorial:masterfrom
kenliten:kenliten
Jan 16, 2021
Merged

Drag'n'Drop with mouse events#466
joaquinelio merged 12 commits into
javascript-tutorial:masterfrom
kenliten:kenliten

Conversation

@kenliten

Copy link
Copy Markdown
Contributor

Hola @joaquinelio!
Lamento mucho la demora, tuve muchos problemas lidiando con una distro que no conocía e intenté traducir desde el celular y creé muchos problemas, así que al final, tuve que eliminar mi fork y con el el progreso, para crear un nuevo fork, un nuevo branch y bueno, aquí está el primer artículo.

PeAcE!

@joaquinelio

Copy link
Copy Markdown
Member

hola!
no es una carrera...
y tus aportes ya sumaron al proyecto

disculpame ahora la crítica,
"importance: " de las task no se traducen, NO SE por qué, es metadata pero no se para que la usa
y la verdad que en ingles queda feo,
pero específicamente (en el readme) pidio que no tradujeramos


Metadata
Some files, usually tasks, have YAML metadata at the top, delimited by ---:
importance: 5
---
...
Please don't translate "importance" (and other top metadata).

@kenliten

Copy link
Copy Markdown
ContributorAuthor

Oh ok!

@joaquineliojoaquinelio left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

typos y sugerencias

No traduzcas "importance" en task porque es metadata que no se para que corno es

sobre lo que puse de aclarar "mousedown", no hace falta, lo resolviste bien y queda claro.

Comment thread2-ui/3-event-details/4-mouse-drag-and-drop/article.md Outdated
Comment thread2-ui/3-event-details/4-mouse-drag-and-drop/article.md Outdated
Comment thread2-ui/3-event-details/4-mouse-drag-and-drop/article.md Outdated
Comment thread2-ui/3-event-details/4-mouse-drag-and-drop/article.md Outdated
Comment thread2-ui/3-event-details/4-mouse-drag-and-drop/article.md Outdated
Comment thread2-ui/3-event-details/4-mouse-drag-and-drop/article.md Outdated
Comment thread2-ui/3-event-details/4-mouse-drag-and-drop/article.md Outdated
Comment thread2-ui/3-event-details/4-mouse-drag-and-drop/article.md Outdated
Comment thread2-ui/3-event-details/4-mouse-drag-and-drop/article.md Outdated
Comment thread2-ui/3-event-details/4-mouse-drag-and-drop/article.md Outdated
@javascript-translate-bot

Copy link
Copy Markdown

Please make the requested changes. After it, add a comment "/done".
Then I'll ask for a new review 👻

Otoniel Reyes Galayand others added 11 commits December 26, 2020 17:52
Co-authored-by: joaquinelio <joaquinelio@gmail.com>
Co-authored-by: joaquinelio <joaquinelio@gmail.com>
Co-authored-by: joaquinelio <joaquinelio@gmail.com>
Co-authored-by: joaquinelio <joaquinelio@gmail.com>
Co-authored-by: joaquinelio <joaquinelio@gmail.com>
Co-authored-by: joaquinelio <joaquinelio@gmail.com>
Co-authored-by: joaquinelio <joaquinelio@gmail.com>
Co-authored-by: joaquinelio <joaquinelio@gmail.com>
Co-authored-by: joaquinelio <joaquinelio@gmail.com>
Co-authored-by: joaquinelio <joaquinelio@gmail.com>
Co-authored-by: joaquinelio <joaquinelio@gmail.com>
@kenliten

Copy link
Copy Markdown
ContributorAuthor

/done
Si eso era todo, estamos listos!

@joaquinelio

Copy link
Copy Markdown
Member

Hola capo

No, no era todo. Hay que deshacer los dos cambios
"importance: 5"
no puedo editarlo ni me deja sugerir cambios no se por qué

ya va un mes,
si no aparece segundo reviewer lo reviso de nuevo y -> merge.

@joaquinelio

Copy link
Copy Markdown
Member

@kenliten
ah, borraste tu branch
pero github aun lo recuerda en nosedonde,
asi que se puede hacer merge igual
y corregir lo de "importance" después

@kenliten

Copy link
Copy Markdown
ContributorAuthor

Si, lo borre, pense que ya habias hecho el merge, y ahora intento pero no me permite editarlos

@joaquinelio

Copy link
Copy Markdown
Member

No te permite porque está trabajando con una versión congelada

Voy a hacer merge y un despues PR con más cambios para:

  • arreglar "importance:" (aunque nadie lo extrañe)
  • legibilidad de las lineas mas importantes del principio

@joaquinelio
joaquinelio merged commit 7861d07 into javascript-tutorial:masterJan 16, 2021
@javascript-translate-bot

Copy link
Copy Markdown

Thank you 💖 I updated the Progress Issue #17 🎉 🎉 🎉

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

@kenliten@joaquinelio@javascript-translate-bot