Skip to content

Interaction: alert, prompt, confirm - #49

Merged
lizzie136 merged 1 commit into
javascript-tutorial:masterfrom
tscandalitta:master
May 27, 2019
Merged

Interaction: alert, prompt, confirm#49
lizzie136 merged 1 commit into
javascript-tutorial:masterfrom
tscandalitta:master

Conversation

@tscandalitta

@tscandalittatscandalitta commented May 22, 2019

Copy link
Copy Markdown
Collaborator

No description provided.

lizzie136
lizzie136 approved these changes May 27, 2019
View reviewed changes

@lizzie136lizzie136 left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🎉

@lizzie136
lizzie136 merged commit ae9cf98 into javascript-tutorial:masterMay 27, 2019
@iliakaniliakan mentioned this pull request May 27, 2019
Open
caballerof
caballerof reviewed May 27, 2019
View reviewed changes

@caballerofcaballerof left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Deje un par de comentarios para detalles y una propuesta para la traducción de la linea final del texto.

Comment thread1-js/02-first-steps/09-alert-prompt-confirm/article.md
Comment thread1-js/02-first-steps/09-alert-prompt-confirm/article.md
Comment thread1-js/02-first-steps/09-alert-prompt-confirm/article.md
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@lizzie136lizzie136lizzie136 approved these changes
+1 more reviewer
@caballerofcaballerofcaballerof left review comments
Reviewers whose approvals may not affect merge requirements

Assignees

@maurodibertmaurodibert

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@tscandalitta@lizzie136@caballerof@maurodibert