Skip to content

Shadow DOM and events - #550

Merged
joaquinelio merged 5 commits into
javascript-tutorial:masterfrom
joaquinelio:shave
Dec 16, 2021
Merged

Shadow DOM and events#550
joaquinelio merged 5 commits into
javascript-tutorial:masterfrom
joaquinelio:shave

Conversation

@joaquinelio

@joaquineliojoaquinelio commented Oct 2, 2021

Copy link
Copy Markdown
Member

No description provided.

@javascript-translate-bot
javascript-translate-bot requested a review from a teamOctober 2, 2021 12:39
@javascript-translate-botjavascript-translate-bot mentioned this pull request Oct 2, 2021
Open
dbritto-dev
dbritto-dev reviewed Dec 14, 2021
View reviewed changes
Comment thread8-web-components/7-shadow-dom-events/article.md Outdated
dbritto-dev
dbritto-dev suggested changes Dec 14, 2021
View reviewed changes
Comment thread8-web-components/7-shadow-dom-events/article.md Outdated
Comment thread8-web-components/7-shadow-dom-events/article.md Outdated
Comment thread8-web-components/7-shadow-dom-events/article.md Outdated
Comment thread8-web-components/7-shadow-dom-events/article.md Outdated
Comment thread8-web-components/7-shadow-dom-events/article.md Outdated
Comment thread8-web-components/7-shadow-dom-events/article.md Outdated
Comment thread8-web-components/7-shadow-dom-events/article.md Outdated
Comment thread8-web-components/7-shadow-dom-events/article.md Outdated
Comment thread8-web-components/7-shadow-dom-events/article.md Outdated
Comment thread8-web-components/7-shadow-dom-events/article.md
Por otro lado, si el clic ocurre en un elemento originalmente del shadow DOM, ej. en `<b>Name</b>`, entonces, como se propaga hacia fuera del shadow DOM, su `event.target` se reestablece a `<user-card>`.

## Bubbling, event.composedPath()
## Propagación, event.composedPath()

@joaquineliojoaquinelioDec 16, 2021

Copy link
Copy Markdown
MemberAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

es correcto,
pero me suena feo...
¿cuanto insistis con esto? me dejo convencer facil

@dbritto-devdbritto-devDec 16, 2021

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@joaquinelio yo creo que lo dejamos como Propagación

@javascript-translate-bot

javascript-translate-bot commented Dec 14, 2021

Copy link
Copy Markdown

Please make the requested changes. After it, add a comment "/done".
Then I'll ask for a new review 👻

@dbritto-dev

dbritto-dev commented Dec 14, 2021

Copy link
Copy Markdown
Contributor

@joaquinelio todo tuyo :D

@joaquinelio

joaquinelio commented Dec 14, 2021

Copy link
Copy Markdown
MemberAuthor

gracias!!! @dbritto-dev
gúilcombác

shadow-??????

Uf. Lo voy a poner como issue. Hay que cepillar el repo con esto.

AHORA estoy de acuerdo,
es usual que aparezca en codigo o como propiedad element.shadowRoot
pero no me vas a convencer de que "shadow and light" es una palabra compuesta.

setear

demasiado usual y se me escapo... pero acordate, los que usamos estas pocas aberraciones vamos a lograr que el drae las registre.

etc.
gracias, volveré luego

@dbritto-dev

dbritto-dev commented Dec 14, 2021

Copy link
Copy Markdown
Contributor

gracias!!! @dbritto-dev gúilcombác

shadow-??????

Uf. Lo voy a poner como issue. Hay que cepillar el repo con esto.

AHORA estoy de acuerdo, es usual que aparezca en codigo o como propiedad element.shadowRoot pero no me vas a convencer de que "shadow and light" es una palabra compuesta.

setear

demasiado usual y se me escapo... pero acordate, los que usamos estas pocas aberraciones vamos a lograr que el drae las registre.

etc. gracias, volveré luego

falto traducir el and en shadow and light, hahaha :)

@joaquinelio@dbritto-dev
Update 8-web-components/7-shadow-dom-events/article.md
0dc173a
Co-authored-by: Danilo Britto <dbritto.dev@gmail.com>
joaquinelio
joaquinelio commented Dec 16, 2021
View reviewed changes
Comment thread8-web-components/7-shadow-dom-events/article.md
Por otro lado, si el clic ocurre en un elemento originalmente del shadow DOM, ej. en `<b>Name</b>`, entonces, como se propaga hacia fuera del shadow DOM, su `event.target` se reestablece a `<user-card>`.

## Bubbling, event.composedPath()
## Propagación, event.composedPath()

@joaquineliojoaquinelioDec 16, 2021

Copy link
Copy Markdown
MemberAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

es correcto,
pero me suena feo...
¿cuanto insistis con esto? me dejo convencer facil

@joaquinelio@dbritto-dev
Apply suggestions from code review
3ca282b
Co-authored-by: Danilo Britto <dbritto.dev@gmail.com>
@joaquinelio

joaquinelio commented Dec 16, 2021

Copy link
Copy Markdown
MemberAuthor

/done

@joaquinelio

joaquinelio commented Dec 16, 2021

Copy link
Copy Markdown
MemberAuthor

mentira /done, ¿si hago el ultimo commit puedo darle merge?

¡falta un solo articulo para terminar el repo!!
y estos 2 pr, si queres podes echarle un vistazo al otro...
especialmente si usaste regex

@joaquinelio

joaquinelio commented Dec 16, 2021

Copy link
Copy Markdown
MemberAuthor

biutiful

@joaquinelio
joaquinelio merged commit ea8f513 into javascript-tutorial:masterDec 16, 2021
@joaquinelio
joaquinelio deleted the shave branch December 16, 2021 12:11
@javascript-translate-bot

javascript-translate-bot commented Dec 16, 2021

Copy link
Copy Markdown

Thank you 💖 I updated the Progress Issue #17 🎉 🎉 🎉

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer
@dbritto-devdbritto-devdbritto-dev approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

needs +1

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@joaquinelio@javascript-translate-bot@dbritto-dev