Skip to content

Type Conversions - #57

Merged
lizzie136 merged 8 commits into
javascript-tutorial:masterfrom
tikoflano:master
Aug 22, 2019
Merged

Type Conversions#57
lizzie136 merged 8 commits into
javascript-tutorial:masterfrom
tikoflano:master

Conversation

@tikoflano

@tikoflanotikoflano commented Jun 6, 2019

Copy link
Copy Markdown
Contributor

No description provided.

@javascript-translate-bot
javascript-translate-bot requested a review from a teamJune 6, 2019 01:51
@CLAassistant

CLAassistant commented Jun 6, 2019•
edited
Loading

Copy link
Copy Markdown

CLA assistant check
All committers have signed the CLA.

lizzie136
lizzie136 reviewed Jun 6, 2019
View reviewed changes
Comment thread1-js/02-first-steps/06-type-conversions/article.md Outdated
Por ejemplo, `alert` convierte automáticamente cualquier valor a string para mostrarlo. Las operaciones matemáticas convierten los valores a números.

There are also cases when we need to explicitly convert a value to the expected type.
Tmabién hay casos donde necesitamos convertir de manera explícita un valor al tipo esperado.

@lizzie136lizzie136Jun 6, 2019

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

También

@tikoflanotikoflanoJun 9, 2019

Copy link
Copy Markdown
ContributorAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It seems you reviewed the wrong commit. That was fixed in the latest one.

I will update this PR with the translation of task and solution.

@lizzie136lizzie136Jul 1, 2019

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@tikoflano It keeps showing "Tmabién" and other comments. Can you confirm that you updated the parts I commented you about?

@lizzie136
lizzie136 self-requested a review June 26, 2019 19:32
lizzie136
lizzie136 reviewed Jul 1, 2019
View reviewed changes
Comment thread1-js/02-first-steps/06-type-conversions/article.md Outdated
Comment thread1-js/02-first-steps/06-type-conversions/article.md Outdated
Comment thread1-js/02-first-steps/06-type-conversions/article.md Outdated
Comment thread1-js/02-first-steps/06-type-conversions/article.md Outdated
Comment thread1-js/02-first-steps/06-type-conversions/article.md Outdated
Por ejemplo, `alert` convierte automáticamente cualquier valor a string para mostrarlo. Las operaciones matemáticas convierten los valores a números.

There are also cases when we need to explicitly convert a value to the expected type.
Tmabién hay casos donde necesitamos convertir de manera explícita un valor al tipo esperado.

@lizzie136lizzie136Jul 1, 2019

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@tikoflano It keeps showing "Tmabién" and other comments. Can you confirm that you updated the parts I commented you about?

@tikoflano

tikoflano commented Jul 2, 2019

Copy link
Copy Markdown
ContributorAuthor

I fixed the typos. I'm curious about the "Tmabién" at line 7. I double checked that is ok in the "Files changed" of this PR.

tscandalitta
tscandalitta reviewed Jul 14, 2019
View reviewed changes
Comment thread1-js/02-first-steps/06-type-conversions/article.md Outdated
tscandalitta
tscandalitta reviewed Jul 14, 2019
View reviewed changes
Comment thread1-js/02-first-steps/06-type-conversions/article.md Outdated
tscandalitta
tscandalitta reviewed Jul 14, 2019
View reviewed changes
Comment thread1-js/02-first-steps/06-type-conversions/article.md Outdated
tscandalitta
tscandalitta reviewed Jul 14, 2019
View reviewed changes
Comment thread1-js/02-first-steps/06-type-conversions/article.md Outdated
tscandalitta
tscandalitta reviewed Jul 14, 2019
View reviewed changes
Comment thread1-js/02-first-steps/06-type-conversions/article.md Outdated
tscandalitta
tscandalitta reviewed Jul 14, 2019
View reviewed changes
Comment thread1-js/02-first-steps/06-type-conversions/article.md
- `undefined` is `NaN` as a number, not `0`.
- `"0"` and space-only strings like `" "` are true as a boolean.
- `undefined` es `NaN` como número, no `0`.
- `"0"` y textos que solo contienen espacios como `" "` son `true` como boolean.

@tscandalittatscandalittaJul 14, 2019

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Quedaría mejor cadenas en lugar de textos

@tikoflanotikoflanoJul 19, 2019

Copy link
Copy Markdown
ContributorAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

En todo el resto del artículo se usa la palabra "texto". Creo que "cadena" o "cadena de caracteres" puede confundir al lector ya que no se ha explicado lo que es.

lizzie136
lizzie136 approved these changes Aug 22, 2019
View reviewed changes

@lizzie136lizzie136 left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Gracias @tikoflano por estos cambios 🚀

@lizzie136
lizzie136 merged commit 9577373 into javascript-tutorial:masterAug 22, 2019
@iliakaniliakan mentioned this pull request Aug 22, 2019
Open
@javascript-translate-bot

javascript-translate-bot commented Aug 22, 2019

Copy link
Copy Markdown

Thank you 💖 I updated the Progress Issue #17 🎉 🎉 🎉

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@tscandalittatscandalittatscandalitta left review comments
@lizzie136lizzie136lizzie136 approved these changes

Assignees

No one assigned

Labels

needs +1

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@tikoflano@CLAassistant@javascript-translate-bot@lizzie136@tscandalitta