Skip to content

Symbol type - #126

Merged
mahdyar merged 8 commits into
javascript-tutorial:masterfrom
mahdiHash:master
May 25, 2021
Merged

Symbol type#126
mahdyar merged 8 commits into
javascript-tutorial:masterfrom
mahdiHash:master

Conversation

@mahdiHash

@mahdiHashmahdiHash commented May 25, 2021

Copy link
Copy Markdown
Contributor

Please review and comment / commit if anything is wrong

@javascript-translate-bot
javascript-translate-bot requested a review from a teamMay 25, 2021 08:13
@javascript-translate-botjavascript-translate-bot mentioned this pull request May 25, 2021
Open
mahdyar
mahdyar requested changes May 25, 2021
View reviewed changes
Comment thread1-js/04-object-basics/08-symbol/article.md Outdated
Comment thread1-js/04-object-basics/08-symbol/article.md Outdated
Comment thread1-js/04-object-basics/08-symbol/article.md Outdated
Comment thread1-js/04-object-basics/08-symbol/article.md Outdated
@javascript-translate-bot

javascript-translate-bot commented May 25, 2021

Copy link
Copy Markdown

Please make the requested changes. After it, add a comment "/done".
Then I'll ask for a new review 👻

mahdiHashand others added 2 commits May 25, 2021 14:34
@mahdiHash@mahdyar
Apply suggestions from code review
0928a68
Co-authored-by: Mahdyar Hasanpour <thisismahdyar@gmail.com>
@mahdiHash
Apply suggestions
6fb56b0
@mahdiHash

mahdiHash commented May 25, 2021

Copy link
Copy Markdown
ContributorAuthor

Thank you for your review @mahdyar
/done

@javascript-translate-bot
javascript-translate-bot requested a review from a teamMay 25, 2021 10:13
mahdyar
mahdyar approved these changes May 25, 2021
View reviewed changes

@mahdyarmahdyar left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, @mahdiHashemi14!

@mahdyar
mahdyar merged commit 4dac0cd into javascript-tutorial:masterMay 25, 2021
@javascript-translate-bot

javascript-translate-bot commented May 25, 2021

Copy link
Copy Markdown

Thank you 💖 I updated the Progress Issue #1 🎉 🎉 🎉

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mahdyarmahdyarmahdyar approved these changes

Assignees

No one assigned

Labels

needs +1

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@mahdiHash@javascript-translate-bot@mahdyar