Skip to content

Map and Set - #135

Merged
mahdyar merged 18 commits into
javascript-tutorial:masterfrom
mahdiHash:master
Jul 30, 2021
Merged

Map and Set#135
mahdyar merged 18 commits into
javascript-tutorial:masterfrom
mahdiHash:master

Conversation

@mahdiHash

@mahdiHashmahdiHash commented Jul 29, 2021

Copy link
Copy Markdown
Contributor

Please review and commit / comment if anything is wrong

@javascript-translate-bot
javascript-translate-bot requested a review from a teamJuly 29, 2021 11:47
@javascript-translate-botjavascript-translate-bot mentioned this pull request Jul 29, 2021
Open
@mahdyarmahdyar self-assigned this Jul 29, 2021
mahdyar
mahdyar requested changes Jul 30, 2021
View reviewed changes
Comment thread1-js/05-data-types/07-map-set/02-filter-anagrams/solution.md Outdated
Comment thread1-js/05-data-types/07-map-set/02-filter-anagrams/solution.md Outdated
Comment thread1-js/05-data-types/07-map-set/02-filter-anagrams/task.md Outdated
Comment thread1-js/05-data-types/07-map-set/02-filter-anagrams/task.md Outdated
Comment thread1-js/05-data-types/07-map-set/article.md Outdated
@javascript-translate-bot

javascript-translate-bot commented Jul 30, 2021

Copy link
Copy Markdown

Please make the requested changes. After it, add a comment "/done".
Then I'll ask for a new review 👻

mahdiHashand others added 2 commits July 30, 2021 13:26
@mahdiHash@mahdyar
Apply suggestions from code review
459f668
Co-authored-by: Mahdyar Hasanpour <thisismahdyar@gmail.com>
@mahdiHash@mahdyar
Update 1-js/05-data-types/07-map-set/article.md
ac3c902
Co-authored-by: Mahdyar Hasanpour <thisismahdyar@gmail.com>
@mahdiHash

mahdiHash commented Jul 30, 2021

Copy link
Copy Markdown
ContributorAuthor

Thank you, @mahdyar
/done

@javascript-translate-bot
javascript-translate-bot requested a review from a teamJuly 30, 2021 08:58
mahdyar
mahdyar approved these changes Jul 30, 2021
View reviewed changes

@mahdyarmahdyar left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, @mahdiHashemi14!

@mahdyar
mahdyar merged commit 4b86b72 into javascript-tutorial:masterJul 30, 2021
@javascript-translate-bot

javascript-translate-bot commented Jul 30, 2021

Copy link
Copy Markdown

Thank you 💖 I updated the Progress Issue #1 🎉 🎉 🎉

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mahdyarmahdyarmahdyar approved these changes
+1 more reviewer
@always-maapalways-maapalways-maap approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

@mahdyarmahdyar

Labels

needs +1review needed

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@mahdiHash@javascript-translate-bot@mahdyar@always-maap