Skip to content

Mouse events - #149

Merged
mahdyar merged 6 commits into
javascript-tutorial:masterfrom
erfanyeganegi:mouse-event-basics
Sep 11, 2021
Merged

Mouse events#149
mahdyar merged 6 commits into
javascript-tutorial:masterfrom
erfanyeganegi:mouse-event-basics

Conversation

@erfanyeganegi

@erfanyeganegierfanyeganegi commented Sep 10, 2021

Copy link
Copy Markdown
Contributor

No description provided.

@mahdyarmahdyar changed the title mouse-event-basicsMouse eventsSep 10, 2021
@mahdyarmahdyar mentioned this pull request Sep 10, 2021
Open
mahdyar
mahdyar requested changes Sep 10, 2021
View reviewed changes

@mahdyarmahdyar left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello @erfanyeganegi and thank you for your contribution!
Please consider naming your PR after the article name for future PRs (Read the readme if you haven't):

PR title should match article title, the bot will write it's number into the issue.

Comment thread2-ui/3-event-details/1-mouse-events-basics/01-selectable-list/solution.view/index.html Outdated
Comment thread2-ui/3-event-details/1-mouse-events-basics/01-selectable-list/solution.view/index.html
Comment thread2-ui/3-event-details/1-mouse-events-basics/head.html
@javascript-translate-bot

javascript-translate-bot commented Sep 10, 2021

Copy link
Copy Markdown

Please make the requested changes. After it, add a comment "/done".
Then I'll ask for a new review 👻

@erfanyeganegi
Update index.html
18e169c
make the requested changes.
@erfanyeganegi
Revert "mouse-event-basics"
7927eae
This reverts commit 255c30a.
@erfanyeganegi
Update article.md
65a7114
made the requested changes and improved translation.
@erfanyeganegi
requested changes done
550e42c
@erfanyeganegi

erfanyeganegi commented Sep 10, 2021

Copy link
Copy Markdown
ContributorAuthor

/done

mahdyar
mahdyar requested changes Sep 10, 2021
View reviewed changes

@mahdyarmahdyar left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I mentioned some of the problems below, please check it again for any similar problems.
Line numbers shouldn't change.

Comment thread2-ui/3-event-details/1-mouse-events-basics/article.md Outdated
Comment on lines +59 to +65
| `event.button` | وضعیت کلید |
|-------------- | ----------------- |
| 0 | کلید چپ (اصلی) |
| 1 | کلید وسط (کمکی) |
| 2 | کلید راست (ثانوی) |
| 3 | کلید X1 (عقب) |
| 4 | کلید X2 (جلو) |

@mahdyarmahdyarSep 10, 2021

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You shouldn't add spaces here either.

Comment thread2-ui/3-event-details/1-mouse-events-basics/article.md Outdated
};
</script>
```
````

@mahdyarmahdyarSep 10, 2021

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You shouldn't change the format of the article. The last back quote is extra.

Comment thread2-ui/3-event-details/1-mouse-events-basics/article.md Outdated

```warn header="Attention: on Mac it's usually `Cmd` instead of `Ctrl`"
On Windows and Linux there are modifier keys `key:Alt`, `key:Shift` and `key:Ctrl`. On Mac there's one more: `key:Cmd`, corresponding to the property `metaKey`.
```warn header="توجه: روی مک معمولا `Cmd`بجای`Ctrl`خواهد بود" روی ویندوز و لینوکس کلیدهای اصلاح‌کننده `key:Alt`, `key:Shift`و`key:Ctrl`وجود خواهد داشت. روی مک یک کلید دیگر نیز وجود دارد: `key:Cmd`, متناظر خاصیت `metaKey`.

@mahdyarmahdyarSep 10, 2021

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You shouldn't merge them in one line.

@javascript-translate-bot

javascript-translate-bot commented Sep 10, 2021

Copy link
Copy Markdown

Please make the requested changes. After it, add a comment "/done".
Then I'll ask for a new review 👻

@erfanyeganegi

erfanyeganegi commented Sep 10, 2021

Copy link
Copy Markdown
ContributorAuthor

/done

mahdyar
mahdyar approved these changes Sep 11, 2021
View reviewed changes

@mahdyarmahdyar left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, @erfanyeganegi!

@mahdyar
mahdyar merged commit c0c5540 into javascript-tutorial:masterSep 11, 2021
@javascript-translate-bot

javascript-translate-bot commented Sep 11, 2021

Copy link
Copy Markdown

Thank you 💖 I updated the Progress Issue #1 🎉 🎉 🎉

@erfanyeganegi
erfanyeganegi deleted the mouse-event-basics branch September 11, 2021 11:23
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mahdyarmahdyarmahdyar approved these changes

Assignees

No one assigned

Labels

needs +1

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@erfanyeganegi@javascript-translate-bot@mahdyar