Skip to content

Mixins - #189

Merged
mahdyar merged 10 commits into
javascript-tutorial:masterfrom
mahdiHash:master
Jan 10, 2022
Merged

Mixins#189
mahdyar merged 10 commits into
javascript-tutorial:masterfrom
mahdiHash:master

Conversation

@mahdiHash

@mahdiHashmahdiHash commented Jan 8, 2022

Copy link
Copy Markdown
Contributor

Please review and comment/commit if anything is wrong.

@mahdiHash
Translate a part of article
fcefb3a
Line 7 needs more attention
@mahdiHash
Translate a part of article
165c8cb
Line 19 needs more attention.
@mahdiHash
Translate a part of article
68ed640
Line 115, 127 and 139 need more attention.
@mahdiHash
Translate a part of article
89171eb
Line 168 needs more attention.
@mahdiHash
Translate article
3ab3926
Line 206 needs more attention.
@mahdiHash
Translate comments of "head.html"
be0c46a
@mahdiHash
Merge branch 'javascript-tutorial:master' into master
172f3e3
@javascript-translate-bot
javascript-translate-bot requested a review from a teamJanuary 8, 2022 13:31
@javascript-translate-botjavascript-translate-bot mentioned this pull request Jan 8, 2022
Open
mahdiHash
mahdiHash commented Jan 8, 2022
View reviewed changes
Comment thread1-js/09-classes/07-mixins/article.md
mahdiHash
mahdiHash commented Jan 8, 2022
View reviewed changes
Comment thread1-js/09-classes/07-mixins/article.md Outdated
mahdiHash
mahdiHash commented Jan 8, 2022
View reviewed changes
Comment thread1-js/09-classes/07-mixins/article.md
mahdiHash
mahdiHash commented Jan 8, 2022
View reviewed changes
Comment thread1-js/09-classes/07-mixins/article.md Outdated
mahdiHash
mahdiHash commented Jan 8, 2022
View reviewed changes
Comment thread1-js/09-classes/07-mixins/article.md Outdated
mahdiHash
mahdiHash commented Jan 8, 2022
View reviewed changes
Comment thread1-js/09-classes/07-mixins/article.md
mahdiHash
mahdiHash commented Jan 8, 2022
View reviewed changes
Comment thread1-js/09-classes/07-mixins/article.md
@mahdiHash
mahdiHash marked this pull request as ready for review January 8, 2022 13:36
mahdyar
mahdyar approved these changes Jan 9, 2022
View reviewed changes

@mahdyarmahdyar left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please review the suggested change(s) and request for another review.

mahdyar
mahdyar requested changes Jan 9, 2022
View reviewed changes

@mahdyarmahdyar left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please review the suggested change(s) and request for another review.

@javascript-translate-bot

javascript-translate-bot commented Jan 9, 2022

Copy link
Copy Markdown

Please make the requested changes. After it, add a comment "/done".
Then I'll ask for a new review 👻

@mahdiHash
Apply suggestions from code review
c4e040e
Co-authored by: Mahdyar Hasanpour <thisismahdyar@gmail.com>
Beroozam
Beroozam reviewed Jan 9, 2022
View reviewed changes
Comment thread1-js/09-classes/07-mixins/article.md Outdated
@mahdiHash
Change a line
89b3ec1
Co-authored by: Mahdyar Hasanpour <thisismahdyar@gmail.com>
@mahdiHash
Change a line
f3b1569
Co-authored by: @Beroozam
@mahdiHash

mahdiHash commented Jan 10, 2022•
edited
Loading

Copy link
Copy Markdown
ContributorAuthor

Thanks for your reviews @mahdyar@Beroozam
/done

@javascript-translate-bot
javascript-translate-bot requested a review from a teamJanuary 10, 2022 09:28
mahdyar
mahdyar approved these changes Jan 10, 2022
View reviewed changes

@mahdyarmahdyar left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@mahdyar
mahdyar merged commit c6eeb0a into javascript-tutorial:masterJan 10, 2022
@javascript-translate-bot

javascript-translate-bot commented Jan 10, 2022

Copy link
Copy Markdown

Thank you 💖 I updated the Progress Issue #1 🎉 🎉 🎉

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mahdyarmahdyarmahdyar approved these changes
+1 more reviewer
@BeroozamBeroozamBeroozam left review comments
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

needs +1review needed

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@mahdiHash@javascript-translate-bot@mahdyar@Beroozam