Skip to content

Promise - #197

Merged
mahdyar merged 28 commits into
javascript-tutorial:masterfrom
Beroozam:master
Mar 3, 2022
Merged

Promise#197
mahdyar merged 28 commits into
javascript-tutorial:masterfrom
Beroozam:master

Conversation

@Beroozam

@BeroozamBeroozam commented Feb 16, 2022

Copy link
Copy Markdown
Contributor

No description provided.

@javascript-translate-botjavascript-translate-bot mentioned this pull request Feb 16, 2022
Open
mahdiHash
mahdiHash suggested changes Feb 16, 2022
View reviewed changes
Comment thread1-js/11-async/02-promise-basics/01-re-resolve/solution.md Outdated
Comment thread1-js/11-async/02-promise-basics/01-re-resolve/solution.md Outdated
Comment thread1-js/11-async/02-promise-basics/01-re-resolve/task.md Outdated
Comment thread1-js/11-async/02-promise-basics/02-delay-promise/solution.md Outdated
@javascript-translate-bot

javascript-translate-bot commented Feb 16, 2022

Copy link
Copy Markdown

Please make the requested changes. After it, add a comment "/done".
Then I'll ask for a new review 👻

@mahdiHash

mahdiHash commented Feb 16, 2022

Copy link
Copy Markdown
Contributor

Thanks for the translation @Beroozam.
Before I submit a review for other files, I need to know the translation of "Promise".
I think "Promise" doesn't need a translation and it's fine to write it as is.
What do you think @mahdyar?

@mahdyar

mahdyar commented Feb 16, 2022

Copy link
Copy Markdown
Member

Thanks for the translation @Beroozam. Before I submit a review for other files, I need to know the translation of "Promise". I think "Promise" doesn't need a translation and it's fine to write it as is. What do you think @mahdyar?

I agree. it should be as it was.

@Beroozam

Beroozam commented Feb 16, 2022

Copy link
Copy Markdown
ContributorAuthor

I had no idea about this so I wanted you to help in this translation but what do you think about the sentences that start in Persian that we put the phrase پرامیس and other places from Promise.
@mahdiHash
@mahdyar

@Beroozam@mahdiHash
Apply suggestions from code review
2d1288a
Co-authored-by: Mahdi Hashemi <mahdihashemiii939@gmail.com>
@mahdiHash

mahdiHash commented Feb 17, 2022

Copy link
Copy Markdown
Contributor

I had no idea about this so I wanted you to help in this translation but what do you think about the sentences that start in Persian that we put the phrase پرامیس and other places from Promise. @mahdiHash@mahdyar

If you don't know the meaning of a word/sentence and couldn't find it in the glossary, you can ask us in the Translation Help issue.

mahdiHash
mahdiHash suggested changes Feb 17, 2022
View reviewed changes

@mahdiHashmahdiHash left a comment •
edited
Loading

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please review the suggestions.
You can add the suggestions to a batch and create a commit just once (docs).
For now, ignore the suggestions of translation of "settled" until we see what @mahdyar says.

Comment thread1-js/11-async/02-promise-basics/02-delay-promise/task.md Outdated
Comment thread1-js/11-async/02-promise-basics/02-delay-promise/task.md Outdated
Comment thread1-js/11-async/02-promise-basics/02-delay-promise/task.md Outdated
Comment thread1-js/11-async/02-promise-basics/03-animate-circle-promise/solution.view/index.html Outdated
Comment thread1-js/11-async/02-promise-basics/03-animate-circle-promise/task.md Outdated
Comment thread1-js/11-async/02-promise-basics/article.md Outdated
Comment thread1-js/11-async/02-promise-basics/article.md Outdated
Comment thread1-js/11-async/02-promise-basics/article.md Outdated
Comment thread1-js/11-async/02-promise-basics/article.md Outdated
Comment thread1-js/11-async/02-promise-basics/article.md Outdated
@javascript-translate-bot

javascript-translate-bot commented Feb 17, 2022

Copy link
Copy Markdown

Please make the requested changes. After it, add a comment "/done".
Then I'll ask for a new review 👻

@mahdiHash

mahdiHash commented Feb 24, 2022•
edited
Loading

Copy link
Copy Markdown
Contributor

Hi, @Beroozam.
Are you still working on the changes?
I changed my mind about translation of "settled". I think the meaning you've chosen is fine.
You can add all the suggestions to a batch and submit a commit just once (docs). You only need to separately change the lines which have to be rewritten.

@Beroozam@mahdiHash
Apply suggestions from code review
3c76446
Co-authored-by: Mahdi Hashemi <mahdihashemiii939@gmail.com>
Beroozam
Beroozam commented Mar 1, 2022
View reviewed changes

@BeroozamBeroozam left a comment

Copy link
Copy Markdown
ContributorAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please review

Comment thread1-js/11-async/02-promise-basics/article.md Outdated
Comment thread1-js/11-async/02-promise-basics/article.md Outdated
Comment thread1-js/11-async/02-promise-basics/article.md Outdated
Comment thread1-js/11-async/02-promise-basics/article.md Outdated
Comment thread1-js/11-async/02-promise-basics/article.md Outdated
Comment thread1-js/11-async/02-promise-basics/article.md Outdated
Comment thread1-js/11-async/02-promise-basics/article.md Outdated
Comment thread1-js/11-async/02-promise-basics/article.md Outdated
Comment thread1-js/11-async/02-promise-basics/article.md Outdated
Comment thread1-js/11-async/02-promise-basics/article.md Outdated
// runs when the promise is settled, doesn't matter successfully or not
.finally(() => stop loading indicator)
// so the loading indicator is always stopped before we process the result/error
// زمانی اجرا می‌شود که وعده تسویه شود، مهم نیست موفقیت‌آمیز باشد یا نه

@BeroozamBeroozamMar 1, 2022

Copy link
Copy Markdown
ContributorAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
// زمانی اجرا می‌شود که وعده تسویه شود، مهم نیست موفقیت‌آمیز باشد یا نه
// زمانی اجرا می‌شود که promise تسویه شود، مهم نیست موفقیت‌آمیز باشد یا نه

mahdiHash
mahdiHash reviewed Mar 1, 2022
View reviewed changes
Comment thread1-js/11-async/02-promise-basics/article.md Outdated
@Beroozam@mahdiHash
Apply suggestions from code review
9763d18
Co-authored-by: Mahdi Hashemi <mahdihashemiii939@gmail.com>
@mahdiHash

mahdiHash commented Mar 2, 2022

Copy link
Copy Markdown
Contributor

Hi, @Beroozam.
If the translation is ready, please tell us so we merge it :)

@Beroozam

Beroozam commented Mar 2, 2022

Copy link
Copy Markdown
ContributorAuthor

Hi, @mahdiHash
It's done and ready. merge it please .

@mahdiHash

mahdiHash commented Mar 3, 2022

Copy link
Copy Markdown
Contributor

Thanks for your contribution, @Beroozam.

@mahdyar
mahdyar merged commit 115385e into javascript-tutorial:masterMar 3, 2022
@javascript-translate-bot

javascript-translate-bot commented Mar 3, 2022

Copy link
Copy Markdown

Thank you 💖 I updated the Progress Issue #1 🎉 🎉 🎉

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mahdyarmahdyarmahdyar approved these changes
+1 more reviewer
@mahdiHashmahdiHashmahdiHash approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

needs +1

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@Beroozam@javascript-translate-bot@mahdiHash@mahdyar