Skip to content

Automated testing with Mocha - #250

Merged
mahdiHash merged 8 commits into
javascript-tutorial:masterfrom
EhsanShahbazii:patch-1
Jan 3, 2023
Merged

Automated testing with Mocha#250
mahdiHash merged 8 commits into
javascript-tutorial:masterfrom
EhsanShahbazii:patch-1

Conversation

@EhsanShahbazii

@EhsanShahbaziiEhsanShahbazii commented Jan 2, 2023

Copy link
Copy Markdown
Contributor

/done

@javascript-translate-bot
javascript-translate-bot requested a review from a teamJanuary 2, 2023 07:56
@javascript-translate-bot

javascript-translate-bot commented Jan 2, 2023

Copy link
Copy Markdown

Error: the article has another translator @mahdyar in the Progress Issue #1.

@CLAassistant

CLAassistant commented Jan 2, 2023•
edited
Loading

Copy link
Copy Markdown

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.
1 out of 2 committers have signed the CLA.

✅ mahdiHash
❌ EhsanShahbazii
You have signed the CLA already but the status is still pending? Let us recheck it.

mahdiHash
mahdiHash suggested changes Jan 2, 2023
View reviewed changes

@mahdiHashmahdiHash left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please review the changes. Notice the apply-to-whole ones.
You can add the suggestions to a batch and submit a single commit (docs).

Comment thread1-js/03-code-quality/05-testing-mocha/article.md Outdated
Comment thread1-js/03-code-quality/05-testing-mocha/article.md Outdated
Comment thread1-js/03-code-quality/05-testing-mocha/article.md Outdated
Comment thread1-js/03-code-quality/05-testing-mocha/article.md Outdated
Comment thread1-js/03-code-quality/05-testing-mocha/article.md Outdated
Comment thread1-js/03-code-quality/05-testing-mocha/article.md Outdated
Comment thread1-js/03-code-quality/05-testing-mocha/article.md Outdated
Comment thread1-js/03-code-quality/05-testing-mocha/article.md Outdated
Comment thread1-js/03-code-quality/05-testing-mocha/article.md Outdated
Comment thread1-js/03-code-quality/05-testing-mocha/article.md Outdated
@javascript-translate-bot

javascript-translate-bot commented Jan 2, 2023

Copy link
Copy Markdown

Please make the requested changes. After it, add a comment "/done".
Then I'll ask for a new review 👻

@mahdiHash

mahdiHash commented Jan 2, 2023

Copy link
Copy Markdown
Contributor

Please translate the tasks, too.

EhsanShahbaziiand others added 2 commits January 2, 2023 19:58
@EhsanShahbazii@mahdiHash
Update 1-js/03-code-quality/05-testing-mocha/article.md
c2f04b6
Co-authored-by: Mahdi Hashemi <mahdihashemiii939@gmail.com>
@EhsanShahbazii
complete review tasks
1c6a7ed
@EhsanShahbazii

EhsanShahbazii commented Jan 2, 2023

Copy link
Copy Markdown
ContributorAuthor

ok. I corrected the file.

@EhsanShahbazii

EhsanShahbazii commented Jan 2, 2023

Copy link
Copy Markdown
ContributorAuthor

/done

@javascript-translate-bot
javascript-translate-bot requested a review from a teamJanuary 2, 2023 17:07
mahdiHash
mahdiHash suggested changes Jan 2, 2023
View reviewed changes

@mahdiHashmahdiHash left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please review the suggestions.
You can add the suggestions to a batch and submit a single commit (docs).

Comment thread1-js/03-code-quality/05-testing-mocha/article.md Outdated
Comment thread1-js/03-code-quality/05-testing-mocha/article.md Outdated
Comment thread1-js/03-code-quality/05-testing-mocha/article.md Outdated
Comment thread1-js/03-code-quality/05-testing-mocha/article.md Outdated
@javascript-translate-bot

javascript-translate-bot commented Jan 2, 2023

Copy link
Copy Markdown

Please make the requested changes. After it, add a comment "/done".
Then I'll ask for a new review 👻

@EhsanShahbazii@mahdiHash
Apply suggestions from code review
6390b0a
Co-authored-by: Mahdi Hashemi <mahdihashemiii939@gmail.com>
@EhsanShahbazii

EhsanShahbazii commented Jan 2, 2023

Copy link
Copy Markdown
ContributorAuthor

/done

@javascript-translate-bot
javascript-translate-bot requested a review from a teamJanuary 2, 2023 17:56
@mahdiHash
Add an extra line
6478231
Add an extra line to match the LOC of the English article.
@mahdiHash

mahdiHash commented Jan 2, 2023

Copy link
Copy Markdown
Contributor

Please translate the tasks, too.

Have you translated the tasks, @EhsanShahbazii?

@EhsanShahbazii

EhsanShahbazii commented Jan 2, 2023•
edited
Loading

Copy link
Copy Markdown
ContributorAuthor

The word task in article? yes @mahdiHash

@mahdiHash

mahdiHash commented Jan 2, 2023

Copy link
Copy Markdown
Contributor

The word task in article? yes @mahdiHash

No, I mean the task here.
You translated them in #249, but not in this PR.

@EhsanShahbazii

EhsanShahbazii commented Jan 2, 2023

Copy link
Copy Markdown
ContributorAuthor

i see. done @mahdiHash

@mahdiHash

mahdiHash commented Jan 2, 2023

Copy link
Copy Markdown
Contributor

Thanks for your contribution, @EhsanShahbazii.

@EhsanShahbazii

EhsanShahbazii commented Jan 2, 2023•
edited
Loading

Copy link
Copy Markdown
ContributorAuthor

Thank you for your explanation and guidance.🤍 @mahdiHash

@mahdiHash
mahdiHash merged commit 1f1b759 into javascript-tutorial:masterJan 3, 2023
@javascript-translate-bot

javascript-translate-bot commented Jan 3, 2023

Copy link
Copy Markdown

Error: the article has another translator @mahdyar, not @EhsanShahbazii in the Progress Issue #1. Please update the progress issue or ask maintainers to do so.

@mahdiHashmahdiHash mentioned this pull request Jan 3, 2023
Open
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer
@mahdiHashmahdiHashmahdiHash approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

needs +1

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@EhsanShahbazii@javascript-translate-bot@CLAassistant@mahdiHash