Skip to content

Character classes - #252

Merged
mahdiHash merged 10 commits into
javascript-tutorial:masterfrom
EhsanShahbazii:master
Jan 21, 2023
Merged

Character classes#252
mahdiHash merged 10 commits into
javascript-tutorial:masterfrom
EhsanShahbazii:master

Conversation

@EhsanShahbazii

@EhsanShahbaziiEhsanShahbazii commented Jan 19, 2023

Copy link
Copy Markdown
Contributor

/done

@javascript-translate-bot
javascript-translate-bot requested a review from a teamJanuary 19, 2023 22:18
@CLAassistant

CLAassistant commented Jan 19, 2023

Copy link
Copy Markdown

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

@javascript-translate-botjavascript-translate-bot mentioned this pull request Jan 19, 2023
Open
@EhsanShahbazii

EhsanShahbazii commented Jan 19, 2023

Copy link
Copy Markdown
ContributorAuthor

I apologize for my delay.

mahdiHash
mahdiHash suggested changes Jan 20, 2023
View reviewed changes

@mahdiHashmahdiHash left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please review the changes.
You can add the suggestions to a batch and submit a single commit (docs).

You inserted an empty line 182, please remove it.

Comment thread9-regular-expressions/02-regexp-character-classes/article.md Outdated
Comment thread9-regular-expressions/02-regexp-character-classes/article.md Outdated
Comment thread9-regular-expressions/02-regexp-character-classes/article.md Outdated
Comment thread9-regular-expressions/02-regexp-character-classes/article.md Outdated
Comment thread9-regular-expressions/02-regexp-character-classes/article.md Outdated
Comment thread9-regular-expressions/02-regexp-character-classes/article.md Outdated
Comment thread9-regular-expressions/02-regexp-character-classes/article.md Outdated
Comment thread9-regular-expressions/02-regexp-character-classes/article.md Outdated
Comment thread9-regular-expressions/02-regexp-character-classes/article.md Outdated
Comment thread9-regular-expressions/02-regexp-character-classes/article.md Outdated
@javascript-translate-bot

javascript-translate-bot commented Jan 20, 2023

Copy link
Copy Markdown

Please make the requested changes. After it, add a comment "/done".
Then I'll ask for a new review 👻

@mahdiHash

mahdiHash commented Jan 20, 2023

Copy link
Copy Markdown
Contributor

I apologize for my delay.

No worries.

EhsanShahbaziiand others added 2 commits January 20, 2023 11:52
@EhsanShahbazii@mahdiHash
Apply suggestions from code review
13d17fa
Co-authored-by: Mahdi Hashemi <mahdihashemiii939@gmail.com>
@EhsanShahbazii
remove empty line-182
d2258a6
@EhsanShahbazii

EhsanShahbazii commented Jan 20, 2023

Copy link
Copy Markdown
ContributorAuthor

/done

@javascript-translate-bot
javascript-translate-bot requested a review from a teamJanuary 20, 2023 08:25
@mahdiHash

mahdiHash commented Jan 20, 2023

Copy link
Copy Markdown
Contributor

Thanks for your contribution, @EhsanShahbazii.

@mahdiHash
mahdiHash merged commit be57662 into javascript-tutorial:masterJan 21, 2023
@javascript-translate-bot

javascript-translate-bot commented Jan 21, 2023

Copy link
Copy Markdown

Thank you 💖 I updated the Progress Issue #1 🎉 🎉 🎉

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer
@mahdiHashmahdiHashmahdiHash approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

needs +1

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@EhsanShahbazii@CLAassistant@javascript-translate-bot@mahdiHash