Skip to content

Unicode: flag "u" and class \p{...} - #253

Merged
mahdiHash merged 8 commits into
javascript-tutorial:masterfrom
EhsanShahbazii:master
Feb 1, 2023
Merged

Unicode: flag "u" and class \p{...}#253
mahdiHash merged 8 commits into
javascript-tutorial:masterfrom
EhsanShahbazii:master

Conversation

@EhsanShahbazii

@EhsanShahbaziiEhsanShahbazii commented Jan 29, 2023

Copy link
Copy Markdown
Contributor

/done

@javascript-translate-bot
javascript-translate-bot requested a review from a teamJanuary 29, 2023 17:33
@CLAassistant

CLAassistant commented Jan 29, 2023

Copy link
Copy Markdown

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

@javascript-translate-botjavascript-translate-bot mentioned this pull request Jan 29, 2023
Open
mahdiHash
mahdiHash suggested changes Jan 31, 2023
View reviewed changes

@mahdiHashmahdiHash left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please review the changes.
You can add the suggestions to a batch and submit a single commit (docs).

Comment thread9-regular-expressions/03-regexp-unicode/article.md Outdated
Comment thread9-regular-expressions/03-regexp-unicode/article.md Outdated
Comment thread9-regular-expressions/03-regexp-unicode/article.md Outdated
Comment thread9-regular-expressions/03-regexp-unicode/article.md Outdated
Comment thread9-regular-expressions/03-regexp-unicode/article.md Outdated
@javascript-translate-bot

javascript-translate-bot commented Jan 31, 2023

Copy link
Copy Markdown

Please make the requested changes. After it, add a comment "/done".
Then I'll ask for a new review 👻

@EhsanShahbazii

EhsanShahbazii commented Jan 31, 2023

Copy link
Copy Markdown
ContributorAuthor

/done

@javascript-translate-bot
javascript-translate-bot requested a review from a teamJanuary 31, 2023 09:18
@mahdiHash

mahdiHash commented Jan 31, 2023

Copy link
Copy Markdown
Contributor

Thanks for your contribution, @EhsanShahbazii.

@mahdiHash
mahdiHash merged commit 5b03f80 into javascript-tutorial:masterFeb 1, 2023
@javascript-translate-bot

javascript-translate-bot commented Feb 1, 2023

Copy link
Copy Markdown

Thank you 💖 I updated the Progress Issue #1 🎉 🎉 🎉

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer
@mahdiHashmahdiHashmahdiHash approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

needs +1

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@EhsanShahbazii@CLAassistant@javascript-translate-bot@mahdiHash