Skip to content

Unicode, String internals - #269

Merged
mahdiHash merged 9 commits into
javascript-tutorial:masterfrom
mostafa-nematpour:unicode
Jul 14, 2023
Merged

Unicode, String internals#269
mahdiHash merged 9 commits into
javascript-tutorial:masterfrom
mostafa-nematpour:unicode

Conversation

@mostafa-nematpour

@mostafa-nematpourmostafa-nematpour commented Jul 12, 2023

Copy link
Copy Markdown
Contributor

translate Unicode, String internals

@javascript-translate-bot
javascript-translate-bot requested a review from a teamJuly 12, 2023 21:09
@CLAassistant

CLAassistant commented Jul 12, 2023•
edited
Loading

Copy link
Copy Markdown

CLA assistant check
All committers have signed the CLA.

@javascript-translate-botjavascript-translate-bot mentioned this pull request Jul 12, 2023
Open
mahdyar
mahdyar requested changes Jul 12, 2023
View reviewed changes
Comment thread1-js/99-js-misc/06-unicode/article.md Outdated
Comment thread1-js/99-js-misc/06-unicode/article.md Outdated
@javascript-translate-bot

javascript-translate-bot commented Jul 12, 2023

Copy link
Copy Markdown

Please make the requested changes. After it, add a comment "/done".
Then I'll ask for a new review 👻

mostafa-nematpourand others added 2 commits July 13, 2023 01:27
@mostafa-nematpour@mahdyar
Update 1-js/99-js-misc/06-unicode/article.md
aaed2cf
Co-authored-by: Mahdyar Hasanpour <mahdyar@duck.com>
@mostafa-nematpour@mahdyar
Update 1-js/99-js-misc/06-unicode/article.md
6a0a2fe
Co-authored-by: Mahdyar Hasanpour <mahdyar@duck.com>
@mostafa-nematpour

mostafa-nematpour commented Jul 12, 2023

Copy link
Copy Markdown
ContributorAuthor

/done

@javascript-translate-bot
javascript-translate-bot requested a review from a teamJuly 12, 2023 21:58
mahdiHash
mahdiHash suggested changes Jul 13, 2023
View reviewed changes

@mahdiHashmahdiHash left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please review the suggestions.
You can add the suggestions to a batch and create a commit just once (docs).

Comment thread1-js/99-js-misc/06-unicode/article.md
Comment thread1-js/99-js-misc/06-unicode/article.md Outdated
Comment thread1-js/99-js-misc/06-unicode/article.md
Comment thread1-js/99-js-misc/06-unicode/article.md
Comment thread1-js/99-js-misc/06-unicode/article.md Outdated
@javascript-translate-bot

javascript-translate-bot commented Jul 13, 2023

Copy link
Copy Markdown

Please make the requested changes. After it, add a comment "/done".
Then I'll ask for a new review 👻

mostafa-nematpourand others added 5 commits July 13, 2023 09:26
@mostafa-nematpour@mahdiHash
Update 1-js/99-js-misc/06-unicode/article.md
38c9bca
Co-authored-by: Mahdi Hashemi <mahdihashemiii939@gmail.com>
@mostafa-nematpour@mahdiHash
Update 1-js/99-js-misc/06-unicode/article.md
6e0e19a
Co-authored-by: Mahdi Hashemi <mahdihashemiii939@gmail.com>
@mostafa-nematpour@mahdiHash
Update 1-js/99-js-misc/06-unicode/article.md
e18f96d
Co-authored-by: Mahdi Hashemi <mahdihashemiii939@gmail.com>
@mostafa-nematpour@mahdiHash
Update 1-js/99-js-misc/06-unicode/article.md
e689815
Co-authored-by: Mahdi Hashemi <mahdihashemiii939@gmail.com>
@mostafa-nematpour
update 1-js/99-js-misc/06-unicode/article.md line 121
4872e29
@mostafa-nematpour

mostafa-nematpour commented Jul 13, 2023

Copy link
Copy Markdown
ContributorAuthor

Thanks for the suggestions Mehdi
I will try to be better and next time I will put all in one
I'm not good at it
/done

@javascript-translate-bot
javascript-translate-bot requested a review from a teamJuly 13, 2023 06:34
@mahdiHash

mahdiHash commented Jul 13, 2023

Copy link
Copy Markdown
Contributor

Thanks for the suggestions Mehdi I will try to be better and next time I will put all in one I'm not good at it /done

No worries, mate :)
Thanks for your contribution, @mostafa-nematpour.

@mahdiHash
mahdiHash merged commit 3190e58 into javascript-tutorial:masterJul 14, 2023
@javascript-translate-bot

javascript-translate-bot commented Jul 14, 2023

Copy link
Copy Markdown

Thank you 💖 I updated the Progress Issue #1 🎉 🎉 🎉

@mostafa-nematpour
mostafa-nematpour deleted the unicode branch July 14, 2023 09:33
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mahdyarmahdyarmahdyar requested changes
+1 more reviewer
@mahdiHashmahdiHashmahdiHash approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

needs +1

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@mostafa-nematpour@CLAassistant@javascript-translate-bot@mahdiHash@mahdyar