Skip to content

Code editors - #22

Merged
theBstar merged 5 commits into
javascript-tutorial:masterfrom
ayushhagarwal:master
Jun 28, 2020
Merged

Code editors#22
theBstar merged 5 commits into
javascript-tutorial:masterfrom
ayushhagarwal:master

Conversation

@ayushhagarwal

@ayushhagarwalayushhagarwal commented Jun 27, 2020

Copy link
Copy Markdown
Contributor

Hindi translation done for Code Editors documentation in javascript.info.

@ayushhagarwal
Update article.md
60f5ae6
Heading changed for testing work not completed
@ayushhagarwal
update article.md for code editors.
3c1b65b
Complete article translated to hindi.
@javascript-translate-bot
javascript-translate-bot requested a review from a teamJune 27, 2020 16:32
@CLAassistant

CLAassistant commented Jun 27, 2020•
edited
Loading

Copy link
Copy Markdown

CLA assistant check
All committers have signed the CLA.

@theBstartheBstar changed the title Code EditorsCode editorsJun 27, 2020
@theBstar

theBstar commented Jun 27, 2020

Copy link
Copy Markdown
Member

Hey added a bunch of comments feel free to disagree. Nice job overall. Sometimes you need to play around with the English version to get the translation right when using automated tools. The translated version not only has to be correct but meaningful in the context as well. Thanks for your time, Now let's wrap this up asap. 👍

theBstar
theBstar requested changes Jun 27, 2020
View reviewed changes

@theBstartheBstar left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have left some comments where I thought we could improve. This looks good to be merged post changes. Feel free to disagree!

Comment thread1-js/01-getting-started/3-code-editors/article.md Outdated
Comment thread1-js/01-getting-started/3-code-editors/article.md
Comment thread1-js/01-getting-started/3-code-editors/article.md Outdated
Comment thread1-js/01-getting-started/3-code-editors/article.md Outdated
Comment thread1-js/01-getting-started/3-code-editors/article.md Outdated
Comment thread1-js/01-getting-started/3-code-editors/article.md Outdated
Comment thread1-js/01-getting-started/3-code-editors/article.md Outdated
@javascript-translate-bot

javascript-translate-bot commented Jun 27, 2020

Copy link
Copy Markdown

Please make the requested changes. After it, add a comment "/done".
Then I'll ask for a new review 👻

@ayushhagarwal

ayushhagarwal commented Jun 28, 2020

Copy link
Copy Markdown
ContributorAuthor

/done

@javascript-translate-bot
javascript-translate-bot requested a review from a teamJune 28, 2020 06:08
theBstar
theBstar approved these changes Jun 28, 2020
View reviewed changes

@theBstartheBstar left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to be merged. There are certain possible improvements around the context and meanings though. Can be merged now.

@theBstar
theBstar merged commit 6ec932a into javascript-tutorial:masterJun 28, 2020
@iliakaniliakan mentioned this pull request Jun 28, 2020
Open
@javascript-translate-bot

javascript-translate-bot commented Jun 28, 2020

Copy link
Copy Markdown

Thank you 💖 I updated the Progress Issue #1 🎉 🎉 🎉

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@theBstartheBstartheBstar approved these changes

Assignees

No one assigned

Labels

needs +1

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@ayushhagarwal@CLAassistant@theBstar@javascript-translate-bot