Skip to content

Variables - #30

Merged
theBstar merged 4 commits into
javascript-tutorial:masterfrom
ashpratap007:master
Aug 5, 2020
Merged

Variables#30
theBstar merged 4 commits into
javascript-tutorial:masterfrom
ashpratap007:master

Conversation

@ashpratap007

@ashpratap007ashpratap007 commented Jul 30, 2020

Copy link
Copy Markdown
Contributor

Hindi translations for topic "Variables".

@theBstar

theBstar commented Jul 31, 2020

Copy link
Copy Markdown
Member

Thank you for submitting the PR. I will review it by tomorrow.

theBstar
theBstar requested changes Aug 2, 2020
View reviewed changes

@theBstartheBstar left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey, @ashpratap007 added a few comments. Overall a good job. Thank you for contributing towards a good cause. Let's make the changes, then we will merge it. Let me know if I can help with anything.

Comment thread1-js/02-first-steps/04-variables/1-hello-variables/solution.md Outdated
Comment thread1-js/02-first-steps/04-variables/1-hello-variables/task.md Outdated
Comment thread1-js/02-first-steps/04-variables/2-declare-variables/solution.md
Comment thread1-js/02-first-steps/04-variables/2-declare-variables/solution.md Outdated
Comment thread1-js/02-first-steps/04-variables/2-declare-variables/solution.md Outdated
Comment thread1-js/02-first-steps/04-variables/article.md Outdated
Comment thread1-js/02-first-steps/04-variables/article.md Outdated
Comment thread1-js/02-first-steps/04-variables/article.md Outdated
Comment thread1-js/02-first-steps/04-variables/article.md Outdated
Comment thread1-js/02-first-steps/04-variables/article.md Outdated
@javascript-translate-bot

javascript-translate-bot commented Aug 2, 2020

Copy link
Copy Markdown

Please make the requested changes. After it, add a comment "/done".
Then I'll ask for a new review 👻

ashpratap007
ashpratap007 commented Aug 3, 2020
View reviewed changes

@ashpratap007ashpratap007 left a comment

Copy link
Copy Markdown
ContributorAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the wonderful review. This being my first open-source contribution, kindly bear with me.

@ashpratap007

ashpratap007 commented Aug 3, 2020

Copy link
Copy Markdown
ContributorAuthor

/done

@theBstar

theBstar commented Aug 5, 2020

Copy link
Copy Markdown
Member

Thanks for the wonderful review. This being my first open-source contribution, kindly bear with me.

Hey, It was awesome! Merging this PR. Congrats for your first open-source contribution 🎉🎉. Hoping to see many more from you in the coming days. Thank you.

@theBstar
theBstar merged commit 411b351 into javascript-tutorial:masterAug 5, 2020
@iliakaniliakan mentioned this pull request Aug 5, 2020
Open
@javascript-translate-bot

javascript-translate-bot commented Aug 5, 2020

Copy link
Copy Markdown

Thank you 💖 I updated the Progress Issue #1 🎉 🎉 🎉

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@theBstartheBstartheBstar approved these changes

Assignees

No one assigned

Labels

needs +1

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@ashpratap007@theBstar@javascript-translate-bot