Comments - #77

Merged

rskhan167 merged 6 commits into

javascript-tutorial:masterfrom

Deep1Shikha:patch-1

Sep 23, 2021

Deep1Shikha commented Sep 14, 2021

Contributor

Comments

Comments

b6f3119

Comments

javascript-translate-bot added the review needed label

javascript-translate-bot requested a review from a team

September 14, 2021 15:41

CLAassistant commented Sep 14, 2021•
edited
Loading

All committers have signed the CLA.

javascript-translate-bot mentioned this pull request

Hindi Translation Progress #1

Open

rskhan167 requested review from rskhan167 and removed request for rskhan167

September 15, 2021 05:17

rskhan167 reviewed

View reviewed changes

1-js/03-code-quality/03-comments/article.md

rskhan167 reviewed

View reviewed changes

1-js/03-code-quality/03-comments/article.md Outdated

rskhan167 reviewed

View reviewed changes

1-js/03-code-quality/03-comments/article.md Outdated

rskhan167 reviewed

View reviewed changes

1-js/03-code-quality/03-comments/article.md Outdated

rskhan167 reviewed

View reviewed changes

1-js/03-code-quality/03-comments/article.md Outdated

rskhan167 reviewed

View reviewed changes

1-js/03-code-quality/03-comments/article.md Outdated

rskhan167 reviewed

View reviewed changes

1-js/03-code-quality/03-comments/article.md Outdated

rskhan167 reviewed

View reviewed changes

1-js/03-code-quality/03-comments/article.md Outdated

rskhan167 reviewed

View reviewed changes

1-js/03-code-quality/03-comments/article.md Outdated

rskhan167 reviewed

View reviewed changes

1-js/03-code-quality/03-comments/article.md Outdated

rskhan167 reviewed

View reviewed changes

1-js/03-code-quality/03-comments/article.md Outdated

rskhan167 reviewed

View reviewed changes

rskhan167 left a comment

Contributor

These are some changes required please address these. And let me know if you need any help. Thanks.

Deep1Shikha added 2 commits

September 15, 2021 13:54

Update article.md

2434c78

Updated as per review

Update article.md

490924c

Implemented changes for first review comment

Deep1Shikha commented Sep 15, 2021

ContributorAuthor

Thanks for the suggestions, I have pushed the changes.

rskhan167 requested changes

View reviewed changes

1-js/03-code-quality/03-comments/article.md Outdated

1-js/03-code-quality/03-comments/article.md Outdated

1-js/03-code-quality/03-comments/article.md Outdated

javascript-translate-bot added changes requested and removed review needed labels

javascript-translate-bot commented Sep 15, 2021

Please make the requested changes. After it, add a comment "/done".
Then I'll ask for a new review 👻

rskhan167 commented Sep 15, 2021

Contributor

Thanks for the suggestions, I have pushed the changes.

A few more change requests have been added. Please address those too. Thanks.

Comments

7f09965

Comments /done

javascript-translate-bot removed the changes requested label

Deep1Shikha commented Sep 15, 2021

ContributorAuthor

/done

javascript-translate-bot requested a review from a team

September 15, 2021 09:45

rskhan167 requested changes

View reviewed changes

rskhan167 left a comment

Contributor

Everything looks good. There is this one change I found. After this I think it is ready to get merged.

1-js/03-code-quality/03-comments/article.md Outdated

javascript-translate-bot added changes requested and removed review needed labels

javascript-translate-bot commented Sep 15, 2021

Please make the requested changes. After it, add a comment "/done".
Then I'll ask for a new review 👻

Comments

90a54a1

Comments updated

Deep1Shikha requested a review from rskhan167

September 17, 2021 12:52

Deep1Shikha commented Sep 17, 2021

ContributorAuthor

/done

javascript-translate-bot added review needed and removed changes requested labels

javascript-translate-bot requested a review from a team

September 17, 2021 12:52

rskhan167 requested changes

View reviewed changes

rskhan167 left a comment

Contributor

It seems you forgot to change वास्तुकला to संरचना at other place. Please change that and request review

1-js/03-code-quality/03-comments/article.md Outdated

1-js/03-code-quality/03-comments/article.md Outdated

1-js/03-code-quality/03-comments/article.md Outdated

javascript-translate-bot added changes requested and removed review needed labels

javascript-translate-bot commented Sep 17, 2021

Please make the requested changes. After it, add a comment "/done".
Then I'll ask for a new review 👻

Comments

62f65ab

Updated changes as per suggestions

javascript-translate-bot added review needed and removed changes requested labels

javascript-translate-bot requested a review from a team

September 22, 2021 18:11

Deep1Shikha requested review from rskhan167 and removed request for a team

September 23, 2021 14:24

Deep1Shikha commented Sep 23, 2021

ContributorAuthor

/done

javascript-translate-bot requested a review from a team

September 23, 2021 14:24

rskhan167 commented Sep 23, 2021

Contributor

Good work @Deep1Shikha , thanks for contributing. I am merging this PR. Hoping to see many more contributions from you. And Please let your friends and colleagues also know about this project. Thanks 👍

rskhan167 merged commit b90bfda into javascript-tutorial:master

javascript-translate-bot commented Sep 23, 2021

Thank you 💖 I updated the Progress Issue #1 🎉 🎉 🎉

Deep1Shikha commented Sep 23, 2021

ContributorAuthor

Thank you! I am equally enthusiastic and glad. This was my first contribution and it has been merged. I will continue contributing. Grateful to you for your reviews. 🎉

rskhan167 added ready to merge and removed review needed labels

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment