Skip to content

Custom errors, extending Error - #163

Merged
longo-andrea merged 7 commits into
javascript-tutorial:masterfrom
longo-andrea:feature/custom-errors
Jan 16, 2021
Merged

Custom errors, extending Error#163
longo-andrea merged 7 commits into
javascript-tutorial:masterfrom
longo-andrea:feature/custom-errors

Conversation

@longo-andrea

@longo-andrealongo-andrea commented Jan 8, 2021

Copy link
Copy Markdown
Contributor

Questa PR contiene le modifiche richieste nella RP: #153

@javascript-translate-bot
javascript-translate-bot requested a review from a teamJanuary 8, 2021 21:39
@javascript-translate-bot

javascript-translate-bot commented Jan 8, 2021

Copy link
Copy Markdown

Error: the article already has PR number in the Progress Issue #1, it's 153 ⁉️

@pasor1pasor1 mentioned this pull request Jan 9, 2021
Open
pasor1
pasor1 requested changes Jan 9, 2021
View reviewed changes
Comment thread1-js/10-error-handling/2-custom-errors/article.md Outdated
Comment thread1-js/10-error-handling/2-custom-errors/article.md Outdated
Comment thread1-js/10-error-handling/2-custom-errors/article.md Outdated
Comment thread1-js/10-error-handling/2-custom-errors/article.md Outdated
Comment thread1-js/10-error-handling/2-custom-errors/article.md Outdated
Comment thread1-js/10-error-handling/2-custom-errors/article.md Outdated
Comment thread1-js/10-error-handling/2-custom-errors/article.md Outdated
Comment thread1-js/10-error-handling/2-custom-errors/article.md Outdated
Comment thread1-js/10-error-handling/2-custom-errors/article.md Outdated
@javascript-translate-bot

javascript-translate-bot commented Jan 9, 2021

Copy link
Copy Markdown

Please make the requested changes. After it, add a comment "/done".
Then I'll ask for a new review 👻

longo-andreaand others added 6 commits January 9, 2021 19:03
@longo-andrea@pasor1
Update 1-js/10-error-handling/2-custom-errors/article.md
1695a18
Co-authored-by: Simone Pasini <66781510+pasor1@users.noreply.github.com>
@longo-andrea@pasor1
Update 1-js/10-error-handling/2-custom-errors/article.md
f7e73c5
Co-authored-by: Simone Pasini <66781510+pasor1@users.noreply.github.com>
@longo-andrea@pasor1
Update 1-js/10-error-handling/2-custom-errors/article.md
40f2ef5
Co-authored-by: Simone Pasini <66781510+pasor1@users.noreply.github.com>
@longo-andrea@pasor1
Update 1-js/10-error-handling/2-custom-errors/article.md
3181406
Co-authored-by: Simone Pasini <66781510+pasor1@users.noreply.github.com>
@longo-andrea@pasor1
Apply suggestions from code review
06c7ac0
Co-authored-by: Simone Pasini <66781510+pasor1@users.noreply.github.com>
@longo-andrea
Update article.md
dabe676
@longo-andrea

longo-andrea commented Jan 9, 2021

Copy link
Copy Markdown
ContributorAuthor

/done

@javascript-translate-bot
javascript-translate-bot requested a review from a teamJanuary 9, 2021 18:11
@longo-andrea
longo-andrea merged commit 85720d1 into javascript-tutorial:masterJan 16, 2021
@javascript-translate-bot

javascript-translate-bot commented Jan 16, 2021

Copy link
Copy Markdown

Thank you 💖 I updated the Progress Issue #1 🎉 🎉 🎉

@longo-andrea
longo-andrea deleted the feature/custom-errors branch January 23, 2021 10:31
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@pasor1pasor1pasor1 approved these changes

Assignees

No one assigned

Labels

needs +1

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@longo-andrea@javascript-translate-bot@pasor1